App\Http\Controllers\ForumTopicController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	130
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	index()	0	37	9
A	edit()	0	2	1
A	show()	0	3	1
A	destroy()	0	2	1
A	update()	0	12	2
A	store()	0	13	1
A	create()	0	2	1

<?php

namespace App\Http\Controllers;

use App\Models\ForumTopic;
use Illuminate\Http\Request;

class ForumTopicController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $query = ForumTopic::query();

        if ($request->has('searchTerm')) {
            $columnsToSearch = ['title', 'email', 'phone'];
            $search_term = json_decode($request->searchTerm)->searchTerm;
            if (! empty($search_term)) {
                $searchQuery = '%'.$search_term.'%';
                foreach ($columnsToSearch as $column) {
                    $query->orWhere($column, 'LIKE', $searchQuery);
                }
            }
        }

        if ($request->has('columnFilters')) {
            $filters = get_object_vars(json_decode($request->columnFilters));

            foreach ($filters as $key => $value) {
                if (! empty($value)) {
                    $query->orWhere($key, 'like', '%'.$value.'%');
                }
            }
        }

        if ($request->has('sort.0')) {
            $sort = json_decode($request->sort[0]);
            $query->orderBy($sort->field, $sort->type);
        }

        if ($request->has('perPage')) {
            $rows = $query->paginate($request->perPage);
        } else {
            $rows = $query->get();
        }

        return $rows;

The expression return $rows returns the type Illuminate\Database\Eloquent\Collection|Illuminate\Pagination\LengthAwarePaginator which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $request->validate([
            'category_id' => 'required|integer',
            'title' => 'required',
            'content' => 'required',
        ]);

        return ForumTopic::create([

The expression return App\Models\ForumTopic::create(array('category_id' => $request->category_id, 'title' => $request->title, 'content' => $request->content, 'created_by' => $request->user()->id)) also could return the type App\Models\ForumTopic which is incompatible with the documented return type Illuminate\Http\Response.

            'category_id' => $request->category_id,
            'title' => $request->title,
            'content' => $request->content,
            'created_by' => $request->user()->id,
        ]);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Models\ForumTopic  $forumTopic
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        return ForumTopic::where('slug', $id)->with('category')->with('posts')->with('author')->first();

The expression return App\Models\ForumTopic::where('slug', $id)->with('category')->with('posts')->with('author')->first() also could return the type App\Models\ForumTopic which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Models\ForumTopic  $forumTopic
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Models\ForumTopic  $forumTopic
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $request->validate([
            'category_id' => 'required|integer',
            'title' => 'required',
            'content' => 'required',
        ]);
        $topic = ForumTopic::find($id);
        if ($topic) {
            $topic->category_id = $request->category_id;
            $topic->title = $request->title;
            $topic->save();
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Models\ForumTopic  $forumTopic
     * @return \Illuminate\Http\Response
     */
    public function destroy(ForumTopic $forumTopic)

The parameter $forumTopic is not used and could be removed.

    {
        //
    }
}