falon / RBL

contrib/ipImap/function.php

Doc Comments +23 added lines

@@ -1,4 +1,7 @@ 
 <?php
+/**
+ * @param string $header
+ */
 function getIP($header,$mxserver,$msa) {
 /* Get submission server's IP from header's mail */
 /* Each line must end with /r/n			 */
@@ -28,11 +31,24 @@ 
 	return array($ip,$host,$dateR,$dateC['date'],$mid['mid']);
 }
 
+/**
+ * @param string|false $ip
+ * @param string $hostname
+ * @param string $dateC
+ * @param string|null $msgid
+ * @param string|false $dateL
+ */
 function updateReport ($ip,$uid,$ipcount,$uidcount,$hostname,$dateC,$msgid,$dateL) {
 
 	return sprintf ('<tr><td nowrap>%s</td><td nowrap>%s</td><td>%s</td><td>%s</td><td>%u</td><td>%u</td><td>%s</td><td>%s</td></tr>'."\n",$dateL,$dateC,$uid,$ip,$uidcount,$ipcount,$hostname,htmlentities($msgid) );
 }
 
+/**
+ * @param string $dateC
+ * @param string|null $msgid
+ * @param string|false $dateL
+ * @param string $text
+ */
 function updatebadReport ( $uid,$dateC,$msgid,$dateL,$text ) {
 	return sprintf ('<tr><td nowrap>%s</td><td nowrap>%s</td><td>%s</td><td>%s</td><td nowrap>%s</td></tr>'."\n",$dateL,$dateC,$uid,htmlentities($msgid),$text );
 }
@@ -84,6 +100,9 @@ 
 }
 
 
+/**
+ * @param null|mysqli $myconn
+ */
 function summaryReportAndList ($cf,$myconn,$tables,$category,$ipvet) {
 	$nips = $ipvet['count'];
 
@@ -154,6 +173,10 @@ 
 }
 
 
+/**
+ * @param string $message_id
+ * @param string $date
+ */
 function splunksearch ($service,$message_id,$date) {
 
 	// Run a blocking search

Braces +110 added lines, -62 removed lines

@@ -10,21 +10,25 @@ 
 	if ( preg_match_all('/^Received:\sfrom(?:.|\r\n\s)*?[\[\(]\s*(?P<ip>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})[\]\)](?:.|\r\n\s)+\s+by(?:\s|\r\n\s+)(?P<host>\S+).*(?:\s|\r\n\s\s)+.*;\s+(?P<date>.*)/m',$header,$received) ) {
 		for ($i = count($received[0])-1;$i>=0;$i--) {
 #			print "Examine ".$received[0][$i]."\n";
-			if ( preg_match($msa,$received['host'][$i]) )
-				$dateR = $received['date'][$i];
+			if ( preg_match($msa,$received['host'][$i]) ) {
+							$dateR = $received['date'][$i];
+			}
         		foreach ($mxserver as $mx) {
-        			if (!$ip)
-					if ($mx == $received['host'][$i]) {
+        			if (!$ip) {
+        								if ($mx == $received['host'][$i]) {
 						$host = $received['host'][$i];
+        			}
 						$ip = $received['ip'][$i];
                     			}
                 	}
         	}
 	}
-	if ( preg_match ('/\r\nDate:\s(?P<date>.*)\r\n/',$header,$dateC) != 1)
-		$dateC['date'] = 'Not found';
-	if ( preg_match ('/\r\nMessage\-I(?:D|d):\s(?P<mid>.*)\r\n/',$header,$mid) != 1)
-		$mid['mid'] = NULL;
+	if ( preg_match ('/\r\nDate:\s(?P<date>.*)\r\n/',$header,$dateC) != 1) {
+			$dateC['date'] = 'Not found';
+	}
+	if ( preg_match ('/\r\nMessage\-I(?:D|d):\s(?P<mid>.*)\r\n/',$header,$mid) != 1) {
+			$mid['mid'] = NULL;
+	}
 	return array($ip,$host,$dateR,$dateC['date'],$mid['mid']);
 }
 
@@ -40,7 +44,9 @@ 
 
 function summaryBadReport ($uidvet) {
         $nuid = $uidvet['count'];
-        if ( empty($uidvet) ) return NULL;
+        if ( empty($uidvet) ) {
+        	return NULL;
+        }
         $return = '<hr><h3>Statistics by UID</h3><table><tr><th>UID</th><th>Learned times</th></tr>'."\n";
 
         /* Remove count index */
@@ -75,8 +81,12 @@ 
     foreach ($colarr as $col => $arr) {
         foreach ($arr as $k => $v) {
             $k = substr($k,1);
-            if (!isset($ret[$k])) $ret[$k] = $array[$k];
-            if (isset ($array[$k][$col])) $ret[$k][$col] = $array[$k][$col];
+            if (!isset($ret[$k])) {
+            	$ret[$k] = $array[$k];
+            }
+            if (isset ($array[$k][$col])) {
+            	$ret[$k][$col] = $array[$k][$col];
+            }
         }
     }
     return $ret;
@@ -87,13 +97,17 @@ 
 function summaryReportAndList ($cf,$myconn,$tables,$category,$ipvet) {
 	$nips = $ipvet['count'];
 
-	if ( empty($ipvet) ) return NULL;
+	if ( empty($ipvet) ) {
+		return NULL;
+	}
 	$return = '<h3>Statistics by IP</h3><table><tr><th>IP</th><th>Learned by</th><th>Learned times</th><th title="This field doesn\'t say if this ip is currently listed, but it says if this IP has listed now!">Listed Now</th></tr>'."\n";
 	
 	$ips = array_keys($ipvet['ip']);
 
 	foreach ( $ips as $ip ) {
-		if ( $ip == 'count' ) continue;
+		if ( $ip == 'count' ) {
+			continue;
+		}
                 $nlearn = $ipvet['ip']["$ip"]['count'];
                 unset($ipvet['ip']["$ip"]['count']);
 		$nuid = count($ipvet['ip']["$ip"]);
@@ -101,10 +115,12 @@ 
 			if ( ($nlearn >= $cf['thresholdip']["$category"])AND($nuid >= $cf['thresholduid']["$category"]) ) {
 				$reason = "The IP <$ip> has been listed because was marked $nlearn times as $category by $nuid different accounts during last ".$cf['oldestday'].' days.';
 				$listed = searchAndList ($myconn,$cf['user'],$tables,$cf['list']["$category"],$ip,$cf['unit']["$category"],$cf['quantity']["$category"],$reason);
+			} else {
+				$listed = FALSE;
 			}
-			else $listed = FALSE;
+		} else {
+			$listed = FALSE;
 		}
-		else $listed = FALSE;
 		$nowlist = array( TRUE =>  array(
 					'style' => 'id=\'ipfound\'',
 					'name'  => 'YES',
@@ -122,7 +138,9 @@ 
 		$return .='<tr><td rowspan="'.$nuid.'">'.$ip.'</td>';
 		$return .= sprintf ('<td>%s</td><td rowspan="'.$nuid.'">%u</td><td rowspan="'.$nuid.'" '.$nowlist["$listed"]['style'].'>%s</td></tr>',$ipvet['ip']["$ip"][0],$nlearn,$nowlist["$listed"]['name']);
 		$rowuid=NULL;
-                for ($j=1;$j<$nuid;$j++) $rowuid .= '<tr><td>%s</td></tr>';
+                for ($j=1;$j<$nuid;$j++) {
+                	$rowuid .= '<tr><td>%s</td></tr>';
+                }
 		array_shift($ipvet['ip']["$ip"]);
                 $return .= vsprintf ($rowuid,$ipvet['ip']["$ip"]);
 
@@ -135,14 +153,18 @@ 
 	$return .= '<h3>Statistics by UID</h3><table><tr><th>UID</th><th>IP learned</th><th>Learned times</th></tr>'."\n";
 	$uids = array_keys($ipvet['uid']);
         foreach ( $uids as $uid ) {
-		if ( $uid == 'count' ) continue;	
+		if ( $uid == 'count' ) {
+			continue;
+		}
 	        $nlearn = $ipvet['uid']["$uid"]['count'];
 	        unset ( $ipvet['uid']["$uid"]['count'] );
 		$nip = count($ipvet['uid']["$uid"]);
 		$return .='<tr><td rowspan="'.$nip.'">'.$uid.'</td>';
 		$return .= sprintf ('<td>%s</td><td rowspan="'.$nip.'">%u</td></tr>',$ipvet['uid']["$uid"][0],$nlearn);
                 $rowuid=NULL;
-                for ($j=1;$j<$nip;$j++) $rowuid .= '<tr><td>%s</td></tr>';
+                for ($j=1;$j<$nip;$j++) {
+                	$rowuid .= '<tr><td>%s</td></tr>';
+                }
                 array_shift($ipvet['uid']["$uid"]);
                 $return .= vsprintf ($rowuid,$ipvet['uid']["$uid"]);
 
@@ -181,7 +203,9 @@ 
 	echo ' seconds</p>';
 	*/
 
-	if ($job['resultCount'] == 0) return FALSE;
+	if ($job['resultCount'] == 0) {
+		return FALSE;
+	}
 
 	// Get job results
 	$resultSearch = $job->getResults();
@@ -194,14 +218,14 @@ 
 	    {
 	      // More than one field attribute returned by search
 	      // You must redefine the search
-	      if ( count($result->getFieldNames()) > 1 ) return FALSE;
-	    }
-	    else if ($result instanceof Splunk_ResultsMessage)
+	      if ( count($result->getFieldNames()) > 1 ) {
+	      	return FALSE;
+	      }
+	    } else if ($result instanceof Splunk_ResultsMessage)
 	    {
 	      // I don't want messages in my search
 	      return FALSE;
-	    }
-	    else if (is_array($result))
+	    } else if (is_array($result))
 	    {
 	      // Process a row
 	      foreach ($result as $key => $valueOrValues)
@@ -209,15 +233,13 @@ 
 	         if (is_array($valueOrValues))
 	          {
 	            return FALSE;
-	          }
-	         else
+	          } else
 	          {
 	            return $valueOrValues;
 	            #print "  {$key} => {$value}\r\n";
 	          }
 	        }
-	    }
-	    else
+	    } else
 	    {
 	      #print "Unknow result type";
 	      return FALSE;
@@ -231,7 +253,9 @@ 
 	$fileb= dirname(__FILE__) . '/' . $cf['badreportFile']["$type"];
 	$m_mail = imap_open('{'.$cf['mailhost'].':143/imap/novalidate-cert/authuser='.$cf['authuser'].'}'.$cf['folder']["$type"], $cf['account'],$cf['authpassword'], OP_READONLY)
         	or syslog (LOG_EMERG, $cf['user'].': Error in IMAP connection to <'.$cf['mailhost'].'>: ' . imap_last_error());
-	if ( !$m_mail ) exit(254);
+	if ( !$m_mail ) {
+		exit(254);
+	}
 		
 
 	syslog (LOG_INFO,$cf['user'].': Successfully connected to <'.$cf['mailhost'].">; Reading $type messages of last ".$cf['oldestday'].' days...');
@@ -244,20 +268,28 @@ 
 	// Order results starting from newest message
 	if (!$m_search) {
 		syslog (LOG_INFO,$cf['user'].": No mail found in $type folder. No reports written for $type.");
-	        if ( $ierr = imap_errors() )
-	                foreach ( $ierr as $thiserr )
+	        if ( $ierr = imap_errors() ) {
+	        	                foreach ( $ierr as $thiserr )
 	                        syslog (LOG_ERR, $cf['user'].": IMAP Error: $thiserr");
-	        if ( $ierr = imap_alerts() )
-	                foreach ( $ierr as $thiserr )
+	        }
+	        if ( $ierr = imap_alerts() ) {
+	        	                foreach ( $ierr as $thiserr )
 	                        syslog (LOG_ALERT, $cf['user'].": IMAP Alert: $thiserr");
+	        }
 		imap_close( $m_mail );
-		if ( file_exists( $file ) ) unlink ($file);
-		if ( file_exists( $fileb ) ) unlink ($fileb);
+		if ( file_exists( $file ) ) {
+			unlink ($file);
+		}
+		if ( file_exists( $fileb ) ) {
+			unlink ($fileb);
+		}
 		return FALSE;
 	}
 	$nmes = count ($m_search);
 	syslog (LOG_INFO,$cf['user'].": Found $nmes mail in $type folder.");
-	if ($nmes>0) rsort($m_search);
+	if ($nmes>0) {
+		rsort($m_search);
+	}
 
 	// Create report file
 
@@ -266,7 +298,9 @@ 
 	$lastup = "Last Update: " . date ("d F Y H:i", time());
 	fwrite( $fp, file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateHeader']) );
 	fwrite( $fp,"<h1> Report of IP sending $type</h1><h5>$lastup</h5><h2>Detailed Report</h2>" );
-	if ($cf['onlyReport']) fwrite( $fp,'<p>None of the below IP has been listed because listing is not active in configuration.</p>');
+	if ($cf['onlyReport']) {
+		fwrite( $fp,'<p>None of the below IP has been listed because listing is not active in configuration.</p>');
+	}
 	fwrite( $fp,'<table><tr><th title="taken from Received header" nowrap>Date of Learn</th><th title="taken from Date header" nowrap>Date of Write</th><th nowrap>UID</th><th nowrap>IP</th><th title="How many times this uid learns">#UID</th><th title="Number of times this learned IP appears in different mails">#IP</th><th nowrap>Received by</th><th>Message-Id</th></tr>' );
 	fwrite( $fpb,file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateHeader']) );
 	fwrite( $fpb,"<h1> Report of bad reported $type mails</h1><h5>$lastup</h5><h2>Detailed Report</h2>" );
@@ -310,10 +344,11 @@ 
 
 	                if (in_array($uid,array_keys($ipuid['uid']))) {
 				$ipuid['uid']["$uid"]['count']++;		//number of learn by this uid
-				if (!in_array($ip,$ipuid['uid']["$uid"])) 
-					$ipuid['uid']["$uid"][]=$ip;		//ips learned by this uid
-			}
-			else {
+				if (!in_array($ip,$ipuid['uid']["$uid"])) {
+									$ipuid['uid']["$uid"][]=$ip;
+				}
+				//ips learned by this uid
+			} else {
 				$ipuid['uid']["$uid"]['count'] = 1;
 				$ipuid['uid']["$uid"][]=$ip;
 				$ipuid['uid']['count']++;                	//number of unique uids
@@ -321,10 +356,11 @@ 
 
                         if (in_array($ip,array_keys($ipuid['ip']))) {
                                 $ipuid['ip']["$ip"]['count']++;			//number of time this ip appears in different messages
-				if (!in_array($uid,$ipuid['ip']["$ip"]))
-					$ipuid['ip']["$ip"][]=$uid;		//uids that learned this ip
-			}
-                        else {
+				if (!in_array($uid,$ipuid['ip']["$ip"])) {
+									$ipuid['ip']["$ip"][]=$uid;
+				}
+				//uids that learned this ip
+			} else {
                                 $ipuid['ip']["$ip"]['count'] = 1;
 				$ipuid['ip']["$ip"][]=$uid;
 				$ipuid['ip']['count']++;			//number of unique ips
@@ -332,21 +368,30 @@ 
 
 	        	/* Update HTML report */
 	        	fwrite($fp,updateReport ( $ip,$uid,$ipuid['ip']["$ip"]['count'],$ipuid['uid']["$uid"]['count'],$host,$dateClient,$mid,$dateReceived) );
-		}
-	        else {	/* Bad learn */
+		} else {	/* Bad learn */
 			
-                        if (in_array($uid,array_keys($uidbad['uid']))) 
-                                $uidbad['uid']["$uid"]['count']++;               //number of bad learn by this uid
+                        if (in_array($uid,array_keys($uidbad['uid']))) {
+                                                        $uidbad['uid']["$uid"]['count']++;
+                        }
+                        //number of bad learn by this uid
                         else {
                                 $uidbad['uid']["$uid"]['count'] = 1;
 				$uidbad['uid']["$uid"][]=$uid;
                                 $uidbad['count']++;                       //numeber of unique bad uids
                         }
 			/* The reason of bad report */
-			if (!$host) $reason = 'This mail was not received by recognized MX host';
-			if (!$dateReceived) $reason = 'This mail was not submitted to recognized MSA for learn';
-			if ($uid=='unknown') $reason = 'The uid of this mail was not found in splunk log';
-			if (!isset($reason)) $reason = '?';
+			if (!$host) {
+				$reason = 'This mail was not received by recognized MX host';
+			}
+			if (!$dateReceived) {
+				$reason = 'This mail was not submitted to recognized MSA for learn';
+			}
+			if ($uid=='unknown') {
+				$reason = 'The uid of this mail was not found in splunk log';
+			}
+			if (!isset($reason)) {
+				$reason = '?';
+			}
 				
 			fwrite( $fpb,updatebadReport ( $uid,$dateClient,$mid,$dateReceived,$reason ) );
 		}
@@ -364,9 +409,9 @@ 
 	fwrite($fp, '<hr><h2>Summary Report</h2><h5>Listing policy: ip must be learned at least '.$cf['thresholdip']["$type"].' times from at least '.$cf['thresholduid']["$type"].' different valid uids.</h5>' );
 
         /* Make MYSQL connection */
-	if ( $cf['onlyReport'] )
-		$mysqli = NULL;
-	else {
+	if ( $cf['onlyReport'] ) {
+			$mysqli = NULL;
+	} else {
         	$mysqli = new mysqli($myconnArray['dbhost'], $myconnArray['userdb'], $myconnArray['pwd'], $myconnArray['db'], $myconnArray['dbport']);
         	if ($mysqli->connect_error) {
                 	syslog (LOG_EMERG, $cf['user'].': Connect Error (' . $mysqli->connect_errno . ') '
@@ -378,8 +423,9 @@ 
 	/***********************/
 
 	fwrite($fp, summaryReportAndList ($cf,$mysqli,$tables,$type,$ipuid) );
-	if ( !$cf['onlyReport'] )
-		$mysqli->close();
+	if ( !$cf['onlyReport'] ) {
+			$mysqli->close();
+	}
 	fwrite($fp,file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateFooter']));
 	fclose($fp);
 
@@ -389,12 +435,14 @@ 
 	fclose($fpb);
 	syslog (LOG_INFO,$cf['user'].': Report files written. Listing job for '.$type.' terminated.');
 
-	if ( $ierr = imap_errors() )
-		foreach ( $ierr as $thiserr )
+	if ( $ierr = imap_errors() ) {
+			foreach ( $ierr as $thiserr )
 			syslog (LOG_ERR, $cf['user'].": IMAP Error: $thiserr");
-	if ( $ierr = imap_alerts() )
-                foreach ( $ierr as $thiserr )
+	}
+	if ( $ierr = imap_alerts() ) {
+	                foreach ( $ierr as $thiserr )
                         syslog (LOG_ALERT, $cf['user'].": IMAP Alert: $thiserr");
+	}
 	imap_close($m_mail);
 }
 ?>

contrib/ipImap/report/calendar/calendar_functions.php

Doc Comments +3 added lines

@@ -1,4 +1,7 @@
 <?php

+/**
+ * @param string $str
+ */
 function filterInput($str, $type = "text"){

 	switch(strtolower($type)){

 		case "number":

Braces +14 added lines, -8 removed lines

@@ -2,14 +2,18 @@ 
 function filterInput($str, $type = "text"){

 	switch(strtolower($type)){

 		case "number":

-			if(is_numeric($str))

-				return array(true, $str);

-			else return array(false, "Invalid input - '$str', required number");

+			if(is_numeric($str)) {
+							return array(true, $str);
+			} else {
+				return array(false, "Invalid input - '$str', required number");
+			}
 			break;

 		case "boolean":

-			if($str == "" || $str == 0 || $str == 1 || is_bool($str))

-				return array(true, $str);

-			else return array(false, "Invalid input - '$str', required boolean");

+			if($str == "" || $str == 0 || $str == 1 || is_bool($str)) {
+							return array(true, $str);
+			} else {
+				return array(false, "Invalid input - '$str', required boolean");
+			}
 			break;

 		default:

 			//$str = addslashes($str);

@@ -26,8 +30,10 @@ 
 	$result_txt = isset($results[1]) ? $results[1] : "";

 	if(isset($results[0]) && $results[0] === true){

 		return $result_txt;

-	}else exit("Error returned '$name' - ".$result_txt);

-}

+	} else {
+		exit("Error returned '$name' - ".$result_txt);
+	}
+	}

 

 function getTranslatedTxt($txt, $allow_tag = false, $maps = array()){

 	$content = $txt;

contrib/ipImap/report/calendar/classes/tc_calendar.php

Doc Comments +20 added lines

@@ -122,6 +122,11 @@ 
     }

 

 	//get the total day of each month in year

+
+    /**
+     * @param integer $month
+     * @param integer $year
+     */
     function total_days($month,$year){

     	$days = array(31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31);

 		if($month > 0 && $year > 0){

@@ -170,6 +175,12 @@ 
 	}

 

 	//set default selected date

+
+	/**
+	 * @param integer $day
+	 * @param integer $month
+	 * @param integer $year
+	 */
 	function setDate($day, $month, $year){

 		//get system timezone before set the date

 		$this->system_timezone = date_default_timezone_get();

@@ -516,6 +527,9 @@ 
 		return $str;

 	}

 

+	/**
+	 * @param string $suffix
+	 */
 	function eHidden($suffix, $value) {

 		if(trim($value) != ""){

 			if($suffix) $suffix = "_".$suffix;

@@ -849,6 +863,9 @@ 
 		return true;

 	}

 

+	/**
+	 * @return string
+	 */
 	function check_json_encode($obj){

 		//try customize to get it work, should replace with better solution in the future

 		if(is_array($obj)){

@@ -997,6 +1014,9 @@ 
 		}

 	}

 

+	/**
+	 * @param string $tz
+	 */
 	function setTimezone($tz){

 		$this->timezone = $tz;

 		@date_default_timezone_set($tz);

Braces +212 added lines, -98 removed lines

@@ -103,7 +103,9 @@ 
 		//$this->year_display_from_current = 50;

 		$this->date_picker = $date_picker;

 

-		if($timezone != "") $this->setTimezone($timezone);

+		if($timezone != "") {
+			$this->setTimezone($timezone);
+		}
 

 		//set default year display from current year

 		$thisyear = date('Y');

@@ -126,7 +128,9 @@ 
     	$days = array(31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31);

 		if($month > 0 && $year > 0){

 	    	return ($month == 2 && $this->is_leapYear($year)) ? 29 : $days[$month-1];

-		}else return 31;

+		} else {
+			return 31;
+		}
     }

 

 	//Deprecate since v1.6

@@ -143,7 +147,9 @@ 
 		$startdate = $this->startDate;

 

 		for($i=0; $i<=6; $i++){

-			if($startdate >= sizeof($hdrs)) $startdate = 0;

+			if($startdate >= sizeof($hdrs)) {
+				$startdate = 0;
+			}
 			//if(isset($hdrs[(string)$startdate]))

 				$rtn_hdrs[] = $hdrs[(string)$startdate];

 

@@ -195,7 +201,9 @@ 
 	//specified location of the calendar_form.php

 	function setPath($path){

 		$last_char = substr($path, strlen($path)-1, strlen($path));

-		if($last_char != "/") $path .= "/";

+		if($last_char != "/") {
+			$path .= "/";
+		}
 		$this->path = $path;

 	}

 

@@ -233,9 +241,9 @@ 
 

 					if($tz_sys_ms>=0 && $tz_new_ms<=0){

 						$timezone_diff = 0-($tz_sys_ms+abs($tz_new_ms));

-					}elseif($tz_sys_ms<=0 && $tz_new_ms>=0){

+					} elseif($tz_sys_ms<=0 && $tz_new_ms>=0){

 						$timezone_diff = abs($tz_sys_ms)+$tz_new_ms;

-					}else{

+					} else{

 						$timezone_diff = $tz_sys_ms-$tz_new_ms;

 					}

 					$timezone_diff_hr = $timezone_diff/3600;

@@ -255,7 +263,7 @@ 
 					$this->year = date("Y", $n_time);

 					$this->month = date("m", $n_time);

 					$this->day = date("d", $n_time);

-				}else{

+				} else{

 					$date = new DateTime($a_date, new DateTimeZone($this->system_timezone));

 					$date->setTimezone(new DateTimeZone($this->timezone));

 					$this->year = $date->format('Y');

@@ -276,7 +284,7 @@ 
 				$str .= $this->writeDay();

 				$str .= $this->writeMonth();

 				$str .= $this->writeYear();

-			}else{

+			} else{

 				$str .= " <a href=\"javascript:toggleCalendar('".$this->objname."', ".$this->auto_hide.", ".$this->auto_hide_time.");\" class=\"tclabel\">";

 				$str .= $this->writeDateContainer();

 				$str .= "</a>";

@@ -285,19 +293,21 @@ 
 			$str .= " <a href=\"javascript:toggleCalendar('".$this->objname."', ".$this->auto_hide.", ".$this->auto_hide_time.");\">";

 			if(is_file($this->icon)){

 				$str .= "<img src=\"".$this->icon."\" id=\"tcbtn_".$this->objname."\" name=\"tcbtn_".$this->objname."\" border=\"0\" align=\"absmiddle\" style=\"vertical-align:middle;\" alt=\"".$this->txt."\" title=\"".$this->txt."\" />";

-			}else $str .= $this->txt;

+			} else {
+				$str .= $this->txt;
+			}
 			$str .= "</a>";

 

 			$str .= $this->writeCalendarContainer();

 

 			$str .= "</div>";

-		}else{

+		} else{

 			$str .= $this->writeCalendarContainer();

 		}

 

 		if($buffer){

 			return $str;

-		}else{

+		} else{

 			echo($str);

 		}

 	}

@@ -307,97 +317,157 @@ 
 		$params[] = "objname=".$this->objname;

 

 		$param = $this->day;

-		if($param != "") $params[] = "selected_day=".$param;

+		if($param != "") {
+			$params[] = "selected_day=".$param;
+		}
 

 		$param = $this->month;

-		if($param != "") $params[] = "selected_month=".$param;

+		if($param != "") {
+			$params[] = "selected_month=".$param;
+		}
 

 		$param = $this->year;

-		if($param != "") $params[] = "selected_year=".$param;

+		if($param != "") {
+			$params[] = "selected_year=".$param;
+		}
 

 		$param = $this->year_start_input;

-		if($param != "") $params[] = "year_start=".$param;

+		if($param != "") {
+			$params[] = "year_start=".$param;
+		}
 

 		$param = $this->year_end_input;

-		if($param != "") $params[] = "year_end=".$param;

+		if($param != "") {
+			$params[] = "year_end=".$param;
+		}
 

 		$param = ($this->date_picker) ? 1 : 0;

-		if($param != "") $params[] = "dp=".$param;

+		if($param != "") {
+			$params[] = "dp=".$param;
+		}
 

 		$param = $this->time_allow1;

-		if($param != "") $params[] = "da1=".$param;

+		if($param != "") {
+			$params[] = "da1=".$param;
+		}
 

 		$param = $this->time_allow2;

-		if($param != "") $params[] = "da2=".$param;

+		if($param != "") {
+			$params[] = "da2=".$param;
+		}
 

 		$param = $this->show_not_allow;

-		if($param != "") $params[] = "sna=".$param;

+		if($param != "") {
+			$params[] = "sna=".$param;
+		}
 

 		$param = $this->auto_submit;

-		if($param != "") $params[] = "aut=".$param;

+		if($param != "") {
+			$params[] = "aut=".$param;
+		}
 

 		$param = $this->form_container;

-		if($param != "") $params[] = "frm=".$param;

+		if($param != "") {
+			$params[] = "frm=".$param;
+		}
 

 		$param = $this->target_url;

-		if($param != "") $params[] = "tar=".$param;

+		if($param != "") {
+			$params[] = "tar=".$param;
+		}
 

 		$param = $this->show_input;

-		if($param != "") $params[] = "inp=".$param;

+		if($param != "") {
+			$params[] = "inp=".$param;
+		}
 

 		$param = $this->date_format;

-		if($param != "") $params[] = "fmt=".$param;

+		if($param != "") {
+			$params[] = "fmt=".$param;
+		}
 

 		$param = implode(",", $this->dsb_days);

-		if($param != "") $params[] = "dis=".$param;

+		if($param != "") {
+			$params[] = "dis=".$param;
+		}
 

 		$param = $this->date_pair1;

-		if($param != "") $params[] = "pr1=".$param;

+		if($param != "") {
+			$params[] = "pr1=".$param;
+		}
 

 		$param = $this->date_pair2;

-		if($param != "") $params[] = "pr2=".$param;

+		if($param != "") {
+			$params[] = "pr2=".$param;
+		}
 

 		$param = $this->date_pair_value;

-		if($param != "") $params[] = "prv=".$param;

+		if($param != "") {
+			$params[] = "prv=".$param;
+		}
 

 		$param = $this->path;

-		if($param != "") $params[] = "pth=".$param;

+		if($param != "") {
+			$params[] = "pth=".$param;
+		}
 

 		$param = htmlspecialchars($this->check_json_encode($this->sp_dates), ENT_QUOTES);

-		if($param != "") $params[] = "spd=".$param;

+		if($param != "") {
+			$params[] = "spd=".$param;
+		}
 

 		$param = $this->sp_type;

-		if($param != "") $params[] = "spt=".$param;

+		if($param != "") {
+			$params[] = "spt=".$param;
+		}
 

 		$param = rawurlencode($this->tc_onchanged);

-		if($param != "") $params[] = "och=".$param;

+		if($param != "") {
+			$params[] = "och=".$param;
+		}
 

 		$param = $this->startDate;

-		if($param != "") $params[] = "str=".$param;

+		if($param != "") {
+			$params[] = "str=".$param;
+		}
 

 		$param = $this->rtl;

-		if($param != "") $params[] = "rtl=".$param;

+		if($param != "") {
+			$params[] = "rtl=".$param;
+		}
 

 		$param = $this->show_week;

-		if($param != "") $params[] = "wks=".$param;

+		if($param != "") {
+			$params[] = "wks=".$param;
+		}
 

 		$param = $this->interval;

-		if($param != "") $params[] = "int=".$param;

+		if($param != "") {
+			$params[] = "int=".$param;
+		}
 

 		$param = $this->auto_hide;

-		if($param != "") $params[] = "hid=".$param;

+		if($param != "") {
+			$params[] = "hid=".$param;
+		}
 

 		$param = $this->auto_hide_time;

-		if($param != "") $params[] = "hdt=".$param;

+		if($param != "") {
+			$params[] = "hdt=".$param;
+		}
 

 		$param = $this->timezone;

-		if($param != "") $params[] = "tmz=".$param;

+		if($param != "") {
+			$params[] = "tmz=".$param;
+		}
 

 		//$param = $this->system_timezone;

 		//if($param != "") $params[] = "stz=".$param;

 

 		$param = $this->theme;

-		if($param != "") $params[] = "thm=".$param;

+		if($param != "") {
+			$params[] = "thm=".$param;
+		}
 

 		$paramStr = (sizeof($params)>0) ? "?".implode("&", $params) : "";

 

@@ -432,7 +502,7 @@ 
 				default:

 					$div_align .= "right:0px;";

 			}

-		}else{

+		} else{

 			$div_display = "visible";

 			$div_position = "relative";

 			$div_align = "";

@@ -498,10 +568,10 @@ 
 			if($this->time_allow1 && $this->time_allow2){

 				$year_start = $this->mydate->getDate("Y", $this->time_allow1);

 				$year_end = $this->mydate->getDate("Y", $this->time_allow2);

-			}elseif($this->time_allow1){

+			} elseif($this->time_allow1){

 				//only date 1 specified

 				$year_start = $this->mydate->getDate("Y", $this->time_allow1);

-			}elseif($this->time_allow2){

+			} elseif($this->time_allow2){

 				//only date 2 specified

 				$year_end = $this->mydate->getDate("Y", $this->time_allow2);

 			}

@@ -518,7 +588,9 @@ 
 

 	function eHidden($suffix, $value) {

 		if(trim($value) != ""){

-			if($suffix) $suffix = "_".$suffix;

+			if($suffix) {
+				$suffix = "_".$suffix;
+			}
 			return "<input type=\"hidden\" name=\"".$this->objname.$suffix."\" id=\"".$this->objname.$suffix."\" value=\"".$value."\" />";

 		}

 	}

@@ -575,7 +647,9 @@ 
 	// Auto sizing is applied

 	//---------------------------

 	function setWidth($width){

-		if($width) $this->width = $width;

+		if($width) {
+			$this->width = $width;
+		}
 	}

 

 	//set height of calendar

@@ -584,20 +658,26 @@ 
 	// Auto sizing is applied

 	//---------------------------

 	function setHeight($height){

-		if($height) $this->height = $height;

+		if($height) {
+			$this->height = $height;
+		}
 	}

 

 	function setYearInterval($start, $end){

 		$this->year_start_input = $start;

 		$this->year_end_input = $end;

 

-		if(!$start) $start = $this->year_start;

-		if(!$end) $end = $this->year_end;

+		if(!$start) {
+			$start = $this->year_start;
+		}
+		if(!$end) {
+			$end = $this->year_end;
+		}
 

 		if($start < $end){

 			$this->year_start = $start;

 			$this->year_end = $end;

-		}else{

+		} else{

 			$this->year_start = $end;

 			$this->year_end = $start;

 		}

@@ -615,12 +695,15 @@ 
 		//$this->startMonday = $flag;

 

 		//change it so that it will not cause an error after version 3.61

-		if($flag) $this->startDate = 1;

+		if($flag) {
+			$this->startDate = 1;
+		}
 	}

 

 	function startDate($num){

-		if(is_numeric($num) && $num >= 0 && $num <= 6)

-			$this->startDate = $num;

+		if(is_numeric($num) && $num >= 0 && $num <= 6) {
+					$this->startDate = $num;
+		}
 	}

 

 	function dateAllow($from = "", $to = "", $show_not_allow = true){

@@ -637,19 +720,27 @@ 
 		if ($time_from != null) {

 			$this->time_allow1 = $time_from;

 			$y = $this->mydate->getDate('Y', $time_from);

-			if($this->year_start && $y > $this->year_start) $this->year_start = $y;

+			if($this->year_start && $y > $this->year_start) {
+				$this->year_start = $y;
+			}
 

 			//setup year end from year start

-			if($time_to == null && !$this->year_end) $this->year_end = $this->year_start + $this->year_display_from_current;

+			if($time_to == null && !$this->year_end) {
+				$this->year_end = $this->year_start + $this->year_display_from_current;
+			}
 		}

 

 		if ($time_to>0) {

 			$this->time_allow2 = $time_to;

 			$y = $this->mydate->getDate('Y', $time_to);

-			if($this->year_end && $y < $this->year_end) $this->year_end = $y;

+			if($this->year_end && $y < $this->year_end) {
+				$this->year_end = $y;
+			}
 

 			//setup year start from year end

-			if($time_from == null && !$this->year_start) $this->year_start = $this->year_end - $this->year_display_from_current;

+			if($time_from == null && !$this->year_start) {
+				$this->year_start = $this->year_end - $this->year_display_from_current;
+			}
 		}

 

 		$this->show_not_allow = $show_not_allow;

@@ -672,7 +763,9 @@ 
 	function writeDateContainer(){

 		if($this->day && $this->month && $this->year){

 			$dd = $this->mydate->getDate($this->date_format, $this->year."-".$this->month."-".$this->day);

-		}else $dd = "Select Date";

+		} else {
+			$dd = "Select Date";
+		}
 

 		return "<div id=\"divCalendar_".$this->objname."_lbl\" class=\"date-tccontainer\">$dd</div>";

 	}

@@ -683,8 +776,9 @@ 
 	//------------------------------------------------------

 	function disabledDay($day){

 		$day = strtolower($day); //make it not case-sensitive

-		if(in_array($day, $this->dsb_days) === false)

-			$this->dsb_days[] = $day;

+		if(in_array($day, $this->dsb_days) === false) {
+					$this->dsb_days[] = $day;
+		}
 	}

 

 	function setAlignment($h_align, $v_align){

@@ -695,12 +789,14 @@ 
 	function setDatePair($calendar_name1, $calendar_name2, $pair_value = "0000-00-00 00:00:00"){

 		if($calendar_name1 != $this->objname){

 			$this->date_pair1 = $calendar_name1;

-			if($pair_value != "0000-00-00 00:00:00")

-				$this->date_pair_value = $pair_value;

-		}elseif($calendar_name2 != $this->objname){

+			if($pair_value != "0000-00-00 00:00:00") {
+							$this->date_pair_value = $pair_value;
+			}
+		} elseif($calendar_name2 != $this->objname){

 			$this->date_pair2 = $calendar_name2;

-			if($pair_value != "0000-00-00 00:00:00")

-				$this->date_pair_value = $pair_value;

+			if($pair_value != "0000-00-00 00:00:00") {
+							$this->date_pair_value = $pair_value;
+			}
 		}

 	}

 

@@ -713,16 +809,19 @@ 
 				if($this->mydate->validDate($sp_date)){

 					switch($recursive){

 						case "month": //add to monthly

-							if(!in_array($sp_date, $this->sp_dates[1]))

-								$this->sp_dates[1][] = $sp_date;

+							if(!in_array($sp_date, $this->sp_dates[1])) {
+															$this->sp_dates[1][] = $sp_date;
+							}
 							break;

 						case "year": //add to yearly

-							if(!in_array($sp_date, $this->sp_dates[2]))

-								$this->sp_dates[2][] = $sp_date;

+							if(!in_array($sp_date, $this->sp_dates[2])) {
+															$this->sp_dates[2][] = $sp_date;
+							}
 							break;

 						default: //add to no recursive

-							if(!in_array($sp_date, $this->sp_dates[0]))

-								$this->sp_dates[0][] = $sp_date;

+							if(!in_array($sp_date, $this->sp_dates[0])) {
+															$this->sp_dates[0][] = $sp_date;
+							}
 					}

 				}

 			}

@@ -790,10 +889,14 @@ 
 			if($this->mydate->dateBefore($this->time_allow1, $date_str, false) || $this->mydate->dateAfter($this->time_allow2, $date_str, false)){

 				return false;

 			}

-		}elseif($this->time_allow1){

-			if($this->mydate->dateBefore($this->time_allow1, $date_str, false)) return false;

-		}elseif($this->time_allow2){

-			if($this->mydate->dateAfter($this->time_allow2, $date_str, false)) return false;

+		} elseif($this->time_allow1){

+			if($this->mydate->dateBefore($this->time_allow1, $date_str, false)) {
+				return false;
+			}
+		} elseif($this->time_allow2){

+			if($this->mydate->dateAfter($this->time_allow2, $date_str, false)) {
+				return false;
+			}
 		}

 

 		//check with specific date

@@ -830,11 +933,15 @@ 
 				case 0:

 				default:

 					//disabled specific and enabled others

-					if($sp_found) return false;

+					if($sp_found) {
+						return false;
+					}
 					break;

 				case 1:

 					//enabled specific and disabled others

-					if(!$sp_found) return false;

+					if(!$sp_found) {
+						return false;
+					}
 					break;

 			}

 		}

@@ -854,17 +961,21 @@ 
 		if(is_array($obj)){

 			if(function_exists("json_encode") && false){

 				return json_encode($obj);

-			}else{

+			} else{

 				//only array is assumed for now

 				$return_arr = array();

 				foreach($obj as $arr){

-					if(is_array($arr) && sizeof($arr)>0)

-						$return_arr[] = "[\"".implode("\",\"", $arr)."\"]";

-					else $return_arr[] = "[]";

+					if(is_array($arr) && sizeof($arr)>0) {
+											$return_arr[] = "[\"".implode("\",\"", $arr)."\"]";
+					} else {
+						$return_arr[] = "[]";
+					}
 				}

 				return "[".implode(",", $return_arr)."]";

 			}

-		}else return "";

+		} else {
+			return "";
+		}
 	}

 

 	function &check_json_decode($str){

@@ -872,7 +983,7 @@ 
 

 		if(function_exists("json_decode") && false){

 			return json_decode($str);

-		}else{

+		} else{

 			//only array is assume for now

 			$str = stripslashes(rawurldecode($str));

 			$str = trim($str);

@@ -890,9 +1001,9 @@ 
 					$arr = explode("],[", $str);

 					for($i=0; $i<sizeof($arr); $i++){

 						$this_v = $arr[$i];

-						if($this_v == "")

-							$return_arr[] = array();

-						else{

+						if($this_v == "") {
+													$return_arr[] = array();
+						} else{

 							$this_arr = explode(",", $this_v);

 

 							for($j=0; $j<sizeof($this_arr); $j++){

@@ -905,8 +1016,12 @@ 
 						}

 					}

 					return $return_arr;

-				}else return array();

-			}else return array();

+				} else {
+					return array();
+				}
+			} else {
+				return array();
+			}
 		}

 	}

 

@@ -939,14 +1054,16 @@ 
 		//check if today is in range of date allow

 		if($this->time_allow1 != ""){

 			//check valid if today is after date_allow1

-			if($this->mydate->validDate($this->time_allow1) && !$this->mydate->dateAfter($this->time_allow1, $today))

-				return false;

+			if($this->mydate->validDate($this->time_allow1) && !$this->mydate->dateAfter($this->time_allow1, $today)) {
+							return false;
+			}
 		}

 

 		if($this->time_allow2 > 0){

 			//check valid if today is before date_allow2

-			if($this->mydate->validDate($this->time_allow2) && !$this->mydate->dateBefore($this->time_allow2, $today))

-				return false;

+			if($this->mydate->validDate($this->time_allow2) && !$this->mydate->dateBefore($this->time_allow2, $today)) {
+							return false;
+			}
 		}

 		return true;

 	}

@@ -966,8 +1083,7 @@ 
 						if(!in_array($tt_time, $this->tt_dates[2])){

 							$this->tt_dates[2][] = $tt_time;

 							$this->tt_tooltips[2][] = $tooltip;

-						}

-						else{

+						} else{

 							$tt_key = array_search($tt_time, $this->tt_dates[2]);

 							$this->tt_tooltips[2][$tt_key] = $this->tt_tooltips[2][$tt_key]."\n".$tooltip;

 						}

@@ -976,8 +1092,7 @@ 
 						if(!in_array($tt_time, $this->tt_dates[1])){

 							$this->tt_dates[1][] = $tt_time;

 							$this->tt_tooltips[1][] = $tooltip;

-						}

-						else{

+						} else{

 							$tt_key = array_search($tt_time, $this->tt_dates[1]);

 							$this->tt_tooltips[1][$tt_key] = $this->tt_tooltips[1][$tt_key]."\n".$tooltip;

 						}

@@ -986,8 +1101,7 @@ 
 						if(!in_array($tt_time, $this->tt_dates[0])){

 							$this->tt_dates[0][] = $tt_time;

 							$this->tt_tooltips[0][] = $tooltip;

-						}

-						else{

+						} else{

 							$tt_key = array_search($tt_time, $this->tt_dates[0]);

 							$this->tt_tooltips[0][$tt_key] = $this->tt_tooltips[0][$tt_key]."\n".$tooltip;

 						}

contrib/ipImap/report/calendar/classes/tc_date.php

Doc Comments +14 added lines

@@ -54,6 +54,9 @@ 
 		}

 	}

 

+	/**
+	 * @return string
+	 */
 	function getDate($format = "Y-m-d", $cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::getDate($format, $cdate);

@@ -123,6 +126,9 @@ 
 		}

 	}

 

+	/**
+	 * @param string $timespan
+	 */
 	function addDate($format = "Y-m-d", $timespan, $cdate = ""){

 		if($this->compatible){

 			$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

@@ -148,6 +154,10 @@ 
 

 	//check if date1 is before date2

 	//if date1 omitted use set date

+
+	/**
+	 * @param string|boolean $date2
+	 */
 	function dateBefore($date2, $date1 = "", $equal = true){

 		if(!$this->compatible){

 			return tc_date_main::dateBefore($date2, $date1, $equal);

@@ -162,6 +172,10 @@ 
 

 	//check if date1 is after date2

 	//if date1 omitted use set date

+
+	/**
+	 * @param string|boolean $date2
+	 */
 	function dateAfter($date2, $date1 = "", $equal = true){

 		if(!$this->compatible){

 			return tc_date_main::dateAfter($date2, $date1, $equal);

Braces +38 added lines, -23 removed lines

@@ -14,11 +14,13 @@ 
 		//check if we should use DateTime that comes with 5.3.0 and later

 		if (version_compare(PHP_VERSION, '5.3.0') <= 0) {

 			$this->compatible = false;

-		}else $this->compatible = true;

+		} else {
+			$this->compatible = true;
+		}
 

 		if(!$this->compatible){

 			$this->tc_date_main();

-		}else{

+		} else{

 			$this->mydate = new DateTime('now');

 		}

 	}

@@ -26,49 +28,56 @@ 
 	function getDayOfWeek($cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::getDayOfWeek($cdate);

-		}else{

+		} else{

 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){

 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

 				return $tmp_date->format('w');

-			}else return "";

+			} else {
+				return "";
+			}
 		}

 	}

 

 	function getWeekNumber($cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::getWeekNumber($cdate);

-		}else{

+		} else{

 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){

 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

 				return $tmp_date->format('W');

-			}else return "";

+			} else {
+				return "";
+			}
 		}

 	}

 

 	function setDate($sdate){

 		if(!$this->compatible){

 			tc_date_main::setDate($sdate);

-		}else{

-			if(tc_date_main::validDate($sdate))

-				$this->mydate = new DateTime($sdate);

+		} else{

+			if(tc_date_main::validDate($sdate)) {
+							$this->mydate = new DateTime($sdate);
+			}
 		}

 	}

 

 	function getDate($format = "Y-m-d", $cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::getDate($format, $cdate);

-		}else{

+		} else{

 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){

 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

 				return $tmp_date->format($format);

-			}else return "";

+			} else {
+				return "";
+			}
 		}

 	}

 

 	function setTimestamp($stime){

 		if(!$this->compatible){

 			tc_date_main::setTimestamp($stime);

-		}else{

+		} else{

 			$this->mydate->setTimestamp($stime);

 		}

 	}

@@ -76,11 +85,13 @@ 
 	function getTimestamp($cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::getTimestamp($cdate);

-		}else{

+		} else{

 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){

 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

 				return $tmp_date->getTimestamp();

-			}else return 0;

+			} else {
+				return 0;
+			}
 		}

 	}

 

@@ -88,18 +99,20 @@ 
 		if($stime){

 			if(!$this->compatible){

 				return tc_date_main::getDateFromTimestamp($stime, $format);

-			}else{

+			} else{

 				$tmp_date = new DateTime();

 				$tmp_date->setTimestamp($stime);

 				return $tmp_date->format($format);

 			}

-		}else return "";

+		} else {
+			return "";
+		}
 	}

 

 	function addDay($format = "Y-m-d", $timespan, $cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::addDay($format, $timespan, $cdate);

-		}else{

+		} else{

 			$timespan = "P".$timespan."D";

 			return $this->addDate($format, $timespan, $cdate);

 		}

@@ -108,7 +121,7 @@ 
 	function addMonth($format = "Y-m-d", $timespan, $cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::addMonth($format, $timespan, $cdate);

-		}else{

+		} else{

 			$timespan = "P".$timespan."M";

 			return $this->addDate($format, $timespan, $cdate);

 		}

@@ -117,7 +130,7 @@ 
 	function addYear($format = "Y-m-d", $timespan, $cdate = ""){

 		if(!$this->compatible){

 			return tc_date_main::addYear($format, $timespan, $cdate);

-		}else{

+		} else{

 			$timespan = "P".$timespan."Y";

 			return $this->addDate($format, $timespan, $cdate);

 		}

@@ -128,7 +141,9 @@ 
 			$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;

 			$tmp_date->add(new DateInterval($timespan));

 			return $tmp_date->format($format);

-		}else return "0000-00-00";

+		} else {
+			return "0000-00-00";
+		}
 	}

 

 	//return the number of day different between date1 and date2

@@ -136,7 +151,7 @@ 
 	function differentDate($date2, $date1 = ""){

 		if(!$this->compatible){

 			return tc_date_main::differentDate($date2, $date1);

-		}else{

+		} else{

 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');

 

 			$date1 = new DateTime($date1);

@@ -151,7 +166,7 @@ 
 	function dateBefore($date2, $date1 = "", $equal = true){

 		if(!$this->compatible){

 			return tc_date_main::dateBefore($date2, $date1, $equal);

-		}else{

+		} else{

 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');

 

 			$date1 = new DateTime($date1);

@@ -165,7 +180,7 @@ 
 	function dateAfter($date2, $date1 = "", $equal = true){

 		if(!$this->compatible){

 			return tc_date_main::dateAfter($date2, $date1, $equal);

-		}else{

+		} else{

 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');

 

 			$date1 = new DateTime($date1);

function.php

Doc Comments +8 added lines

@@ -204,6 +204,11 @@ 
 }
 
 
+/**
+ * @param integer $id
+ * @param string $what
+ * @param boolean $lock
+ */
 function ask($myconn,$id,$what,$alltables,$typedesc,$value,$lock,$user,$adm) {
 
 	switch ($what) {
@@ -404,6 +409,9 @@ 
 }
 
 
+/**
+ * @param string $reason
+ */
 function searchAndList ($myconn,$loguser,$tables,$typedesc,$value,$unit,&$quantity,$reason) {
 
 /* Search and list value */

Braces +84 added lines, -49 removed lines

@@ -3,9 +3,13 @@ 
 $version='1.9d';
 
 function username() {
-	if (isset ($_SERVER['REMOTE_USER'])) $user = $_SERVER['REMOTE_USER'];
-        	else if (isset ($_SERVER['USER'])) $user = $_SERVER['USER'];
-                	else $user='unknown';
+	if (isset ($_SERVER['REMOTE_USER'])) {
+		$user = $_SERVER['REMOTE_USER'];
+	} else if (isset ($_SERVER['USER'])) {
+        		$user = $_SERVER['USER'];
+        	} else {
+                		$user='unknown';
+                	}
 	return $user;
 }
 
@@ -67,8 +71,9 @@ 
 	if ($myconn->query($query) === TRUE) {
 	    syslog(LOG_INFO, "$user: $type <$value> successfully listed on <$table> for $expQ $expUnit.");
 	    $result=TRUE;
+	} else {
+		syslog(LOG_ERR, "$user: Error: ".$myconn->error);
 	}
-	else syslog(LOG_ERR, "$user: Error: ".$myconn->error);
 	return $result;
 }
 
@@ -109,8 +114,9 @@ 
         if ($myconn->query($query) === TRUE) {
             syslog(LOG_INFO, "$user: relist $type <$value> on <$table> for $expQ $expUnit.");
 		$result=TRUE;
+        } else {
+        	syslog (LOG_ERR, "$user: Error: ". $myconn->error);
         }
-        else syslog (LOG_ERR, "$user: Error: ". $myconn->error);
 	return $result;
 }
 
@@ -134,9 +140,11 @@ 
 	}
 
 
-        if ($return=$myconn->query($query) === TRUE) 
-            syslog(LOG_INFO, "$user: permanently DELETED $type <$value> from <$table>.");
-        else syslog(LOG_ERR, "$user: Error: ". $myconn->error);
+        if ($return=$myconn->query($query) === TRUE) {
+                    syslog(LOG_INFO, "$user: permanently DELETED $type <$value> from <$table>.");
+        } else {
+        	syslog(LOG_ERR, "$user: Error: ". $myconn->error);
+        }
 
         return $return;
 }
@@ -158,8 +166,9 @@ 
 
         if ($return=$myconn->query($query) === TRUE) {
             syslog(LOG_INFO, "$user: change status of $type <$value>. The status is now <$status>");
+        } else {
+        	syslog(LOG_ERR, "$user: Error: ". $myconn->error);
         }
-        else syslog(LOG_ERR, "$user: Error: ". $myconn->error);
 	return $return;	
 }
 
@@ -182,14 +191,16 @@ 
 				$j++;
 
 			} while ($myconn->next_result());
-		}
-		else {
+		} else {
 			syslog(LOG_ERR, "Expire job - Error: ". $myconn->error);
 			$return = FALSE;
 		}
 	}
-	if ( !($return) ) syslog(LOG_EMERG, 'End of Expire job with error. See above logs. SQL Connection terminated');
-	else  syslog(LOG_INFO, 'Successfully End of Expire job. SQL Connection successfully terminated.');
+	if ( !($return) ) {
+		syslog(LOG_EMERG, 'End of Expire job with error. See above logs. SQL Connection terminated');
+	} else {
+		syslog(LOG_INFO, 'Successfully End of Expire job. SQL Connection successfully terminated.');
+	}
         return $return;
 }
 
@@ -198,8 +209,11 @@ 
 
 	$exp=new DateTime($row['exp']);
 	$now=new DateTime('NOW');
-	if (($exp > $now) and ($row['active'])) return true;
-	else return false;
+	if (($exp > $now) and ($row['active'])) {
+		return true;
+	} else {
+		return false;
+	}
 
 }
 
@@ -208,9 +222,12 @@ 
 
 	switch ($what) {
 		case 'Ok':
-			if ($lock) return NULL;
-			if (in_array($user,array_keys($adm)))
-				if ( consistentListing($myconn,$alltables,$typedesc,$value,$whynot) ) return require('relistButton.php');
+			if ($lock) {
+				return NULL;
+			}
+			if (in_array($user,array_keys($adm))) {
+							if ( consistentListing($myconn,$alltables,$typedesc,$value,$whynot) ) return require('relistButton.php');
+			}
 			return htmlspecialchars($whynot);
 		case 'Listed':
 		case 'WhiteListed':
@@ -251,8 +268,9 @@ 
         $type = $tablelist['field'];
         $table = $tablelist['name'];
 
-        if ($value == 'ALL') $query = 'select * from '.$table;
-        else {
+        if ($value == 'ALL') {
+        	$query = 'select * from '.$table;
+        } else {
                 switch ($type) {
                   case 'ip':
                         $query= "select * from $table where $type =  INET_ATON('$value')";
@@ -267,8 +285,9 @@ 
         }
 
 	$result = $myconn->query($query);
-	if($result === false)
-		syslog(LOG_EMERG, "ALERT: Query <$query> failed: ".$myconn->error);
+	if($result === false) {
+			syslog(LOG_EMERG, "ALERT: Query <$query> failed: ".$myconn->error);
+	}
         return $result;
 }
 
@@ -286,8 +305,9 @@ 
 
 function isFull($myconn,$typedesc,$alltables) {
         if (isset($alltables["$typedesc"]['limit'])) {
-                if ( countListed($myconn,$alltables["$typedesc"]['name']) >= $alltables["$typedesc"]['limit'] ) 
-                        return TRUE;
+                if ( countListed($myconn,$alltables["$typedesc"]['name']) >= $alltables["$typedesc"]['limit'] ) {
+                                        return TRUE;
+                }
         }
 	return FALSE;
 }
@@ -303,18 +323,23 @@ 
 
         /* Check for limit in number of listed items */
 	$full = isFull($myconn,$typedesc,$tables);
-	if ($full) print '<p>'.htmlspecialchars("$typedesc has reached maximum value of ".$tables["$typedesc"]['limit'].' listed items.').'</p>';
+	if ($full) {
+		print '<p>'.htmlspecialchars("$typedesc has reached maximum value of ".$tables["$typedesc"]['limit'].' listed items.').'</p>';
+	}
 
 		if ($result->num_rows) {
 			print '<table><thead><tr><th>'.$type.'</th><th title="The date this object has been listed for the first time">DateAdd</th><th>DateMod</th><th>Exp</th><th>Status</th><th title="Number of times this object has been listed">#List</th><th>Authored by</th><th width="250">Reason</th><th>Action</th></tr></thead><tfoot><tr></tr></tfoot><tbody>'."\n";
 			$i=0;
         		while ($riga = $result->fetch_array(MYSQLI_ASSOC)) {
 				if (isListed($riga)) {
-					if ($tables["$typedesc"]['bl']) $listed='Listed';
-					else $listed='WhiteListed';
-				}	
-				else
-					$listed='Ok';
+					if ($tables["$typedesc"]['bl']) {
+						$listed='Listed';
+					} else {
+						$listed='WhiteListed';
+					}
+				} else {
+									$listed='Ok';
+				}
 
 				switch ($type) {
 				  case 'ip':
@@ -331,18 +356,20 @@ 
 				$i++;
         		}
 			print '</tbody></table>';
-		}
-		else {
+		} else {
 			print "<pre>$type &lt;$value&gt; is not listed!\n</pre>";
-			if ( in_array($user,array_keys($adm)) AND ($value != 'ALL') )
-				if ( (!$full) AND (consistentListing($myconn,$tables,$typedesc,$value,$whynot)) ) require_once('listForm.php');
-									else print '<p>'.htmlspecialchars($whynot).'</p>';
+			if ( in_array($user,array_keys($adm)) AND ($value != 'ALL') ) {
+							if ( (!$full) AND (consistentListing($myconn,$tables,$typedesc,$value,$whynot)) ) require_once('listForm.php');
+			} else {
+										print '<p>'.htmlspecialchars($whynot).'</p>';
+									}
 				
 		}
 		$result->free();
+	} else {
+		print '<pre>Query error or something wrong in DB schema'."\n</pre>";
+	}
 	}
-	else print '<pre>Query error or something wrong in DB schema'."\n</pre>";
-}
 
 
 function sendEmailWarn($tplf,$from,$to,$sbj,$emailListed,$intervalToExpire,$detail) {
@@ -384,24 +411,32 @@ 
                 $old_mailfrom = ini_get("sendmail_from");
                 ini_set("sendmail_from", $from);
                 $params = sprintf("-oi -f %s", '<>');
-                if (!(mail($to,$sbj, $body,$headers,$params))) $flag=FALSE;
-                else $flag=TRUE;
-                if (isset($old_mailfrom))
-                        ini_set("sendmail_from", $old_mailfrom);
-        }
-        else {
-                if (!(mail($to,$sbj, $body,$headers))) $flag=FALSE;
-                else $flag=TRUE;
+                if (!(mail($to,$sbj, $body,$headers,$params))) {
+                	$flag=FALSE;
+                } else {
+                	$flag=TRUE;
+                }
+                if (isset($old_mailfrom)) {
+                                        ini_set("sendmail_from", $old_mailfrom);
+                }
+        } else {
+                if (!(mail($to,$sbj, $body,$headers))) {
+                	$flag=FALSE;
+                } else {
+                	$flag=TRUE;
+                }
         }
         return $flag;
 }
 
 function emailToNotify($notify_file,$dom) {
 	$ini_array = parse_ini_file($notify_file);
-	if (in_array($dom,array_keys($ini_array)))
-		return $ini_array["$dom"];
-	else return FALSE;
-}
+	if (in_array($dom,array_keys($ini_array))) {
+			return $ini_array["$dom"];
+	} else {
+		return FALSE;
+	}
+	}
 
 
 function searchAndList ($myconn,$loguser,$tables,$typedesc,$value,$unit,&$quantity,$reason) {

result.php

Braces +25 added lines, -15 removed lines

@@ -5,31 +5,38 @@ 
 $net = new \dautkom\ipv4\IPv4();
 
 $_ = $_POST['genere'];
-if ( ($tables["$_"]['field']=='email') AND ($_POST['Value']!='ALL') )
+if ( ($tables["$_"]['field']=='email') AND ($_POST['Value']!='ALL') ) {
 	if (!(filter_var($_POST['Value'], FILTER_VALIDATE_EMAIL)))
 		exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid email address.</pre>');
+}
 
-if ( ($tables["$_"]['field']=='domain') AND ($_POST['Value']!='ALL') )
+if ( ($tables["$_"]['field']=='domain') AND ($_POST['Value']!='ALL') ) {
         if (!(filter_var(gethostbyname($_POST['Value']), FILTER_VALIDATE_IP)))
 		exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid domain.</pre>');
+}
 
-if ( ($tables["$_"]['field']=='ip')  AND ($_POST['Value']!='ALL') )
+if ( ($tables["$_"]['field']=='ip')  AND ($_POST['Value']!='ALL') ) {
 	if (!(filter_var($_POST['Value'], FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)))
 		exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid IP address.</pre>');
+}
 	
 if ( ($tables["$_"]['field']=='network') AND ($_POST['Value']!='ALL') ) {
 	$value = explode('/',$_POST['Value']);
-	if (count($value) != 2)
-		exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid Network/Netmask pair.</pre>');
-	if (!$net->address($value[0])->mask($value[1])->isValid(1))
-		exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid Network/Netmask.</pre>');
-}
+	if (count($value) != 2) {
+			exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid Network/Netmask pair.</pre>');
+	}
+	if (!$net->address($value[0])->mask($value[1])->isValid(1)) {
+			exit ('<pre>&lt;'.$_POST['Value'].'&gt; is NOT a valid Network/Netmask.</pre>');
+	}
+	}
 
 if ( ($tables["$_"]['field']=='username') AND ($_POST['Value']!='ALL') ) {
-        if ( preg_match( '/[^\x20-\x7f]/', $_POST['Value']) )
-                exit('<pre>&lt;'.$_POST['Value'].'&gt; contains NON ASCII chars.</pre>');
-	if ( preg_match( '/[$~=#*+%,{}()\/\\<>;:\"`\[\]&?\s]/', $_POST['Value']) )
-		exit('<pre>&lt;'.$_POST['Value'].'&gt; contains invalid ASCII chars.</pre>');
+        if ( preg_match( '/[^\x20-\x7f]/', $_POST['Value']) ) {
+                        exit('<pre>&lt;'.$_POST['Value'].'&gt; contains NON ASCII chars.</pre>');
+        }
+	if ( preg_match( '/[$~=#*+%,{}()\/\\<>;:\"`\[\]&?\s]/', $_POST['Value']) ) {
+			exit('<pre>&lt;'.$_POST['Value'].'&gt; contains invalid ASCII chars.</pre>');
+	}
 	switch ( $_POST['Value'] ) {
 		case 'anonymous':
 		case 'anybody':
@@ -40,9 +47,12 @@ 
 }	
 
 if (empty($_GET)) {
-	if ($tables["$_"]['bl']) print "<p><i>$_</i> is a blocklist of ".$tables["$_"]['field'].'.</p>';
-	else print "<p><i>$_</i> is a whitelist of ".$tables["$_"]['field'].'.</p>';
-}
+	if ($tables["$_"]['bl']) {
+		print "<p><i>$_</i> is a blocklist of ".$tables["$_"]['field'].'.</p>';
+	} else {
+		print "<p><i>$_</i> is a whitelist of ".$tables["$_"]['field'].'.</p>';
+	}
+	}
 
 openlog($tag, LOG_PID, $fac);
 $user = username();

index.php

Braces +5 added lines, -2 removed lines

@@ -14,11 +14,14 @@
 require_once('function.php');
 
 
-if ( $require_auth ) if ( username() == 'unknown' ) exit ("<p>You MUST configure your server to use authentication.</p>");
+if ( $require_auth ) {
+	if ( username() == 'unknown' ) exit ("<p>You MUST configure your server to use authentication.</p>");
+}
 
 
-if ( $imapListActive )
+if ( $imapListActive ) {
 	print ' <p style="text-align: right"><a href="/spamreport" target="_new">SPAM Learn Observer</a></p>';
+}
 
 print <<<END
 <form name="check" action="result.php" onSubmit="xmlhttpPost('result.php', 'check', 'Risultato', '<img src=\'/include/pleasewait.gif\'>'); return false;" enctype="text/plain" method="post" target="_self">

remove.php

Braces +3 added lines, -2 removed lines

@@ -16,10 +16,11 @@
 }
 syslog (LOG_INFO, $user.': Successfully connected to ' . $mysqli->host_info );
 
-if (remove ($_POST['value'],$type,$table))
+if (remove ($_POST['value'],$type,$table)) {
  print 'OK '.$typedesc.' <'.$_POST['value'].'> permanently REMOVED!';
-else
+} else {
  print 'Delete operation ERROR on '.$typedesc.' <'.$_POST['value'].'>; check log.';
+}
 $mysqli->close();
 closelog();
 ?>

list.php

Braces +8 added lines, -4 removed lines

@@ -6,9 +6,12 @@ 
 $table = $tables["$typedesc"]['name'];
 
 openlog($tag, LOG_PID, $fac);
-if (empty($_POST['reason'])) die ("<p>Please, specify a reason!</p>");
-if (preg_match( '/[^\x20-\x7f]/', $_POST['reason']))
+if (empty($_POST['reason'])) {
+	die ("<p>Please, specify a reason!</p>");
+}
+if (preg_match( '/[^\x20-\x7f]/', $_POST['reason'])) {
 	exit('<p>ERROR: &lt;'.htmlentities($_POST['reason'],ENT_COMPAT | ENT_HTML401, 'ISO-8859-1').'&gt; contains NON ASCII chars.</p>');
+}
 $user = username();
 
 $mysqli = new mysqli($dbhost, $userdb, $pwd, $db, $dbport);
@@ -20,10 +23,11 @@ 
         }
 syslog (LOG_INFO, $user.': Successfully connected to ' . $mysqli->host_info );
 
-if (addtolist ($mysqli,username(),$_POST['value'],$type,$table,$_POST['unit'],$_POST['quantity'],$_POST['reason']))
+if (addtolist ($mysqli,username(),$_POST['value'],$type,$table,$_POST['unit'],$_POST['quantity'],$_POST['reason'])) {
  print 'OK '.$_POST["type"].' &lt;'.$_POST['value'].'&gt; first time listed for '.$_POST['quantity'].$_POST['unit'].'.';
-else
+} else {
  print 'List operation ERROR; check log.';
+}
 $mysqli->close();
 closelog();
 ?>