GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Push — master ( 15df2d...62d3cd )
by Marco
02:11
created
contrib/rbldns/exportdns.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,8 +1,9 @@
 block discarded – undo
1 1
 #!/usr/bin/php
2 2
 <?php
3 3
 
4
-if (PHP_SAPI != "cli")
4
+if (PHP_SAPI != "cli") {
5 5
     exit;
6
+}
6 7
 
7 8
 $home = '/var/www/html/RBL';
8 9
 require_once($home.'/config.php');
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/classes/tc_calendar.php 1 patch
Braces   +212 added lines, -98 removed lines patch added patch discarded remove patch
@@ -103,7 +103,9 @@  discard block
 block discarded – undo
103 103
 		//$this->year_display_from_current = 50;
104 104
 		$this->date_picker = $date_picker;
105 105
 
106
-		if($timezone != "") $this->setTimezone($timezone);
106
+		if($timezone != "") {
107
+			$this->setTimezone($timezone);
108
+		}
107 109
 
108 110
 		//set default year display from current year
109 111
 		$thisyear = date('Y');
@@ -126,7 +128,9 @@  discard block
 block discarded – undo
126 128
     	$days = array(31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31);
127 129
 		if($month > 0 && $year > 0){
128 130
 	    	return ($month == 2 && $this->is_leapYear($year)) ? 29 : $days[$month-1];
129
-		}else return 31;
131
+		} else {
132
+			return 31;
133
+		}
130 134
     }
131 135
 
132 136
 	//Deprecate since v1.6
@@ -143,7 +147,9 @@  discard block
 block discarded – undo
143 147
 		$startdate = $this->startDate;
144 148
 
145 149
 		for($i=0; $i<=6; $i++){
146
-			if($startdate >= sizeof($hdrs)) $startdate = 0;
150
+			if($startdate >= sizeof($hdrs)) {
151
+				$startdate = 0;
152
+			}
147 153
 			//if(isset($hdrs[(string)$startdate]))
148 154
 				$rtn_hdrs[] = $hdrs[(string)$startdate];
149 155
 
@@ -195,7 +201,9 @@  discard block
 block discarded – undo
195 201
 	//specified location of the calendar_form.php
196 202
 	function setPath($path){
197 203
 		$last_char = substr($path, strlen($path)-1, strlen($path));
198
-		if($last_char != "/") $path .= "/";
204
+		if($last_char != "/") {
205
+			$path .= "/";
206
+		}
199 207
 		$this->path = $path;
200 208
 	}
201 209
 
@@ -233,9 +241,9 @@  discard block
 block discarded – undo
233 241
 
234 242
 					if($tz_sys_ms>=0 && $tz_new_ms<=0){
235 243
 						$timezone_diff = 0-($tz_sys_ms+abs($tz_new_ms));
236
-					}elseif($tz_sys_ms<=0 && $tz_new_ms>=0){
244
+					} elseif($tz_sys_ms<=0 && $tz_new_ms>=0){
237 245
 						$timezone_diff = abs($tz_sys_ms)+$tz_new_ms;
238
-					}else{
246
+					} else{
239 247
 						$timezone_diff = $tz_sys_ms-$tz_new_ms;
240 248
 					}
241 249
 					$timezone_diff_hr = $timezone_diff/3600;
@@ -255,7 +263,7 @@  discard block
 block discarded – undo
255 263
 					$this->year = date("Y", $n_time);
256 264
 					$this->month = date("m", $n_time);
257 265
 					$this->day = date("d", $n_time);
258
-				}else{
266
+				} else{
259 267
 					$date = new DateTime($a_date, new DateTimeZone($this->system_timezone));
260 268
 					$date->setTimezone(new DateTimeZone($this->timezone));
261 269
 					$this->year = $date->format('Y');
@@ -276,7 +284,7 @@  discard block
 block discarded – undo
276 284
 				$str .= $this->writeDay();
277 285
 				$str .= $this->writeMonth();
278 286
 				$str .= $this->writeYear();
279
-			}else{
287
+			} else{
280 288
 				$str .= " <a href=\"javascript:toggleCalendar('".$this->objname."', ".$this->auto_hide.", ".$this->auto_hide_time.");\" class=\"tclabel\">";
281 289
 				$str .= $this->writeDateContainer();
282 290
 				$str .= "</a>";
@@ -285,19 +293,21 @@  discard block
 block discarded – undo
285 293
 			$str .= " <a href=\"javascript:toggleCalendar('".$this->objname."', ".$this->auto_hide.", ".$this->auto_hide_time.");\">";
286 294
 			if(is_file($this->icon)){
287 295
 				$str .= "<img src=\"".$this->icon."\" id=\"tcbtn_".$this->objname."\" name=\"tcbtn_".$this->objname."\" border=\"0\" align=\"absmiddle\" style=\"vertical-align:middle;\" alt=\"".$this->txt."\" title=\"".$this->txt."\" />";
288
-			}else $str .= $this->txt;
296
+			} else {
297
+				$str .= $this->txt;
298
+			}
289 299
 			$str .= "</a>";
290 300
 
291 301
 			$str .= $this->writeCalendarContainer();
292 302
 
293 303
 			$str .= "</div>";
294
-		}else{
304
+		} else{
295 305
 			$str .= $this->writeCalendarContainer();
296 306
 		}
297 307
 
298 308
 		if($buffer){
299 309
 			return $str;
300
-		}else{
310
+		} else{
301 311
 			echo($str);
302 312
 		}
303 313
 	}
@@ -307,97 +317,157 @@  discard block
 block discarded – undo
307 317
 		$params[] = "objname=".$this->objname;
308 318
 
309 319
 		$param = $this->day;
310
-		if($param != "") $params[] = "selected_day=".$param;
320
+		if($param != "") {
321
+			$params[] = "selected_day=".$param;
322
+		}
311 323
 
312 324
 		$param = $this->month;
313
-		if($param != "") $params[] = "selected_month=".$param;
325
+		if($param != "") {
326
+			$params[] = "selected_month=".$param;
327
+		}
314 328
 
315 329
 		$param = $this->year;
316
-		if($param != "") $params[] = "selected_year=".$param;
330
+		if($param != "") {
331
+			$params[] = "selected_year=".$param;
332
+		}
317 333
 
318 334
 		$param = $this->year_start_input;
319
-		if($param != "") $params[] = "year_start=".$param;
335
+		if($param != "") {
336
+			$params[] = "year_start=".$param;
337
+		}
320 338
 
321 339
 		$param = $this->year_end_input;
322
-		if($param != "") $params[] = "year_end=".$param;
340
+		if($param != "") {
341
+			$params[] = "year_end=".$param;
342
+		}
323 343
 
324 344
 		$param = ($this->date_picker) ? 1 : 0;
325
-		if($param != "") $params[] = "dp=".$param;
345
+		if($param != "") {
346
+			$params[] = "dp=".$param;
347
+		}
326 348
 
327 349
 		$param = $this->time_allow1;
328
-		if($param != "") $params[] = "da1=".$param;
350
+		if($param != "") {
351
+			$params[] = "da1=".$param;
352
+		}
329 353
 
330 354
 		$param = $this->time_allow2;
331
-		if($param != "") $params[] = "da2=".$param;
355
+		if($param != "") {
356
+			$params[] = "da2=".$param;
357
+		}
332 358
 
333 359
 		$param = $this->show_not_allow;
334
-		if($param != "") $params[] = "sna=".$param;
360
+		if($param != "") {
361
+			$params[] = "sna=".$param;
362
+		}
335 363
 
336 364
 		$param = $this->auto_submit;
337
-		if($param != "") $params[] = "aut=".$param;
365
+		if($param != "") {
366
+			$params[] = "aut=".$param;
367
+		}
338 368
 
339 369
 		$param = $this->form_container;
340
-		if($param != "") $params[] = "frm=".$param;
370
+		if($param != "") {
371
+			$params[] = "frm=".$param;
372
+		}
341 373
 
342 374
 		$param = $this->target_url;
343
-		if($param != "") $params[] = "tar=".$param;
375
+		if($param != "") {
376
+			$params[] = "tar=".$param;
377
+		}
344 378
 
345 379
 		$param = $this->show_input;
346
-		if($param != "") $params[] = "inp=".$param;
380
+		if($param != "") {
381
+			$params[] = "inp=".$param;
382
+		}
347 383
 
348 384
 		$param = $this->date_format;
349
-		if($param != "") $params[] = "fmt=".$param;
385
+		if($param != "") {
386
+			$params[] = "fmt=".$param;
387
+		}
350 388
 
351 389
 		$param = implode(",", $this->dsb_days);
352
-		if($param != "") $params[] = "dis=".$param;
390
+		if($param != "") {
391
+			$params[] = "dis=".$param;
392
+		}
353 393
 
354 394
 		$param = $this->date_pair1;
355
-		if($param != "") $params[] = "pr1=".$param;
395
+		if($param != "") {
396
+			$params[] = "pr1=".$param;
397
+		}
356 398
 
357 399
 		$param = $this->date_pair2;
358
-		if($param != "") $params[] = "pr2=".$param;
400
+		if($param != "") {
401
+			$params[] = "pr2=".$param;
402
+		}
359 403
 
360 404
 		$param = $this->date_pair_value;
361
-		if($param != "") $params[] = "prv=".$param;
405
+		if($param != "") {
406
+			$params[] = "prv=".$param;
407
+		}
362 408
 
363 409
 		$param = $this->path;
364
-		if($param != "") $params[] = "pth=".$param;
410
+		if($param != "") {
411
+			$params[] = "pth=".$param;
412
+		}
365 413
 
366 414
 		$param = htmlspecialchars($this->check_json_encode($this->sp_dates), ENT_QUOTES);
367
-		if($param != "") $params[] = "spd=".$param;
415
+		if($param != "") {
416
+			$params[] = "spd=".$param;
417
+		}
368 418
 
369 419
 		$param = $this->sp_type;
370
-		if($param != "") $params[] = "spt=".$param;
420
+		if($param != "") {
421
+			$params[] = "spt=".$param;
422
+		}
371 423
 
372 424
 		$param = rawurlencode($this->tc_onchanged);
373
-		if($param != "") $params[] = "och=".$param;
425
+		if($param != "") {
426
+			$params[] = "och=".$param;
427
+		}
374 428
 
375 429
 		$param = $this->startDate;
376
-		if($param != "") $params[] = "str=".$param;
430
+		if($param != "") {
431
+			$params[] = "str=".$param;
432
+		}
377 433
 
378 434
 		$param = $this->rtl;
379
-		if($param != "") $params[] = "rtl=".$param;
435
+		if($param != "") {
436
+			$params[] = "rtl=".$param;
437
+		}
380 438
 
381 439
 		$param = $this->show_week;
382
-		if($param != "") $params[] = "wks=".$param;
440
+		if($param != "") {
441
+			$params[] = "wks=".$param;
442
+		}
383 443
 
384 444
 		$param = $this->interval;
385
-		if($param != "") $params[] = "int=".$param;
445
+		if($param != "") {
446
+			$params[] = "int=".$param;
447
+		}
386 448
 
387 449
 		$param = $this->auto_hide;
388
-		if($param != "") $params[] = "hid=".$param;
450
+		if($param != "") {
451
+			$params[] = "hid=".$param;
452
+		}
389 453
 
390 454
 		$param = $this->auto_hide_time;
391
-		if($param != "") $params[] = "hdt=".$param;
455
+		if($param != "") {
456
+			$params[] = "hdt=".$param;
457
+		}
392 458
 
393 459
 		$param = $this->timezone;
394
-		if($param != "") $params[] = "tmz=".$param;
460
+		if($param != "") {
461
+			$params[] = "tmz=".$param;
462
+		}
395 463
 
396 464
 		//$param = $this->system_timezone;
397 465
 		//if($param != "") $params[] = "stz=".$param;
398 466
 
399 467
 		$param = $this->theme;
400
-		if($param != "") $params[] = "thm=".$param;
468
+		if($param != "") {
469
+			$params[] = "thm=".$param;
470
+		}
401 471
 
402 472
 		$paramStr = (sizeof($params)>0) ? "?".implode("&", $params) : "";
403 473
 
@@ -432,7 +502,7 @@  discard block
 block discarded – undo
432 502
 				default:
433 503
 					$div_align .= "right:0px;";
434 504
 			}
435
-		}else{
505
+		} else{
436 506
 			$div_display = "visible";
437 507
 			$div_position = "relative";
438 508
 			$div_align = "";
@@ -498,10 +568,10 @@  discard block
 block discarded – undo
498 568
 			if($this->time_allow1 && $this->time_allow2){
499 569
 				$year_start = $this->mydate->getDate("Y", $this->time_allow1);
500 570
 				$year_end = $this->mydate->getDate("Y", $this->time_allow2);
501
-			}elseif($this->time_allow1){
571
+			} elseif($this->time_allow1){
502 572
 				//only date 1 specified
503 573
 				$year_start = $this->mydate->getDate("Y", $this->time_allow1);
504
-			}elseif($this->time_allow2){
574
+			} elseif($this->time_allow2){
505 575
 				//only date 2 specified
506 576
 				$year_end = $this->mydate->getDate("Y", $this->time_allow2);
507 577
 			}
@@ -518,7 +588,9 @@  discard block
 block discarded – undo
518 588
 
519 589
 	function eHidden($suffix, $value) {
520 590
 		if(trim($value) != ""){
521
-			if($suffix) $suffix = "_".$suffix;
591
+			if($suffix) {
592
+				$suffix = "_".$suffix;
593
+			}
522 594
 			return "<input type=\"hidden\" name=\"".$this->objname.$suffix."\" id=\"".$this->objname.$suffix."\" value=\"".$value."\" />";
523 595
 		}
524 596
 	}
@@ -575,7 +647,9 @@  discard block
 block discarded – undo
575 647
 	// Auto sizing is applied
576 648
 	//---------------------------
577 649
 	function setWidth($width){
578
-		if($width) $this->width = $width;
650
+		if($width) {
651
+			$this->width = $width;
652
+		}
579 653
 	}
580 654
 
581 655
 	//set height of calendar
@@ -584,20 +658,26 @@  discard block
 block discarded – undo
584 658
 	// Auto sizing is applied
585 659
 	//---------------------------
586 660
 	function setHeight($height){
587
-		if($height) $this->height = $height;
661
+		if($height) {
662
+			$this->height = $height;
663
+		}
588 664
 	}
589 665
 
590 666
 	function setYearInterval($start, $end){
591 667
 		$this->year_start_input = $start;
592 668
 		$this->year_end_input = $end;
593 669
 
594
-		if(!$start) $start = $this->year_start;
595
-		if(!$end) $end = $this->year_end;
670
+		if(!$start) {
671
+			$start = $this->year_start;
672
+		}
673
+		if(!$end) {
674
+			$end = $this->year_end;
675
+		}
596 676
 
597 677
 		if($start < $end){
598 678
 			$this->year_start = $start;
599 679
 			$this->year_end = $end;
600
-		}else{
680
+		} else{
601 681
 			$this->year_start = $end;
602 682
 			$this->year_end = $start;
603 683
 		}
@@ -615,12 +695,15 @@  discard block
 block discarded – undo
615 695
 		//$this->startMonday = $flag;
616 696
 
617 697
 		//change it so that it will not cause an error after version 3.61
618
-		if($flag) $this->startDate = 1;
698
+		if($flag) {
699
+			$this->startDate = 1;
700
+		}
619 701
 	}
620 702
 
621 703
 	function startDate($num){
622
-		if(is_numeric($num) && $num >= 0 && $num <= 6)
623
-			$this->startDate = $num;
704
+		if(is_numeric($num) && $num >= 0 && $num <= 6) {
705
+					$this->startDate = $num;
706
+		}
624 707
 	}
625 708
 
626 709
 	function dateAllow($from = "", $to = "", $show_not_allow = true){
@@ -637,19 +720,27 @@  discard block
 block discarded – undo
637 720
 		if ($time_from != null) {
638 721
 			$this->time_allow1 = $time_from;
639 722
 			$y = $this->mydate->getDate('Y', $time_from);
640
-			if($this->year_start && $y > $this->year_start) $this->year_start = $y;
723
+			if($this->year_start && $y > $this->year_start) {
724
+				$this->year_start = $y;
725
+			}
641 726
 
642 727
 			//setup year end from year start
643
-			if($time_to == null && !$this->year_end) $this->year_end = $this->year_start + $this->year_display_from_current;
728
+			if($time_to == null && !$this->year_end) {
729
+				$this->year_end = $this->year_start + $this->year_display_from_current;
730
+			}
644 731
 		}
645 732
 
646 733
 		if ($time_to>0) {
647 734
 			$this->time_allow2 = $time_to;
648 735
 			$y = $this->mydate->getDate('Y', $time_to);
649
-			if($this->year_end && $y < $this->year_end) $this->year_end = $y;
736
+			if($this->year_end && $y < $this->year_end) {
737
+				$this->year_end = $y;
738
+			}
650 739
 
651 740
 			//setup year start from year end
652
-			if($time_from == null && !$this->year_start) $this->year_start = $this->year_end - $this->year_display_from_current;
741
+			if($time_from == null && !$this->year_start) {
742
+				$this->year_start = $this->year_end - $this->year_display_from_current;
743
+			}
653 744
 		}
654 745
 
655 746
 		$this->show_not_allow = $show_not_allow;
@@ -672,7 +763,9 @@  discard block
 block discarded – undo
672 763
 	function writeDateContainer(){
673 764
 		if($this->day && $this->month && $this->year){
674 765
 			$dd = $this->mydate->getDate($this->date_format, $this->year."-".$this->month."-".$this->day);
675
-		}else $dd = "Select Date";
766
+		} else {
767
+			$dd = "Select Date";
768
+		}
676 769
 
677 770
 		return "<div id=\"divCalendar_".$this->objname."_lbl\" class=\"date-tccontainer\">$dd</div>";
678 771
 	}
@@ -683,8 +776,9 @@  discard block
 block discarded – undo
683 776
 	//------------------------------------------------------
684 777
 	function disabledDay($day){
685 778
 		$day = strtolower($day); //make it not case-sensitive
686
-		if(in_array($day, $this->dsb_days) === false)
687
-			$this->dsb_days[] = $day;
779
+		if(in_array($day, $this->dsb_days) === false) {
780
+					$this->dsb_days[] = $day;
781
+		}
688 782
 	}
689 783
 
690 784
 	function setAlignment($h_align, $v_align){
@@ -695,12 +789,14 @@  discard block
 block discarded – undo
695 789
 	function setDatePair($calendar_name1, $calendar_name2, $pair_value = "0000-00-00 00:00:00"){
696 790
 		if($calendar_name1 != $this->objname){
697 791
 			$this->date_pair1 = $calendar_name1;
698
-			if($pair_value != "0000-00-00 00:00:00")
699
-				$this->date_pair_value = $pair_value;
700
-		}elseif($calendar_name2 != $this->objname){
792
+			if($pair_value != "0000-00-00 00:00:00") {
793
+							$this->date_pair_value = $pair_value;
794
+			}
795
+		} elseif($calendar_name2 != $this->objname){
701 796
 			$this->date_pair2 = $calendar_name2;
702
-			if($pair_value != "0000-00-00 00:00:00")
703
-				$this->date_pair_value = $pair_value;
797
+			if($pair_value != "0000-00-00 00:00:00") {
798
+							$this->date_pair_value = $pair_value;
799
+			}
704 800
 		}
705 801
 	}
706 802
 
@@ -713,16 +809,19 @@  discard block
 block discarded – undo
713 809
 				if($this->mydate->validDate($sp_date)){
714 810
 					switch($recursive){
715 811
 						case "month": //add to monthly
716
-							if(!in_array($sp_date, $this->sp_dates[1]))
717
-								$this->sp_dates[1][] = $sp_date;
812
+							if(!in_array($sp_date, $this->sp_dates[1])) {
813
+															$this->sp_dates[1][] = $sp_date;
814
+							}
718 815
 							break;
719 816
 						case "year": //add to yearly
720
-							if(!in_array($sp_date, $this->sp_dates[2]))
721
-								$this->sp_dates[2][] = $sp_date;
817
+							if(!in_array($sp_date, $this->sp_dates[2])) {
818
+															$this->sp_dates[2][] = $sp_date;
819
+							}
722 820
 							break;
723 821
 						default: //add to no recursive
724
-							if(!in_array($sp_date, $this->sp_dates[0]))
725
-								$this->sp_dates[0][] = $sp_date;
822
+							if(!in_array($sp_date, $this->sp_dates[0])) {
823
+															$this->sp_dates[0][] = $sp_date;
824
+							}
726 825
 					}
727 826
 				}
728 827
 			}
@@ -790,10 +889,14 @@  discard block
 block discarded – undo
790 889
 			if($this->mydate->dateBefore($this->time_allow1, $date_str, false) || $this->mydate->dateAfter($this->time_allow2, $date_str, false)){
791 890
 				return false;
792 891
 			}
793
-		}elseif($this->time_allow1){
794
-			if($this->mydate->dateBefore($this->time_allow1, $date_str, false)) return false;
795
-		}elseif($this->time_allow2){
796
-			if($this->mydate->dateAfter($this->time_allow2, $date_str, false)) return false;
892
+		} elseif($this->time_allow1){
893
+			if($this->mydate->dateBefore($this->time_allow1, $date_str, false)) {
894
+				return false;
895
+			}
896
+		} elseif($this->time_allow2){
897
+			if($this->mydate->dateAfter($this->time_allow2, $date_str, false)) {
898
+				return false;
899
+			}
797 900
 		}
798 901
 
799 902
 		//check with specific date
@@ -830,11 +933,15 @@  discard block
 block discarded – undo
830 933
 				case 0:
831 934
 				default:
832 935
 					//disabled specific and enabled others
833
-					if($sp_found) return false;
936
+					if($sp_found) {
937
+						return false;
938
+					}
834 939
 					break;
835 940
 				case 1:
836 941
 					//enabled specific and disabled others
837
-					if(!$sp_found) return false;
942
+					if(!$sp_found) {
943
+						return false;
944
+					}
838 945
 					break;
839 946
 			}
840 947
 		}
@@ -854,17 +961,21 @@  discard block
 block discarded – undo
854 961
 		if(is_array($obj)){
855 962
 			if(function_exists("json_encode") && false){
856 963
 				return json_encode($obj);
857
-			}else{
964
+			} else{
858 965
 				//only array is assumed for now
859 966
 				$return_arr = array();
860 967
 				foreach($obj as $arr){
861
-					if(is_array($arr) && sizeof($arr)>0)
862
-						$return_arr[] = "[\"".implode("\",\"", $arr)."\"]";
863
-					else $return_arr[] = "[]";
968
+					if(is_array($arr) && sizeof($arr)>0) {
969
+											$return_arr[] = "[\"".implode("\",\"", $arr)."\"]";
970
+					} else {
971
+						$return_arr[] = "[]";
972
+					}
864 973
 				}
865 974
 				return "[".implode(",", $return_arr)."]";
866 975
 			}
867
-		}else return "";
976
+		} else {
977
+			return "";
978
+		}
868 979
 	}
869 980
 
870 981
 	function &check_json_decode($str){
@@ -872,7 +983,7 @@  discard block
 block discarded – undo
872 983
 
873 984
 		if(function_exists("json_decode") && false){
874 985
 			return json_decode($str);
875
-		}else{
986
+		} else{
876 987
 			//only array is assume for now
877 988
 			$str = stripslashes(rawurldecode($str));
878 989
 			$str = trim($str);
@@ -890,9 +1001,9 @@  discard block
 block discarded – undo
890 1001
 					$arr = explode("],[", $str);
891 1002
 					for($i=0; $i<sizeof($arr); $i++){
892 1003
 						$this_v = $arr[$i];
893
-						if($this_v == "")
894
-							$return_arr[] = array();
895
-						else{
1004
+						if($this_v == "") {
1005
+													$return_arr[] = array();
1006
+						} else{
896 1007
 							$this_arr = explode(",", $this_v);
897 1008
 
898 1009
 							for($j=0; $j<sizeof($this_arr); $j++){
@@ -905,8 +1016,12 @@  discard block
 block discarded – undo
905 1016
 						}
906 1017
 					}
907 1018
 					return $return_arr;
908
-				}else return array();
909
-			}else return array();
1019
+				} else {
1020
+					return array();
1021
+				}
1022
+			} else {
1023
+				return array();
1024
+			}
910 1025
 		}
911 1026
 	}
912 1027
 
@@ -939,14 +1054,16 @@  discard block
 block discarded – undo
939 1054
 		//check if today is in range of date allow
940 1055
 		if($this->time_allow1 != ""){
941 1056
 			//check valid if today is after date_allow1
942
-			if($this->mydate->validDate($this->time_allow1) && !$this->mydate->dateAfter($this->time_allow1, $today))
943
-				return false;
1057
+			if($this->mydate->validDate($this->time_allow1) && !$this->mydate->dateAfter($this->time_allow1, $today)) {
1058
+							return false;
1059
+			}
944 1060
 		}
945 1061
 
946 1062
 		if($this->time_allow2 > 0){
947 1063
 			//check valid if today is before date_allow2
948
-			if($this->mydate->validDate($this->time_allow2) && !$this->mydate->dateBefore($this->time_allow2, $today))
949
-				return false;
1064
+			if($this->mydate->validDate($this->time_allow2) && !$this->mydate->dateBefore($this->time_allow2, $today)) {
1065
+							return false;
1066
+			}
950 1067
 		}
951 1068
 		return true;
952 1069
 	}
@@ -966,8 +1083,7 @@  discard block
 block discarded – undo
966 1083
 						if(!in_array($tt_time, $this->tt_dates[2])){
967 1084
 							$this->tt_dates[2][] = $tt_time;
968 1085
 							$this->tt_tooltips[2][] = $tooltip;
969
-						}
970
-						else{
1086
+						} else{
971 1087
 							$tt_key = array_search($tt_time, $this->tt_dates[2]);
972 1088
 							$this->tt_tooltips[2][$tt_key] = $this->tt_tooltips[2][$tt_key]."\n".$tooltip;
973 1089
 						}
@@ -976,8 +1092,7 @@  discard block
 block discarded – undo
976 1092
 						if(!in_array($tt_time, $this->tt_dates[1])){
977 1093
 							$this->tt_dates[1][] = $tt_time;
978 1094
 							$this->tt_tooltips[1][] = $tooltip;
979
-						}
980
-						else{
1095
+						} else{
981 1096
 							$tt_key = array_search($tt_time, $this->tt_dates[1]);
982 1097
 							$this->tt_tooltips[1][$tt_key] = $this->tt_tooltips[1][$tt_key]."\n".$tooltip;
983 1098
 						}
@@ -986,8 +1101,7 @@  discard block
 block discarded – undo
986 1101
 						if(!in_array($tt_time, $this->tt_dates[0])){
987 1102
 							$this->tt_dates[0][] = $tt_time;
988 1103
 							$this->tt_tooltips[0][] = $tooltip;
989
-						}
990
-						else{
1104
+						} else{
991 1105
 							$tt_key = array_search($tt_time, $this->tt_dates[0]);
992 1106
 							$this->tt_tooltips[0][$tt_key] = $this->tt_tooltips[0][$tt_key]."\n".$tooltip;
993 1107
 						}
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/classes/tc_date_main.php 1 patch
Braces   +36 added lines, -13 removed lines patch added patch discarded remove patch
@@ -27,15 +27,18 @@  discard block
 block discarded – undo
27 27
 	}
28 28
 
29 29
 	function setDate($sdate){
30
-		if($this->validDate($sdate))
31
-			$this->mydate = strtotime($sdate);
30
+		if($this->validDate($sdate)) {
31
+					$this->mydate = strtotime($sdate);
32
+		}
32 33
 	}
33 34
 
34 35
 	function getDate($format = "Y-m-d", $cdate = ""){
35 36
 		if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
36 37
 			$tmp_date = ($cdate != "") ? strtotime($cdate) : $this->mydate;
37 38
 			return date($format, $tmp_date);
38
-		}else return "";
39
+		} else {
40
+			return "";
41
+		}
39 42
 	}
40 43
 
41 44
 	function setTimestamp($stime){
@@ -46,34 +49,44 @@  discard block
 block discarded – undo
46 49
 		if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
47 50
 			$tmp_date = ($cdate != "") ? strtotime($cdate) : $this->mydate;
48 51
 			return $tmp_date;
49
-		}else return 0;
52
+		} else {
53
+			return 0;
54
+		}
50 55
 	}
51 56
 
52 57
 	function getDateFromTimestamp($stime, $format = "Y-m-d"){
53 58
 		if($stime && $stime > 0){
54 59
 			return date($format, $stime);
55
-		}else return "0000-00-00";
60
+		} else {
61
+			return "0000-00-00";
62
+		}
56 63
 	}
57 64
 
58 65
 	function addDay($format = "Y-m-d", $timespan, $cdate = ""){
59 66
 		if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
60 67
 			$tmp_date = ($cdate != "") ? strtotime($cdate) : $this->mydate;
61 68
 			return date($format, mktime(0,0,0,date('m', $tmp_date),(date('d', $tmp_date)+$timespan),date('Y', $tmp_date)));
62
-		}else return "0000-00-00";
69
+		} else {
70
+			return "0000-00-00";
71
+		}
63 72
 	}
64 73
 
65 74
 	function addMonth($format = "Y-m-d", $timespan, $cdate = ""){
66 75
 		if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
67 76
 			$tmp_date = ($cdate != "") ? strtotime($cdate) : $this->mydate;
68 77
 			return date($format, mktime(0,0,0,(date('m', $tmp_date)+$timespan),date('d', $tmp_date),date('Y', $tmp_date)));
69
-		}else return "0000-00-00";
78
+		} else {
79
+			return "0000-00-00";
80
+		}
70 81
 	}
71 82
 
72 83
 	function addYear($format = "Y-m-d", $timespan, $cdate = ""){
73 84
 		if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
74 85
 			$tmp_date = ($cdate != "") ? strtotime($cdate) : $this->mydate;
75 86
 			return date($format, mktime(0,0,0,date('m', $tmp_date),date('d', $tmp_date),(date('Y', $tmp_date)+$timespan)));
76
-		}else return "0000-00-00";
87
+		} else {
88
+			return "0000-00-00";
89
+		}
77 90
 	}
78 91
 
79 92
 	//return the number of day different between date1 and date2
@@ -84,7 +97,9 @@  discard block
 block discarded – undo
84 97
 
85 98
 			$date_diff = $date1-strtotime($date2);
86 99
 			return abs($date_diff);
87
-		}else return false;
100
+		} else {
101
+			return false;
102
+		}
88 103
 	}
89 104
 
90 105
 	//check if date1 is before date2
@@ -94,7 +109,9 @@  discard block
 block discarded – undo
94 109
 			$date1 = ($date1 != "") ? strtotime($date1) : $this->mydate;
95 110
 			$date2 = strtotime($date2);
96 111
 			return ($equal) ? $date1<=$date2 : $date1<$date2;
97
-		}else return false;
112
+		} else {
113
+			return false;
114
+		}
98 115
 	}
99 116
 
100 117
 	//check if date1 is after date2
@@ -104,7 +121,9 @@  discard block
 block discarded – undo
104 121
 			$date1 = ($date1 != "") ? strtotime($date1) : $this->mydate;
105 122
 			$date2 = strtotime($date2);
106 123
 			return ($equal) ? $date1>=$date2 : $date1>$date2;
107
-		}else return false;
124
+		} else {
125
+			return false;
126
+		}
108 127
 	}
109 128
 
110 129
 	function validDate($date_str){
@@ -113,8 +132,12 @@  discard block
 block discarded – undo
113 132
 
114 133
 			if((isset($date_arr[0]) && is_numeric($date_arr[0])) && (isset($date_arr[1]) && is_numeric($date_arr[1])) && (isset($date_arr[2]) && is_numeric($date_arr[2]))){
115 134
 				return (checkdate($date_arr[1], $date_arr[2], $date_arr[0])) ? true : false;
116
-			}else return false;
117
-		}else return false;
135
+			} else {
136
+				return false;
137
+			}
138
+		} else {
139
+			return false;
140
+		}
118 141
 	}
119 142
 }
120 143
 ?>
121 144
\ No newline at end of file
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/classes/tc_date.php 1 patch
Braces   +38 added lines, -23 removed lines patch added patch discarded remove patch
@@ -14,11 +14,13 @@  discard block
 block discarded – undo
14 14
 		//check if we should use DateTime that comes with 5.3.0 and later
15 15
 		if (version_compare(PHP_VERSION, '5.3.0') <= 0) {
16 16
 			$this->compatible = false;
17
-		}else $this->compatible = true;
17
+		} else {
18
+			$this->compatible = true;
19
+		}
18 20
 
19 21
 		if(!$this->compatible){
20 22
 			$this->tc_date_main();
21
-		}else{
23
+		} else{
22 24
 			$this->mydate = new DateTime('now');
23 25
 		}
24 26
 	}
@@ -26,49 +28,56 @@  discard block
 block discarded – undo
26 28
 	function getDayOfWeek($cdate = ""){
27 29
 		if(!$this->compatible){
28 30
 			return tc_date_main::getDayOfWeek($cdate);
29
-		}else{
31
+		} else{
30 32
 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
31 33
 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;
32 34
 				return $tmp_date->format('w');
33
-			}else return "";
35
+			} else {
36
+				return "";
37
+			}
34 38
 		}
35 39
 	}
36 40
 
37 41
 	function getWeekNumber($cdate = ""){
38 42
 		if(!$this->compatible){
39 43
 			return tc_date_main::getWeekNumber($cdate);
40
-		}else{
44
+		} else{
41 45
 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
42 46
 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;
43 47
 				return $tmp_date->format('W');
44
-			}else return "";
48
+			} else {
49
+				return "";
50
+			}
45 51
 		}
46 52
 	}
47 53
 
48 54
 	function setDate($sdate){
49 55
 		if(!$this->compatible){
50 56
 			tc_date_main::setDate($sdate);
51
-		}else{
52
-			if(tc_date_main::validDate($sdate))
53
-				$this->mydate = new DateTime($sdate);
57
+		} else{
58
+			if(tc_date_main::validDate($sdate)) {
59
+							$this->mydate = new DateTime($sdate);
60
+			}
54 61
 		}
55 62
 	}
56 63
 
57 64
 	function getDate($format = "Y-m-d", $cdate = ""){
58 65
 		if(!$this->compatible){
59 66
 			return tc_date_main::getDate($format, $cdate);
60
-		}else{
67
+		} else{
61 68
 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
62 69
 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;
63 70
 				return $tmp_date->format($format);
64
-			}else return "";
71
+			} else {
72
+				return "";
73
+			}
65 74
 		}
66 75
 	}
67 76
 
68 77
 	function setTimestamp($stime){
69 78
 		if(!$this->compatible){
70 79
 			tc_date_main::setTimestamp($stime);
71
-		}else{
80
+		} else{
72 81
 			$this->mydate->setTimestamp($stime);
73 82
 		}
74 83
 	}
@@ -76,11 +85,13 @@  discard block
 block discarded – undo
76 85
 	function getTimestamp($cdate = ""){
77 86
 		if(!$this->compatible){
78 87
 			return tc_date_main::getTimestamp($cdate);
79
-		}else{
88
+		} else{
80 89
 			if(($cdate != "" && $this->validDate($cdate)) || $cdate == ""){
81 90
 				$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;
82 91
 				return $tmp_date->getTimestamp();
83
-			}else return 0;
92
+			} else {
93
+				return 0;
94
+			}
84 95
 		}
85 96
 	}
86 97
 
@@ -88,18 +99,20 @@  discard block
 block discarded – undo
88 99
 		if($stime){
89 100
 			if(!$this->compatible){
90 101
 				return tc_date_main::getDateFromTimestamp($stime, $format);
91
-			}else{
102
+			} else{
92 103
 				$tmp_date = new DateTime();
93 104
 				$tmp_date->setTimestamp($stime);
94 105
 				return $tmp_date->format($format);
95 106
 			}
96
-		}else return "";
107
+		} else {
108
+			return "";
109
+		}
97 110
 	}
98 111
 
99 112
 	function addDay($format = "Y-m-d", $timespan, $cdate = ""){
100 113
 		if(!$this->compatible){
101 114
 			return tc_date_main::addDay($format, $timespan, $cdate);
102
-		}else{
115
+		} else{
103 116
 			$timespan = "P".$timespan."D";
104 117
 			return $this->addDate($format, $timespan, $cdate);
105 118
 		}
@@ -108,7 +121,7 @@  discard block
 block discarded – undo
108 121
 	function addMonth($format = "Y-m-d", $timespan, $cdate = ""){
109 122
 		if(!$this->compatible){
110 123
 			return tc_date_main::addMonth($format, $timespan, $cdate);
111
-		}else{
124
+		} else{
112 125
 			$timespan = "P".$timespan."M";
113 126
 			return $this->addDate($format, $timespan, $cdate);
114 127
 		}
@@ -117,7 +130,7 @@  discard block
 block discarded – undo
117 130
 	function addYear($format = "Y-m-d", $timespan, $cdate = ""){
118 131
 		if(!$this->compatible){
119 132
 			return tc_date_main::addYear($format, $timespan, $cdate);
120
-		}else{
133
+		} else{
121 134
 			$timespan = "P".$timespan."Y";
122 135
 			return $this->addDate($format, $timespan, $cdate);
123 136
 		}
@@ -128,7 +141,9 @@  discard block
 block discarded – undo
128 141
 			$tmp_date = ($cdate != "") ? new DateTime($cdate) : $this->mydate;
129 142
 			$tmp_date->add(new DateInterval($timespan));
130 143
 			return $tmp_date->format($format);
131
-		}else return "0000-00-00";
144
+		} else {
145
+			return "0000-00-00";
146
+		}
132 147
 	}
133 148
 
134 149
 	//return the number of day different between date1 and date2
@@ -136,7 +151,7 @@  discard block
 block discarded – undo
136 151
 	function differentDate($date2, $date1 = ""){
137 152
 		if(!$this->compatible){
138 153
 			return tc_date_main::differentDate($date2, $date1);
139
-		}else{
154
+		} else{
140 155
 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');
141 156
 
142 157
 			$date1 = new DateTime($date1);
@@ -151,7 +166,7 @@  discard block
 block discarded – undo
151 166
 	function dateBefore($date2, $date1 = "", $equal = true){
152 167
 		if(!$this->compatible){
153 168
 			return tc_date_main::dateBefore($date2, $date1, $equal);
154
-		}else{
169
+		} else{
155 170
 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');
156 171
 
157 172
 			$date1 = new DateTime($date1);
@@ -165,7 +180,7 @@  discard block
 block discarded – undo
165 180
 	function dateAfter($date2, $date1 = "", $equal = true){
166 181
 		if(!$this->compatible){
167 182
 			return tc_date_main::dateAfter($date2, $date1, $equal);
168
-		}else{
183
+		} else{
169 184
 			$date1 = ($date1 != "") ? $date1 : $this->getDate('Y-m-d');
170 185
 
171 186
 			$date1 = new DateTime($date1);
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/calendar_functions.php 1 patch
Braces   +14 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,14 +2,18 @@  discard block
 block discarded – undo
2 2
 function filterInput($str, $type = "text"){
3 3
 	switch(strtolower($type)){
4 4
 		case "number":
5
-			if(is_numeric($str))
6
-				return array(true, $str);
7
-			else return array(false, "Invalid input - '$str', required number");
5
+			if(is_numeric($str)) {
6
+							return array(true, $str);
7
+			} else {
8
+				return array(false, "Invalid input - '$str', required number");
9
+			}
8 10
 			break;
9 11
 		case "boolean":
10
-			if($str == "" || $str == 0 || $str == 1 || is_bool($str))
11
-				return array(true, $str);
12
-			else return array(false, "Invalid input - '$str', required boolean");
12
+			if($str == "" || $str == 0 || $str == 1 || is_bool($str)) {
13
+							return array(true, $str);
14
+			} else {
15
+				return array(false, "Invalid input - '$str', required boolean");
16
+			}
13 17
 			break;
14 18
 		default:
15 19
 			//$str = addslashes($str);
@@ -26,8 +30,10 @@  discard block
 block discarded – undo
26 30
 	$result_txt = isset($results[1]) ? $results[1] : "";
27 31
 	if(isset($results[0]) && $results[0] === true){
28 32
 		return $result_txt;
29
-	}else exit("Error returned '$name' - ".$result_txt);
30
-}
33
+	} else {
34
+		exit("Error returned '$name' - ".$result_txt);
35
+	}
36
+	}
31 37
 
32 38
 function getTranslatedTxt($txt, $allow_tag = false, $maps = array()){
33 39
 	$content = $txt;
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/calendar_info.php 1 patch
Braces   +13 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,9 +2,15 @@  discard block
 block discarded – undo
2 2
 require_once("classes/tc_calendar.php");
3 3
 require_once("classes/tc_date.php");
4 4
 
5
-if(!isset($show_calendar_info)) $show_calendar_info = true;
6
-if(!isset($show_fb_info)) $show_fb_info = true;
7
-if(!isset($show_servertime_info)) $show_servertime_info = true;
5
+if(!isset($show_calendar_info)) {
6
+	$show_calendar_info = true;
7
+}
8
+if(!isset($show_fb_info)) {
9
+	$show_fb_info = true;
10
+}
11
+if(!isset($show_servertime_info)) {
12
+	$show_servertime_info = true;
13
+}
8 14
 
9 15
 $tobj = new tc_calendar("");
10 16
 $version = $tobj->version;
@@ -12,7 +18,9 @@  discard block
 block discarded – undo
12 18
 
13 19
 $tdate = new tc_date();
14 20
 
15
-if(!isset($timezone)) $timezone = date_default_timezone_get();
21
+if(!isset($timezone)) {
22
+	$timezone = date_default_timezone_get();
23
+}
16 24
 
17 25
 $wan_enabled = 0;
18 26
 $new_version = 0;
@@ -22,8 +30,7 @@  discard block
 block discarded – undo
22 30
 			$new_version = @file_get_contents("http://www.triconsole.com/php/tc_calendar_version.php?v=".$version);
23 31
 		}
24 32
 	}
25
-}
26
-elseif(function_exists("file_get_contents")){
33
+} elseif(function_exists("file_get_contents")){
27 34
 	$ctx = stream_context_create(array('http' => array('timeout' => 1)));
28 35
 	$wan_enabled = @file_get_contents("http://www.google.com",null,$ctx,0,1);
29 36
 	if($check_version && $wan_enabled){
Please login to merge, or discard this patch.
contrib/ipImap/report/calendar/calendar_form.php 1 patch
Braces   +136 added lines, -67 removed lines patch added patch discarded remove patch
@@ -13,7 +13,9 @@  discard block
 block discarded – undo
13 13
 //timezone var, need to setup before any other tasks
14 14
 $timezone = getParameter("tmz");
15 15
 
16
-if(!$timezone) $timezone = date_default_timezone_get();
16
+if(!$timezone) {
17
+	$timezone = date_default_timezone_get();
18
+}
17 19
 @date_default_timezone_set($timezone);
18 20
 
19 21
 $cdate = new tc_date();
@@ -23,9 +25,15 @@  discard block
 block discarded – undo
23 25
 $slm = getParameter("selected_month");
24 26
 $sly = getParameter("selected_year");
25 27
 
26
-if(!is_numeric($sld)) $sld = "00";
27
-if(!is_numeric($slm)) $slm = "00";
28
-if(!is_numeric($sly)) $sly = "0000";
28
+if(!is_numeric($sld)) {
29
+	$sld = "00";
30
+}
31
+if(!is_numeric($slm)) {
32
+	$slm = "00";
33
+}
34
+if(!is_numeric($sly)) {
35
+	$sly = "0000";
36
+}
29 37
 
30 38
 $year_start = getParameter("year_start", "number", 0);
31 39
 $year_end = getParameter("year_end", "number", 0);
@@ -74,62 +82,79 @@  discard block
 block discarded – undo
74 82
 
75 83
 //check year to be select in case of date_allow is set
76 84
 if(!$show_not_allow){
77
-  if ($ta1_set && $cdate->validDate($time_allow1)) $year_start = $cdate->getDate('Y', $time_allow1);
78
-  if ($ta2_set && $cdate->validDate($time_allow2)) $year_end = $cdate->getDate('Y', $time_allow2);
79
-}
80
-
81
-if(isset($_REQUEST["m"]))
82
-	$m = getParameter("m", "number");
83
-else{
85
+  if ($ta1_set && $cdate->validDate($time_allow1)) {
86
+  	$year_start = $cdate->getDate('Y', $time_allow1);
87
+  }
88
+  if ($ta2_set && $cdate->validDate($time_allow2)) {
89
+  	$year_end = $cdate->getDate('Y', $time_allow2);
90
+  }
91
+  }
92
+
93
+if(isset($_REQUEST["m"])) {
94
+	$m = getParameter("m", "number");
95
+} else{
84 96
 	if($slm != "00"){
85 97
 		$m = $slm;
86
-	}else{
98
+	} else{
87 99
 		if($ta2_set && $year_end > 0){
88 100
 			//compare which one is more
89 101
 			$year_allow2 = $cdate->getDate('Y', $time_allow2);
90 102
 			if($year_allow2 >= $year_end){
91 103
 				//use time_allow2
92 104
 				$m = ($cdate->dateBefore($time_allow2)) ? $cdate->getDate("m") : $cdate->getDate('m', $time_allow2);
93
-			}else{
105
+			} else{
94 106
 				//use year_end
95 107
 				$m = ($year_end > $cdate->getDate("Y")) ? $cdate->getDate("m") : 12;
96 108
 			}
97
-		}elseif($ta2_set){
109
+		} elseif($ta2_set){
98 110
 			$m = ($cdate->dateBefore($time_allow2)) ? $cdate->getDate("m") : $cdate->getDate('m', $time_allow2);
99
-		}elseif($year_end > 0){
111
+		} elseif($year_end > 0){
100 112
 			$m = ($year_end > $cdate->getDate("Y")) ? $cdate->getDate("m") : 12; //date('m')
101
-		}else{
113
+		} else{
102 114
 			$m = $cdate->getDate("m");
103 115
 		}
104 116
 	}
105 117
 }
106 118
 
107
-if($m < 1 && $m > 12) $m = $cdate->getDate("m");
119
+if($m < 1 && $m > 12) {
120
+	$m = $cdate->getDate("m");
121
+}
108 122
 
109 123
 $m = str_pad($m, 2, "0", STR_PAD_LEFT);
110 124
 
111 125
 $cyr = ($sly != "0000") ? true : false;
112
-if($cyr && $sly && $sly < $year_start) $sly = $year_start;
113
-if($cyr && $sly && $sly > $year_end) $sly = $year_end;
114
-
115
-if(isset($_REQUEST["y"]))
116
-	$y = getParameter("y", "number");
117
-else
118
-	$y = ($cyr) ? $sly : $cdate->getDate("Y");
119
-
120
-if($y <= 0) $y = $cdate->getDate("Y");
126
+if($cyr && $sly && $sly < $year_start) {
127
+	$sly = $year_start;
128
+}
129
+if($cyr && $sly && $sly > $year_end) {
130
+	$sly = $year_end;
131
+}
132
+
133
+if(isset($_REQUEST["y"])) {
134
+	$y = getParameter("y", "number");
135
+} else {
136
+	$y = ($cyr) ? $sly : $cdate->getDate("Y");
137
+}
138
+
139
+if($y <= 0) {
140
+	$y = $cdate->getDate("Y");
141
+}
121 142
 
122 143
 // ensure m-y fits date allow range
123 144
 if (!$show_not_allow) {
124 145
 	if ($ta1_set) {
125 146
 		$m1 = $cdate->getDate('m', $time_allow1);
126 147
 		$y1 = $cdate->getDate('Y', $time_allow1);
127
-		if ($y == $y1 && (int)$m < (int)$m1) $m = $m1;
148
+		if ($y == $y1 && (int)$m < (int)$m1) {
149
+			$m = $m1;
150
+		}
128 151
 	}
129 152
 	if ($ta2_set) {
130 153
 		$m2 = $cdate->getDate('m', $time_allow2);
131 154
 		$y2 = $cdate->getDate('Y', $time_allow2);
132
-		if ($y == $y2 && (int)$m > (int)$m2) $m = $m2;
155
+		if ($y == $y2 && (int)$m > (int)$m2) {
156
+			$m = $m2;
157
+		}
133 158
 	}
134 159
 }
135 160
 
@@ -147,7 +172,9 @@  discard block
 block discarded – undo
147 172
 $cobj->setTimezone($timezone); //set for further usage, nothing for now
148 173
 
149 174
 $theme_path = ($theme != "") ? $cobj->getThemePath($theme) : "";
150
-if(!is_file($theme_path)) $theme_path = "";
175
+if(!is_file($theme_path)) {
176
+	$theme_path = "";
177
+}
151 178
 
152 179
 //check and show default calendar month and year on valid range of date_allow
153 180
 if(!isset($_REQUEST["m"])){
@@ -168,15 +195,19 @@  discard block
 block discarded – undo
168 195
 $year_end = $cobj->year_end;
169 196
 
170 197
 //check year display in valid range
171
-if($y >= $year_end) $y = $year_end;
172
-if($y <= $year_start) $y = $year_start;
198
+if($y >= $year_end) {
199
+	$y = $year_end;
200
+}
201
+if($y <= $year_start) {
202
+	$y = $year_start;
203
+}
173 204
 
174 205
 $total_thismonth = $cobj->total_days($m, $y);
175 206
 
176 207
 if($m == 1){
177 208
 	$previous_month = 12;
178 209
 	$previous_year = $y-1;
179
-}else{
210
+} else{
180 211
 	$previous_month = $m-1;
181 212
 	$previous_year = $y;
182 213
 }
@@ -184,7 +215,7 @@  discard block
 block discarded – undo
184 215
 if($m == 12){
185 216
 	$next_month = 1;
186 217
 	$next_year = $y+1;
187
-}else{
218
+} else{
188 219
 	$next_month = $m+1;
189 220
 	$next_year = $y;
190 221
 }
@@ -196,9 +227,9 @@  discard block
 block discarded – undo
196 227
 if($firstdate == $startDate){
197 228
 	//skip last month
198 229
 	$startwrite = $total_lastmonth+1;
199
-}elseif($firstdate < $startDate){
230
+} elseif($firstdate < $startDate){
200 231
 	$startwrite = $total_lastmonth - (6-($startDate-$firstdate));
201
-}else{
232
+} else{
202 233
 	$startwrite = $total_lastmonth - ($firstdate - $startDate - 1);
203 234
 }
204 235
 
@@ -222,8 +253,10 @@  discard block
 block discarded – undo
222 253
 	$wknum = $cdate->getWeekNumber($prev_d);
223 254
 	if(!isset($week_rows[$row_count][$wknum])){
224 255
 		$week_rows[$row_count][$wknum] = 1;
225
-	}else $week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
226
-}
256
+	} else {
257
+		$week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
258
+	}
259
+	}
227 260
 
228 261
 $pvMonthTime = $previous_year."-".$previous_month."-".$total_lastmonth;
229 262
 
@@ -231,13 +264,20 @@  discard block
 block discarded – undo
231 264
 if($ta1_set && !$show_not_allow){
232 265
 	if($cdate->dateBefore($pvMonthTime, $time_allow1)){
233 266
 		$show_previous = true;
234
-	}else $show_previous = false;
235
-}else $show_previous = true; //always show when not set
267
+	} else {
268
+		$show_previous = false;
269
+	}
270
+	} else {
271
+	$show_previous = true;
272
+}
273
+//always show when not set
236 274
 
237 275
 $date_num = $cdate->getDayOfWeek(($previous_year."-".$previous_month."-".$total_lastmonth));
238 276
 if(($startDate == 0 && $date_num == 6) || ($startDate > 0 && $date_num == $startDate-1) && $startwrite<$total_lastmonth){
239
-	if(isset($calendar_rows[0])) $row_count++;
240
-}
277
+	if(isset($calendar_rows[0])) {
278
+		$row_count++;
279
+	}
280
+	}
241 281
 
242 282
 $dp_time = ($date_pair_value) ? $date_pair_value : "";
243 283
 
@@ -270,13 +310,13 @@  discard block
 block discarded – undo
270 310
 	if($ta1_set && $ta2_set){
271 311
 		//both date specified
272 312
 		$dateLink = ($cdate->dateBefore($date_str, $time_allow1) && $cdate->dateAfter($date_str, $time_allow2)) ? true : false;
273
-	}elseif($ta1_set){
313
+	} elseif($ta1_set){
274 314
 		//only date 1 specified
275 315
 		$dateLink = $cdate->dateBefore($date_str, $time_allow1) ? true : false;
276
-	}elseif($ta2_set){
316
+	} elseif($ta2_set){
277 317
 		//only date 2 specified
278 318
 		$dateLink = $cdate->dateAfter($date_str, $time_allow2) ? true : false;
279
-	}else{
319
+	} else{
280 320
 		//no date allow specified, assume show all
281 321
 		$dateLink = true;
282 322
 	}
@@ -343,13 +383,15 @@  discard block
 block discarded – undo
343 383
 	if($date_pair_value){
344 384
 		//check date_pair1 & 2
345 385
 		if($date_pair1 && $date_pair_value != "0000-00-00" && $cdate->dateAfter($date_pair_value, $date_str) && (($slm>0 && $sld>0 && $sly>0) && $cdate->dateBefore("$sly-$slm-$sld", $date_str))){ //set date only after date_pair1
346
-			if(!in_array("select", $htmlClass))
347
-				$htmlClass[] = "select";
386
+			if(!in_array("select", $htmlClass)) {
387
+							$htmlClass[] = "select";
388
+			}
348 389
 		}
349 390
 
350 391
 		if($date_pair2 && $date_pair_value != "0000-00-00" && $cdate->dateBefore($date_pair_value, $date_str) && (($slm>0 && $sld>0 && $sly>0) && $cdate->dateAfter("$sly-$slm-$sld", $date_str))){ //set date only before date_pair2
351
-			if(!in_array("select", $htmlClass))
352
-				$htmlClass[] = "select";
392
+			if(!in_array("select", $htmlClass)) {
393
+							$htmlClass[] = "select";
394
+			}
353 395
 		}
354 396
 	}
355 397
 
@@ -364,7 +406,7 @@  discard block
 block discarded – undo
364 406
 		$class = implode(" ", $htmlClass);
365 407
 
366 408
 		$calendar_rows[$row_count][] = array($day, "javascript:selectDay('".str_pad($day, 2, "0", STR_PAD_LEFT)."');", $class, "$y".str_pad($m, 2, "0", STR_PAD_LEFT).str_pad($day, 2, "0", STR_PAD_LEFT));
367
-	}else{
409
+	} else{
368 410
 		$htmlClass[] = "disabledate";
369 411
 		$class = implode(" ", $htmlClass);
370 412
 
@@ -381,14 +423,18 @@  discard block
 block discarded – undo
381 423
 		$row_count++;
382 424
 
383 425
 		$dayinweek_counter = 0;
384
-	}else $dayinweek_counter++;
426
+	} else {
427
+		$dayinweek_counter++;
428
+	}
385 429
 
386 430
 	$wknum = $cdate->getWeekNumber(($y."-".$m."-".$day));
387 431
 
388 432
 	if(!isset($week_rows[$row_count][$wknum])){
389 433
 		$week_rows[$row_count][$wknum] = 1;
390
-	}else $week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
391
-}
434
+	} else {
435
+		$week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
436
+	}
437
+	}
392 438
 
393 439
 //write next other month
394 440
 $write_end_days = (6-$dayinweek_counter)+1;
@@ -399,7 +445,9 @@  discard block
 block discarded – undo
399 445
 		$wknum = $cdate->getWeekNumber($cdate->addMonth("Y-m-d", 1, ($y."-".$m."-".$day))); //date('W', mktime(0,0,0, $m+1, $day, $y));
400 446
 		if(!isset($week_rows[$row_count][$wknum])){
401 447
 			$week_rows[$row_count][$wknum] = 1;
402
-		}else $week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
448
+		} else {
449
+			$week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
450
+		}
403 451
 	}
404 452
 	 $row_count++;
405 453
 }
@@ -414,7 +462,9 @@  discard block
 block discarded – undo
414 462
 
415 463
 		if(!isset($week_rows[$row_count][$wknum])){
416 464
 			$week_rows[$row_count][$wknum] = 1;
417
-		}else $week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
465
+		} else {
466
+			$week_rows[$row_count][$wknum] = $week_rows[$row_count][$wknum]+1;
467
+		}
418 468
 	}
419 469
 	$write_end_days += 6;
420 470
 }
@@ -424,11 +474,19 @@  discard block
 block discarded – undo
424 474
 	$nxMonthTime = $next_year."-".$next_month."-1";
425 475
 	if($cdate->dateAfter($nxMonthTime, $time_allow2)){
426 476
 		$show_next = true;
427
-	}else $show_next = false;
428
-}else $show_next = true; //always show when not set
477
+	} else {
478
+		$show_next = false;
479
+	}
480
+	} else {
481
+	$show_next = true;
482
+}
483
+//always show when not set
429 484
 ?>
430 485
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
431
-<html xmlns="http://www.w3.org/1999/xhtml"<?php if($rtl) echo(" dir=\"rtl\""); ?>>
486
+<html xmlns="http://www.w3.org/1999/xhtml"<?php if($rtl) {
487
+	echo(" dir=\"rtl\"");
488
+}
489
+?>>
432 490
 <head>
433 491
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
434 492
 <title>TriConsole.com - PHP Calendar Date Picker</title>
@@ -459,7 +517,7 @@  discard block
 block discarded – undo
459 517
 		if($form_name){
460 518
 			//submit value by post form
461 519
 			echo("window.parent.document.".$form_name.".submit();\n");
462
-		}elseif($target_url){
520
+		} elseif($target_url){
463 521
 			//submit value by get method
464 522
 			echo("var date_selected = yvalue + \"-\" + mvalue + \"-\" + dvalue;\n");
465 523
 			echo("window.parent.location.href='".$target_url."?".$objname."='+date_selected;\n");
@@ -474,7 +532,10 @@  discard block
 block discarded – undo
474 532
 <body leftmargin="0" topmargin="0" marginwidth="0" marginheight="0">
475 533
 <span id="calendar-page" class="font">
476 534
 	<div id="calendar-header" align="center">
477
-		<?php if($show_calendar_info) include("calendar_info.php"); ?>
535
+		<?php if($show_calendar_info) {
536
+	include("calendar_info.php");
537
+}
538
+?>
478 539
 		<?php if($dp && !$auto_hide){ ?>
479 540
 		<div style="float: right;" class="closeme"><a href="javascript:closeMe();"><img src="images/close.gif" border="0" alt="Close" title="Close" /></a></div>
480 541
 		<?php } ?>
@@ -561,7 +622,9 @@  discard block
 block discarded – undo
561 622
 
562 623
 			echo("<tr>");
563 624
 
564
-			if ($show_weeks) echo("<td align=\"center\" class=\"header wk-hdr\"><div>".$cobj->week_hdr."</div></td>");
625
+			if ($show_weeks) {
626
+				echo("<td align=\"center\" class=\"header wk-hdr\"><div>".$cobj->week_hdr."</div></td>");
627
+			}
565 628
 
566 629
 			//write calendar day header
567 630
 			foreach($day_headers as $dh){
@@ -591,7 +654,7 @@  discard block
 block discarded – undo
591 654
 
592 655
 					if($this_link){
593 656
 						echo("<td".$id_str." align=\"center\" class=\"".$this_class."\"><div><a href=\"".$this_link."\">".$this_day."</a></div></td>");
594
-					}else{
657
+					} else{
595 658
 						echo("<td".$id_str." align=\"center\" class=\"".$this_class."\"><div>".$this_day."</div></td>");
596 659
 					}
597 660
 				}
@@ -610,7 +673,9 @@  discard block
 block discarded – undo
610 673
 				if($previous_year >= $year_start && $show_previous){
611 674
 				?><a href="javascript:move('<?php echo(str_pad($previous_month, 2, "0", STR_PAD_LEFT));?>', '<?php echo($previous_year);?>');"><img src="images/btn_<?php echo($rtl ? "next" : "previous"); ?>.gif" width="16" height="16" border="0" alt="Previous" title="Previous" /></a>
612 675
 				<?php
613
-				}else echo("&nbsp;");
676
+				} else {
677
+					echo("&nbsp;");
678
+				}
614 679
 				?>
615 680
 			</div>
616 681
 			<div style="float: <?php echo($rtl ? "left" : "right"); ?>;" class="btn">
@@ -618,18 +683,22 @@  discard block
 block discarded – undo
618 683
 				if($next_year <= $year_end && $show_next){
619 684
 				?><a href="javascript:move('<?php echo(str_pad($next_month, 2, "0", STR_PAD_LEFT));?>', '<?php echo($next_year);?>');"><img src="images/btn_<?php echo($rtl ? "previous" : "next"); ?>.gif" width="16" height="16" border="0" alt="Next" title="Next" /></a>
620 685
 				<?php
621
-				}else echo("&nbsp;");
686
+				} else {
687
+					echo("&nbsp;");
688
+				}
622 689
 				?>
623 690
 			</div>
624 691
 			<div class="links">
625 692
 				<?php
626 693
 				$footer_links = array();
627 694
 
628
-				if($cobj->validTodayDate() && ($m != $cdate->getDate('m') || $y != $cdate->getDate('Y')))
629
-					$footer_links[] = "<a href=\"javascript:today();\" class=\"txt\" alt=\"Today\" title=\"Today\">Today</a>";
695
+				if($cobj->validTodayDate() && ($m != $cdate->getDate('m') || $y != $cdate->getDate('Y'))) {
696
+									$footer_links[] = "<a href=\"javascript:today();\" class=\"txt\" alt=\"Today\" title=\"Today\">Today</a>";
697
+				}
630 698
 
631
-				if($sld>0 && $slm>0 && $sly>0)
632
-					$footer_links[] = "<a href=\"javascript:unsetValue();\" class=\"txt\" alt=\"Unset\" title=\"Unset\">Unset</a>";
699
+				if($sld>0 && $slm>0 && $sly>0) {
700
+									$footer_links[] = "<a href=\"javascript:unsetValue();\" class=\"txt\" alt=\"Unset\" title=\"Unset\">Unset</a>";
701
+				}
633 702
 
634 703
 				if(sizeof($footer_links)>0){
635 704
 					echo(implode(" | ", $footer_links));
Please login to merge, or discard this patch.
contrib/ipImap/getip.php 1 patch
Braces   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,9 +51,7 @@
 block discarded – undo
51 51
 		'db'	 => $db,
52 52
 		'dbport' => $dbport
53 53
 	);
54
-}
55
-
56
-else {
54
+} else {
57 55
 	$mysqlconf = NULL;
58 56
 	syslog(LOG_INFO, $conf['user'].': Report only, no listing activated in configuration.') ;
59 57
 }
Please login to merge, or discard this patch.
contrib/ipImap/function.php 1 patch
Braces   +107 added lines, -61 removed lines patch added patch discarded remove patch
@@ -10,21 +10,25 @@  discard block
 block discarded – undo
10 10
 	if ( preg_match_all('/^Received:\sfrom(?:.|\r\n\s)*?[\[\(]\s*(?P<ip>\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})[\]\)](?:.|\r\n\s)+\s+by(?:\s|\r\n\s+)(?P<host>\S+).*(?:\s|\r\n\s\s)+.*;\s+(?P<date>.*)/m',$header,$received) ) {
11 11
 		for ($i = count($received[0])-1;$i>=0;$i--) {
12 12
 #			print "Examine ".$received[0][$i]."\n";
13
-			if ( preg_match($msa,$received['host'][$i]) )
14
-				$dateR = $received['date'][$i];
13
+			if ( preg_match($msa,$received['host'][$i]) ) {
14
+							$dateR = $received['date'][$i];
15
+			}
15 16
         		foreach ($mxserver as $mx) {
16
-        			if (!$ip)
17
-					if ($mx == $received['host'][$i]) {
17
+        			if (!$ip) {
18
+        								if ($mx == $received['host'][$i]) {
18 19
 						$host = $received['host'][$i];
20
+        			}
19 21
 						$ip = $received['ip'][$i];
20 22
                     			}
21 23
                 	}
22 24
         	}
23 25
 	}
24
-	if ( preg_match ('/\r\nDate:\s(?P<date>.*)\r\n/',$header,$dateC) != 1)
25
-		$dateC['date'] = 'Not found';
26
-	if ( preg_match ('/\r\nMessage\-I(?:D|d):\s(?P<mid>.*)\r\n/',$header,$mid) != 1)
27
-		$mid['mid'] = NULL;
26
+	if ( preg_match ('/\r\nDate:\s(?P<date>.*)\r\n/',$header,$dateC) != 1) {
27
+			$dateC['date'] = 'Not found';
28
+	}
29
+	if ( preg_match ('/\r\nMessage\-I(?:D|d):\s(?P<mid>.*)\r\n/',$header,$mid) != 1) {
30
+			$mid['mid'] = NULL;
31
+	}
28 32
 	return array($ip,$host,$dateR,$dateC['date'],$mid['mid']);
29 33
 }
30 34
 
@@ -40,7 +44,9 @@  discard block
 block discarded – undo
40 44
 
41 45
 function summaryBadReport ($uidvet) {
42 46
         $nuid = $uidvet['count'];
43
-        if ( empty($uidvet) ) return NULL;
47
+        if ( empty($uidvet) ) {
48
+        	return NULL;
49
+        }
44 50
         $return = '<hr><h3>Statistics by UID</h3><table><tr><th>UID</th><th>Learned times</th></tr>'."\n";
45 51
 
46 52
         /* Remove count index */
@@ -75,8 +81,12 @@  discard block
 block discarded – undo
75 81
     foreach ($colarr as $col => $arr) {
76 82
         foreach ($arr as $k => $v) {
77 83
             $k = substr($k,1);
78
-            if (!isset($ret[$k])) $ret[$k] = $array[$k];
79
-            if (isset ($array[$k][$col])) $ret[$k][$col] = $array[$k][$col];
84
+            if (!isset($ret[$k])) {
85
+            	$ret[$k] = $array[$k];
86
+            }
87
+            if (isset ($array[$k][$col])) {
88
+            	$ret[$k][$col] = $array[$k][$col];
89
+            }
80 90
         }
81 91
     }
82 92
     return $ret;
@@ -87,13 +97,17 @@  discard block
 block discarded – undo
87 97
 function summaryReportAndList ($cf,$myconn,$tables,$category,$ipvet) {
88 98
 	$nips = $ipvet['count'];
89 99
 
90
-	if ( empty($ipvet) ) return NULL;
100
+	if ( empty($ipvet) ) {
101
+		return NULL;
102
+	}
91 103
 	$return = '<h3>Statistics by IP</h3><table><tr><th>IP</th><th>Learned by</th><th>Learned times</th><th title="This field doesn\'t say if this ip is currently listed, but it says if this IP has listed now!">Listed Now</th></tr>'."\n";
92 104
 	
93 105
 	$ips = array_keys($ipvet['ip']);
94 106
 
95 107
 	foreach ( $ips as $ip ) {
96
-		if ( $ip == 'count' ) continue;
108
+		if ( $ip == 'count' ) {
109
+			continue;
110
+		}
97 111
                 $nlearn = $ipvet['ip']["$ip"]['count'];
98 112
                 unset($ipvet['ip']["$ip"]['count']);
99 113
 		$quantity = $cf['quantity']["$category"]; /* In searchAndList this value is passed by reference and modified */
@@ -102,10 +116,12 @@  discard block
 block discarded – undo
102 116
 			if ( ($nlearn >= $cf['thresholdip']["$category"])&&($nuid >= $cf['thresholduid']["$category"]) ) {
103 117
 				$reason = "The IP <$ip> has been listed because was marked $nlearn times as $category by $nuid different accounts during last ".$cf['oldestday'].' days.';
104 118
 				$listed = searchAndList ($myconn,$cf['user'],$tables,$cf['list']["$category"],$ip,$cf['unit']["$category"],$quantity,$reason);
119
+			} else {
120
+				$listed = FALSE;
105 121
 			}
106
-			else $listed = FALSE;
122
+		} else {
123
+			$listed = FALSE;
107 124
 		}
108
-		else $listed = FALSE;
109 125
 		$nowlist = array( TRUE =>  array(
110 126
 					'style' => 'id=\'ipfound\'',
111 127
 					'name'  => 'YES',
@@ -123,7 +139,9 @@  discard block
 block discarded – undo
123 139
 		$return .='<tr><td rowspan="'.$nuid.'">'.$ip.'</td>';
124 140
 		$return .= sprintf ('<td>%s</td><td rowspan="'.$nuid.'">%u</td><td rowspan="'.$nuid.'" '.$nowlist["$listed"]['style'].'>%s</td></tr>',$ipvet['ip']["$ip"][0],$nlearn,$nowlist["$listed"]['name']);
125 141
 		$rowuid=NULL;
126
-                for ($j=1;$j<$nuid;$j++) $rowuid .= '<tr><td>%s</td></tr>';
142
+                for ($j=1;$j<$nuid;$j++) {
143
+                	$rowuid .= '<tr><td>%s</td></tr>';
144
+                }
127 145
 		array_shift($ipvet['ip']["$ip"]);
128 146
                 $return .= vsprintf ($rowuid,$ipvet['ip']["$ip"]);
129 147
 
@@ -136,14 +154,18 @@  discard block
 block discarded – undo
136 154
 	$return .= '<h3>Statistics by UID</h3><table><tr><th>UID</th><th>IP learned</th><th>Learned times</th></tr>'."\n";
137 155
 	$uids = array_keys($ipvet['uid']);
138 156
         foreach ( $uids as $uid ) {
139
-		if ( $uid == 'count' ) continue;	
157
+		if ( $uid == 'count' ) {
158
+			continue;
159
+		}
140 160
 	        $nlearn = $ipvet['uid']["$uid"]['count'];
141 161
 	        unset ( $ipvet['uid']["$uid"]['count'] );
142 162
 		$nip = count($ipvet['uid']["$uid"]);
143 163
 		$return .='<tr><td rowspan="'.$nip.'">'.$uid.'</td>';
144 164
 		$return .= sprintf ('<td>%s</td><td rowspan="'.$nip.'">%u</td></tr>',$ipvet['uid']["$uid"][0],$nlearn);
145 165
                 $rowuid=NULL;
146
-                for ($j=1;$j<$nip;$j++) $rowuid .= '<tr><td>%s</td></tr>';
166
+                for ($j=1;$j<$nip;$j++) {
167
+                	$rowuid .= '<tr><td>%s</td></tr>';
168
+                }
147 169
                 array_shift($ipvet['uid']["$uid"]);
148 170
                 $return .= vsprintf ($rowuid,$ipvet['uid']["$uid"]);
149 171
 
@@ -192,14 +214,14 @@  discard block
 block discarded – undo
192 214
 	    {
193 215
 	      // More than one field attribute returned by search
194 216
 	      // You must redefine the search
195
-	      if ( count($result->getFieldNames()) > 1 ) return FALSE;
196
-	    }
197
-	    else if ($result instanceof Splunk_ResultsMessage)
217
+	      if ( count($result->getFieldNames()) > 1 ) {
218
+	      	return FALSE;
219
+	      }
220
+	    } else if ($result instanceof Splunk_ResultsMessage)
198 221
 	    {
199 222
 	      // I don't want messages in my search
200 223
 	      return FALSE;
201
-	    }
202
-	    else if (is_array($result))
224
+	    } else if (is_array($result))
203 225
 	    {
204 226
 	      // Process a row
205 227
 	      foreach ($result as $key => $valueOrValues)
@@ -207,15 +229,13 @@  discard block
 block discarded – undo
207 229
 	         if (is_array($valueOrValues))
208 230
 	          {
209 231
 	            return FALSE;
210
-	          }
211
-	         else
232
+	          } else
212 233
 	          {
213 234
 	            return $valueOrValues;
214 235
 	            #print "  {$key} => {$value}\r\n";
215 236
 	          }
216 237
 	        }
217
-	    }
218
-	    else
238
+	    } else
219 239
 	    {
220 240
 	      #print "Unknow result type";
221 241
 	      return FALSE;
@@ -229,7 +249,9 @@  discard block
 block discarded – undo
229 249
 	$fileb= dirname(__FILE__) . '/' . $cf['badreportFile']["$type"];
230 250
 	$m_mail = imap_open('{'.$cf['mailhost'].':143/imap/novalidate-cert/authuser='.$cf['authuser'].'}'.$cf['folder']["$type"], $cf['account'],$cf['authpassword'], OP_READONLY)
231 251
         	or syslog (LOG_EMERG, $cf['user'].': Error in IMAP connection to <'.$cf['mailhost'].'>: ' . imap_last_error());
232
-	if ( !$m_mail ) exit(254);
252
+	if ( !$m_mail ) {
253
+		exit(254);
254
+	}
233 255
 		
234 256
 
235 257
 	syslog (LOG_INFO,$cf['user'].': Successfully connected to <'.$cf['mailhost'].">; Reading $type messages of last ".$cf['oldestday'].' days...');
@@ -242,20 +264,28 @@  discard block
 block discarded – undo
242 264
 	// Order results starting from newest message
243 265
 	if ( empty($m_search) ) {
244 266
 		syslog (LOG_INFO,$cf['user'].": No mail found in $type folder. No reports written for $type.");
245
-	        if ( $ierr = imap_errors() )
246
-	                foreach ( $ierr as $thiserr )
267
+	        if ( $ierr = imap_errors() ) {
268
+	        	                foreach ( $ierr as $thiserr )
247 269
 	                        syslog (LOG_ERR, $cf['user'].": IMAP Error: $thiserr");
248
-	        if ( $ierr = imap_alerts() )
249
-	                foreach ( $ierr as $thiserr )
270
+	        }
271
+	        if ( $ierr = imap_alerts() ) {
272
+	        	                foreach ( $ierr as $thiserr )
250 273
 	                        syslog (LOG_ALERT, $cf['user'].": IMAP Alert: $thiserr");
274
+	        }
251 275
 		imap_close( $m_mail );
252
-		if ( file_exists( $file ) ) unlink ($file);
253
-		if ( file_exists( $fileb ) ) unlink ($fileb);
276
+		if ( file_exists( $file ) ) {
277
+			unlink ($file);
278
+		}
279
+		if ( file_exists( $fileb ) ) {
280
+			unlink ($fileb);
281
+		}
254 282
 		return FALSE;
255 283
 	}
256 284
 	$nmes = count ($m_search);
257 285
 	syslog (LOG_INFO,$cf['user'].": Found $nmes mail in $type folder.");
258
-	if ($nmes>0) rsort($m_search);
286
+	if ($nmes>0) {
287
+		rsort($m_search);
288
+	}
259 289
 
260 290
 	// Create report file
261 291
 
@@ -264,7 +294,9 @@  discard block
 block discarded – undo
264 294
 	$lastup = "Last Update: " . date ("d F Y H:i", time());
265 295
 	fwrite( $fp, file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateHeader']) );
266 296
 	fwrite( $fp,"<h1> Report of IP sending $type</h1><h5>$lastup</h5><h2>Detailed Report</h2>" );
267
-	if ($cf['onlyReport']) fwrite( $fp,'<p>None of the below IP has been listed because listing is not active in configuration.</p>');
297
+	if ($cf['onlyReport']) {
298
+		fwrite( $fp,'<p>None of the below IP has been listed because listing is not active in configuration.</p>');
299
+	}
268 300
 	fwrite( $fp,'<table><tr><th title="taken from Received header" nowrap>Date of Learn</th><th title="taken from Date header" nowrap>Date of Write</th><th nowrap>UID</th><th nowrap>IP</th><th title="How many times this uid learns">#UID</th><th title="Number of times this learned IP appears in different mails">#IP</th><th nowrap>Received by</th><th>Message-Id</th></tr>' );
269 301
 	fwrite( $fpb,file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateHeader']) );
270 302
 	fwrite( $fpb,"<h1> Report of bad reported $type mails</h1><h5>$lastup</h5><h2>Detailed Report</h2>" );
@@ -310,10 +342,11 @@  discard block
 block discarded – undo
310 342
 
311 343
 	                if (in_array($uid,array_keys($ipuid['uid']))) {
312 344
 				$ipuid['uid']["$uid"]['count']++;		//number of learn by this uid
313
-				if (!in_array($ip,$ipuid['uid']["$uid"])) 
314
-					$ipuid['uid']["$uid"][]=$ip;		//ips learned by this uid
315
-			}
316
-			else {
345
+				if (!in_array($ip,$ipuid['uid']["$uid"])) {
346
+									$ipuid['uid']["$uid"][]=$ip;
347
+				}
348
+				//ips learned by this uid
349
+			} else {
317 350
 				$ipuid['uid']["$uid"]['count'] = 1;
318 351
 				$ipuid['uid']["$uid"][]=$ip;
319 352
 				$ipuid['uid']['count']++;                	//number of unique uids
@@ -321,10 +354,11 @@  discard block
 block discarded – undo
321 354
 
322 355
                         if (in_array($ip,array_keys($ipuid['ip']))) {
323 356
                                 $ipuid['ip']["$ip"]['count']++;			//number of time this ip appears in different messages
324
-				if (!in_array($uid,$ipuid['ip']["$ip"]))
325
-					$ipuid['ip']["$ip"][]=$uid;		//uids that learned this ip
326
-			}
327
-                        else {
357
+				if (!in_array($uid,$ipuid['ip']["$ip"])) {
358
+									$ipuid['ip']["$ip"][]=$uid;
359
+				}
360
+				//uids that learned this ip
361
+			} else {
328 362
                                 $ipuid['ip']["$ip"]['count'] = 1;
329 363
 				$ipuid['ip']["$ip"][]=$uid;
330 364
 				$ipuid['ip']['count']++;			//number of unique ips
@@ -332,21 +366,30 @@  discard block
 block discarded – undo
332 366
 
333 367
 	        	/* Update HTML report */
334 368
 	        	fwrite($fp,updateReport ( $ip,$uid,$ipuid['ip']["$ip"]['count'],$ipuid['uid']["$uid"]['count'],$host,$dateClient,$mid,$dateReceived) );
335
-		}
336
-	        else {	/* Bad learn */
369
+		} else {	/* Bad learn */
337 370
 			
338
-                        if (in_array($uid,array_keys($uidbad['uid']))) 
339
-                                $uidbad['uid']["$uid"]['count']++;               //number of bad learn by this uid
371
+                        if (in_array($uid,array_keys($uidbad['uid']))) {
372
+                                                        $uidbad['uid']["$uid"]['count']++;
373
+                        }
374
+                        //number of bad learn by this uid
340 375
                         else {
341 376
                                 $uidbad['uid']["$uid"]['count'] = 1;
342 377
 				$uidbad['uid']["$uid"][]=$uid;
343 378
                                 $uidbad['count']++;                       //numeber of unique bad uids
344 379
                         }
345 380
 			/* The reason of bad report */
346
-			if ($host === FALSE) $reason = 'This mail was not received by recognized MX host';
347
-			if ($dateReceived === FALSE) $reason = 'This mail was not submitted to recognized MSA for learn';
348
-			if ($uid=='unknown') $reason = 'The uid of this mail was not found in splunk log';
349
-			if (!isset($reason)) $reason = '?';
381
+			if ($host === FALSE) {
382
+				$reason = 'This mail was not received by recognized MX host';
383
+			}
384
+			if ($dateReceived === FALSE) {
385
+				$reason = 'This mail was not submitted to recognized MSA for learn';
386
+			}
387
+			if ($uid=='unknown') {
388
+				$reason = 'The uid of this mail was not found in splunk log';
389
+			}
390
+			if (!isset($reason)) {
391
+				$reason = '?';
392
+			}
350 393
 				
351 394
 			fwrite( $fpb,updatebadReport ( $uid,$dateClient,$mid,$dateReceived,$reason ) );
352 395
 		}
@@ -364,9 +407,9 @@  discard block
 block discarded – undo
364 407
 	fwrite($fp, '<hr><h2>Summary Report</h2><h5>Listing policy: ip must be learned at least '.$cf['thresholdip']["$type"].' times from at least '.$cf['thresholduid']["$type"].' different valid uids.</h5>' );
365 408
 
366 409
         /* Make MYSQL connection */
367
-	if ( $cf['onlyReport'] )
368
-		$mysqli = NULL;
369
-	else {
410
+	if ( $cf['onlyReport'] ) {
411
+			$mysqli = NULL;
412
+	} else {
370 413
         	$mysqli = new mysqli($myconnArray['dbhost'], $myconnArray['userdb'], $myconnArray['pwd'], $myconnArray['db'], $myconnArray['dbport']);
371 414
         	if ($mysqli->connect_error) {
372 415
                 	syslog (LOG_EMERG, $cf['user'].': Connect Error (' . $mysqli->connect_errno . ') '
@@ -378,8 +421,9 @@  discard block
 block discarded – undo
378 421
 	/***********************/
379 422
 
380 423
 	fwrite($fp, summaryReportAndList ($cf,$mysqli,$tables,$type,$ipuid) );
381
-	if ( !$cf['onlyReport'] )
382
-		$mysqli->close();
424
+	if ( !$cf['onlyReport'] ) {
425
+			$mysqli->close();
426
+	}
383 427
 	fwrite($fp,file_get_contents(dirname(__FILE__) . '/' . $cf['reportTemplateFooter']));
384 428
 	fclose($fp);
385 429
 
@@ -389,12 +433,14 @@  discard block
 block discarded – undo
389 433
 	fclose($fpb);
390 434
 	syslog (LOG_INFO,$cf['user'].': Report files written. Listing job for '.$type.' terminated.');
391 435
 
392
-	if ( $ierr = imap_errors() )
393
-		foreach ( $ierr as $thiserr )
436
+	if ( $ierr = imap_errors() ) {
437
+			foreach ( $ierr as $thiserr )
394 438
 			syslog (LOG_ERR, $cf['user'].": IMAP Error: $thiserr");
395
-	if ( $ierr = imap_alerts() )
396
-                foreach ( $ierr as $thiserr )
439
+	}
440
+	if ( $ierr = imap_alerts() ) {
441
+	                foreach ( $ierr as $thiserr )
397 442
                         syslog (LOG_ALERT, $cf['user'].": IMAP Alert: $thiserr");
443
+	}
398 444
 	imap_close($m_mail);
399 445
 }
400 446
 ?>
Please login to merge, or discard this patch.