Issues in test_coverpy.py (master) - Issues in master - fallenshell/coverpy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

tests/test_coverpy.py (8 issues)

Labels

Coding Style 8

Severity

Informational 8

import unittest
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
import coverpy
import httpretty
import os
import requests

class TestCoverpy(unittest.TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
	def setUp(self):
		self.coverpy = coverpy.CoverPy()
		# Set up paths...
		self.ok_computer = os.path.join(os.path.dirname(__file__), 'mocks/OKComputer.json')
		self.sugar = os.path.join(os.path.dirname(__file__), 'mocks/Maroon5Sugar.json')
		self.no_kind = os.path.join(os.path.dirname(__file__), 'mocks/SugarNoKindType.json')
		self.empty_response = os.path.join(os.path.dirname(__file__), 'mocks/SuchFakeAlbumPls.json')

	@httpretty.activate
	def test_get_cover_parse_album_result(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# OK Computer response
		httpretty.register_uri(httpretty.GET, 
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
					body=open(self.ok_computer).read(),
					content_type="application/json")

		# Request the content from the mock
		result = self.coverpy.get_cover("OK Computer")

		# Begin assertions
		self.assertEquals(result.name, "OK Computer")
		self.assertEquals(result.type, "album")

	@httpretty.activate
	def test_get_cover_parse_song_result(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# Maroon 5 Sugar Response
		httpretty.register_uri(httpretty.GET, 
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Sugar Maroon 5&media=music",
					body=open(self.sugar).read(),
					content_type="application/json")

		# Request the content from the mock
		result = self.coverpy.get_cover("Sugar Maroon 5")

		# Begin assertions
		self.assertEquals(result.name, "Sugar")
		self.assertEquals(result.type, "song")

	@httpretty.activate
	def test_get_cover_no_results(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# No results response
		httpretty.register_uri(httpretty.GET,
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Such+Fake+Album+Pls&media=music",
					body=open(self.empty_response).read(),
					content_type="application/json")

		# Assert a NoResultsException
		with self.assertRaises(coverpy.exceptions.NoResultsException):
			self.coverpy.get_cover("Such Fake Album Pls")

	@httpretty.activate
	def test_get_cover_unknown_kind(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# No results response
		httpretty.register_uri(httpretty.GET,
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Sugar&media=music",
					body=open(self.no_kind).read(),
					content_type="application/json")

		# Assert if type is returned unknown
		result = self.coverpy.get_cover("Sugar")
		self.assertEquals(result.type, 'unknown')

	@httpretty.activate
	def test_for_http_status(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# Test for a 500 Internal Server Error
		httpretty.register_uri(httpretty.GET, 
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
					body="501 Internal Server Error",
					status=500)

		with self.assertRaises(requests.exceptions.HTTPError):
			self.coverpy.get_cover("OK Computer")
		
	@httpretty.activate
	def test_result_artwork_generator(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
		# OK Computer response
		httpretty.register_uri(httpretty.GET, 
					"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
					body=open(self.ok_computer).read(),
					content_type="application/json")

		# Request the content from the mock
		result = self.coverpy.get_cover("OK Computer")

		# Begin assertions
		self.assertTrue("600x600" in result.artwork(600))

if __name__ == '__main__':
    unittest.main()

1			import unittest
			0 ignored issues – show Coding Style introduced 2016-05-22 04:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			import coverpy
3			import httpretty
4			import os
5			import requests
6
7			class TestCoverpy(unittest.TestCase):
			0 ignored issues – show Coding Style introduced 2016-05-22 04:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
8			def setUp(self):
9			self.coverpy = coverpy.CoverPy()
10			# Set up paths...
11			self.ok_computer = os.path.join(os.path.dirname(__file__), 'mocks/OKComputer.json')
12			self.sugar = os.path.join(os.path.dirname(__file__), 'mocks/Maroon5Sugar.json')
13			self.no_kind = os.path.join(os.path.dirname(__file__), 'mocks/SugarNoKindType.json')
14			self.empty_response = os.path.join(os.path.dirname(__file__), 'mocks/SuchFakeAlbumPls.json')
15
16			@httpretty.activate
17			def test_get_cover_parse_album_result(self):
			0 ignored issues – show Coding Style introduced 2016-05-24 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
18			# OK Computer response
19			httpretty.register_uri(httpretty.GET,
20			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
21			body=open(self.ok_computer).read(),
22			content_type="application/json")
23
24			# Request the content from the mock
25			result = self.coverpy.get_cover("OK Computer")
26
27			# Begin assertions
28			self.assertEquals(result.name, "OK Computer")
29			self.assertEquals(result.type, "album")
30
31			@httpretty.activate
32			def test_get_cover_parse_song_result(self):
			0 ignored issues – show Coding Style introduced 2016-05-22 04:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
33			# Maroon 5 Sugar Response
34			httpretty.register_uri(httpretty.GET,
35			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Sugar Maroon 5&media=music",
36			body=open(self.sugar).read(),
37			content_type="application/json")
38
39			# Request the content from the mock
40			result = self.coverpy.get_cover("Sugar Maroon 5")
41
42			# Begin assertions
43			self.assertEquals(result.name, "Sugar")
44			self.assertEquals(result.type, "song")
45
46			@httpretty.activate
47			def test_get_cover_no_results(self):
			0 ignored issues – show Coding Style introduced 2016-05-22 04:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
48			# No results response
49			httpretty.register_uri(httpretty.GET,
50			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Such+Fake+Album+Pls&media=music",
51			body=open(self.empty_response).read(),
52			content_type="application/json")
53
54			# Assert a NoResultsException
55			with self.assertRaises(coverpy.exceptions.NoResultsException):
56			self.coverpy.get_cover("Such Fake Album Pls")
57
58			@httpretty.activate
59			def test_get_cover_unknown_kind(self):
			0 ignored issues – show Coding Style introduced 2016-05-24 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
60			# No results response
61			httpretty.register_uri(httpretty.GET,
62			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=Sugar&media=music",
63			body=open(self.no_kind).read(),
64			content_type="application/json")
65
66			# Assert if type is returned unknown
67			result = self.coverpy.get_cover("Sugar")
68			self.assertEquals(result.type, 'unknown')
69
70			@httpretty.activate
71			def test_for_http_status(self):
			0 ignored issues – show Coding Style introduced 2016-05-24 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
72			# Test for a 500 Internal Server Error
73			httpretty.register_uri(httpretty.GET,
74			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
75			body="501 Internal Server Error",
76			status=500)
77
78			with self.assertRaises(requests.exceptions.HTTPError):
79			self.coverpy.get_cover("OK Computer")
80
81			@httpretty.activate
82			def test_result_artwork_generator(self):
			0 ignored issues – show Coding Style introduced 2016-05-24 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
83			# OK Computer response
84			httpretty.register_uri(httpretty.GET,
85			"https://itunes.apple.com/search/?limit=1&entity=musicArtist%2CmusicTrack%2Calbum%2Cmix%2Csong&term=OK+Computer&media=music",
86			body=open(self.ok_computer).read(),
87			content_type="application/json")
88
89			# Request the content from the mock
90			result = self.coverpy.get_cover("OK Computer")
91
92			# Begin assertions
93			self.assertTrue("600x600" in result.artwork(600))
94
95			if __name__ == '__main__':
96			unittest.main()

fallenshell / coverpy

Issues (15)

tests/test_coverpy.py (8 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like