Result.parse() - Code Metrics - Inspection of "Merge pull request #9 from fallenshell/develop" - fallenshell/coverpy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d6d5e...d8fb8a )

by Sergio

created 2016-05-24 20:32 UTC

Result.parse() D

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	27
rs	4
cc	8

import os
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
import requests
from . import exceptions

class Result:
	""" Parse an API result into an object format. """

	def __init__(self, item):
		""" Call the list parser. """
		self.parse(item)

	def parse(self, item):
		""" Parse the given list into self variables. """
		self.artworkThumb = item['artworkUrl100']
		self.artist = item['artistName']
		self.album = item['collectionName']
		self.url = item['url']

		# Take some measures to detect whether it is a song or album
		if 'kind' in item:
			self.type = item['kind'].lower()
		elif 'wrapperType' in item:
			if item['wrapperType'].lower() == 'track':
				self.type = 'song'
			elif item['wrapperType'].lower() == 'collection':
				self.type = 'album'
		elif 'collectionType' in item:
			self.type = 'album'
		else:
			# Assuming edge case of the API
			self.type = 'unknown'

		if self.type == 'song':
			self.name = item['trackName']
		elif self.type == 'album':
			self.name = item['collectionName']
		else:
			self.name = 'unknown'

	def artwork(self, size = 625):
		""" Return the artwork to the thumb URL contained. """
		# Replace size because API doesn't hand links to full res. It only gives 60x60 and 100x100.
		# However, I found a way to circumvent it.
		return self.artworkThumb.replace('100x100bb', "%sx%s" % (size, size))

class CoverPy: 
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
	def __init__(self):
		""" Initialize CoverPy. Set a base_url. """
		self.base_url = "https://itunes.apple.com/search/"

	def _get(self, payload, override = False, entities = False):

		""" Get a payload using the base_url. General purpose GET interface """
		if override:
			data = requests.get("%s%s" % (self.base_url, override))
		else:
			payload['entity'] = "musicArtist,musicTrack,album,mix,song"
			payload['media'] = 'music'
			data = requests.get(self.base_url, params = payload)

		if data.status_code != 200:
			raise requests.HTTPError
		else:
			return data

	def _search(self, term, limit = 1):
		""" Expose a friendlier internal API for executing searches """
		payload = {
			'term': term,
			'limit': limit
		}

		req = self._get(payload)
		return req

	def get_cover(self, term, limit = 1, debug = False):

		""" Get an album cover, return a Result object """
		search = self._search(term, limit)
		parsed = search.json()

		if parsed['resultCount'] == 0:
			raise exceptions.NoResultsException

		result = parsed['results'][0]
		result['url'] = search.url

		return Result(result)


1			import os
			0 ignored issues – show Coding Style introduced 2016-05-22 01:25 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2016-05-22 01:25 UTC by Report Bug Copy Issue Report The import `os` seems to be unused. Loading history...
2			import requests
3			from . import exceptions
4
5			class Result:
6			""" Parse an API result into an object format. """
7
8			def __init__(self, item):
9			""" Call the list parser. """
10			self.parse(item)
11
12			def parse(self, item):
13			""" Parse the given list into self variables. """
14			self.artworkThumb = item['artworkUrl100']
15			self.artist = item['artistName']
16			self.album = item['collectionName']
17			self.url = item['url']
18
19			# Take some measures to detect whether it is a song or album
20			if 'kind' in item:
21			self.type = item['kind'].lower()
22			elif 'wrapperType' in item:
23			if item['wrapperType'].lower() == 'track':
24			self.type = 'song'
25			elif item['wrapperType'].lower() == 'collection':
26			self.type = 'album'
27			elif 'collectionType' in item:
28			self.type = 'album'
29			else:
30			# Assuming edge case of the API
31			self.type = 'unknown'
32
33			if self.type == 'song':
34			self.name = item['trackName']
35			elif self.type == 'album':
36			self.name = item['collectionName']
37			else:
38			self.name = 'unknown'
39
40			def artwork(self, size = 625):
41			""" Return the artwork to the thumb URL contained. """
42			# Replace size because API doesn't hand links to full res. It only gives 60x60 and 100x100.
43			# However, I found a way to circumvent it.
44			return self.artworkThumb.replace('100x100bb', "%sx%s" % (size, size))
45
46			class CoverPy:
			0 ignored issues – show Coding Style introduced 2016-05-22 01:25 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
47			def __init__(self):
48			""" Initialize CoverPy. Set a base_url. """
49			self.base_url = "https://itunes.apple.com/search/"
50
51			def _get(self, payload, override = False, entities = False):
			0 ignored issues – show Unused Code introduced 2016-05-22 01:25 UTC by Report Bug Copy Issue Report The argument `entities` seems to be unused. Loading history...
52			""" Get a payload using the base_url. General purpose GET interface """
53			if override:
54			data = requests.get("%s%s" % (self.base_url, override))
55			else:
56			payload['entity'] = "musicArtist,musicTrack,album,mix,song"
57			payload['media'] = 'music'
58			data = requests.get(self.base_url, params = payload)
59
60			if data.status_code != 200:
61			raise requests.HTTPError
62			else:
63			return data
64
65			def _search(self, term, limit = 1):
66			""" Expose a friendlier internal API for executing searches """
67			payload = {
68			'term': term,
69			'limit': limit
70			}
71
72			req = self._get(payload)
73			return req
74
75			def get_cover(self, term, limit = 1, debug = False):
			0 ignored issues – show Unused Code introduced 2016-05-22 01:25 UTC by Report Bug Copy Issue Report The argument `debug` seems to be unused. Loading history...
76			""" Get an album cover, return a Result object """
77			search = self._search(term, limit)
78			parsed = search.json()
79
80			if parsed['resultCount'] == 0:
81			raise exceptions.NoResultsException
82
83			result = parsed['results'][0]
84			result['url'] = search.url
85
86			return Result(result)
87

fallenshell / coverpy

Push — master ( 1d6d5e...d8fb8a )

Result.parse() D

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like