UpdateRequest::getPremiumPlusRules() - Code Metrics - faithgen/testimonies - Measure and Improve Code Quality continuously with Scrutinizer

UpdateRequest::getPremiumPlusRules() A
last analyzed 2020-06-25 10:55 UTC

↳ Parent: UpdateRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Faithgen\Testimonies\Http\Requests;

use Faithgen\Testimonies\Services\TestimoniesService;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class UpdateRequest extends FormRequest
{
    private $primaryRules = [
        'title'     => 'required|string',
        'testimony' => 'required|string',
    ];

    /**
     * Used for an ministry at PremiumPlus subscription.
     *
     * @return array
     */
    private function getPremiumPlusRules(): array
    {
        return array_merge($this->primaryRules, [
            'resource' => 'url',
        ]);
    }

    /**
     * Determine if the user is authorized to make this request.
     *
     * @param \Faithgen\Testimonies\Services\TestimoniesService $testimoniesService
     *
     * @return bool
     */
    public function authorize(TestimoniesService $testimoniesService)
    {
        return $this->user()->can('update', $testimoniesService->getTestimony());
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()

    {
        $subscriptionLevel = auth()->user()->account->level;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($subscriptionLevel === 'PremiumPlus') {
            return $this->getPremiumRules();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        return $this->primaryRules;
    }

    public function failedAuthorization()
    {
        throw new AuthorizationException('You are not allowed to update this testimony');
    }
}


1		<?php
2
3		namespace Faithgen\Testimonies\Http\Requests;
4
5		use Faithgen\Testimonies\Services\TestimoniesService;
6		use Illuminate\Auth\Access\AuthorizationException;
7		use Illuminate\Foundation\Http\FormRequest;
8
9		class UpdateRequest extends FormRequest
10		{
11		private $primaryRules = [
12		'title' => 'required\|string',
13		'testimony' => 'required\|string',
14		];
15
16		/**
17		* Used for an ministry at PremiumPlus subscription.
18		*
19		* @return array
20		*/
21		private function getPremiumPlusRules(): array
22		{
23		return array_merge($this->primaryRules, [
24		'resource' => 'url',
25		]);
26		}
27
28		/**
29		* Determine if the user is authorized to make this request.
30		*
31		* @param \Faithgen\Testimonies\Services\TestimoniesService $testimoniesService
32		*
33		* @return bool
34		*/
35		public function authorize(TestimoniesService $testimoniesService)
36		{
37		return $this->user()->can('update', $testimoniesService->getTestimony());
38		}
39
40		/**
41		* Get the validation rules that apply to the request.
42		*
43		* @return array
44		*/
45	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$subscriptionLevel = auth()->user()->account->level;
		0 ignored issues – show Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48		if ($subscriptionLevel === 'PremiumPlus') {
49		return $this->getPremiumRules();
		0 ignored issues – show Documentation Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The method `getPremiumRules` does not exist on `object<Faithgen\Testimon...Requests\UpdateRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
50		}
51
52		return $this->primaryRules;
53		}
54
55		public function failedAuthorization()
56		{
57		throw new AuthorizationException('You are not allowed to update this testimony');
58		}
59		}
60

faithgen / testimonies

UpdateRequest::getPremiumPlusRules() A last analyzed 2020-06-25 10:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

UpdateRequest::getPremiumPlusRules() A
last analyzed 2020-06-25 10:55 UTC