Testimony - Code Metrics - faithgen/testimonies - Measure and Improve Code Quality continuously with Scrutinizer

Testimony A
last analyzed 2020-06-25 10:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

Metric	Value
wmc	9
lcom	0
cbo	7
dl	0
loc	42
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	filesDir()	4	1
A	getFileName()	6	1
B	scopeApproved()	18	7

<?php

namespace Faithgen\Testimonies\Models;

use FaithGen\SDK\Models\User;
use FaithGen\SDK\Models\UuidModel;
use FaithGen\SDK\Traits\Relationships\Belongs\BelongsToMinistryTrait;
use FaithGen\SDK\Traits\Relationships\Belongs\BelongsToUserTrait;
use FaithGen\SDK\Traits\Relationships\Morphs\CommentableTrait;
use FaithGen\SDK\Traits\Relationships\Morphs\ImageableTrait;
use FaithGen\SDK\Traits\StorageTrait;
use FaithGen\SDK\Traits\TitleTrait;

final class Testimony extends UuidModel
{
    use BelongsToMinistryTrait;
    use BelongsToUserTrait;
    use TitleTrait;
    use CommentableTrait;
    use ImageableTrait;
    use StorageTrait;

    protected $table = 'fg_testimonies';

    public function filesDir()
    {
        return 'testimonies';
    }

    public function getFileName(): array
    {
        return $this->images()
            ->pluck('name')
            ->toArray();
    }

    public function scopeApproved($query, User $user = null)
    {
        $authedUser = auth('web')->user();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if ($user === null || $authedUser === null) {
            $isOwner = false;
        }

        if ($authedUser && $authedUser->id === $user->id) {
            $isOwner = true;
        }

        if (config('faithgen-sdk.source') || $isOwner) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            return $query;
        }

        return $query->whereApproved(true);
    }
}


1			<?php
2
3			namespace Faithgen\Testimonies\Models;
4
5			use FaithGen\SDK\Models\User;
6			use FaithGen\SDK\Models\UuidModel;
7			use FaithGen\SDK\Traits\Relationships\Belongs\BelongsToMinistryTrait;
8			use FaithGen\SDK\Traits\Relationships\Belongs\BelongsToUserTrait;
9			use FaithGen\SDK\Traits\Relationships\Morphs\CommentableTrait;
10			use FaithGen\SDK\Traits\Relationships\Morphs\ImageableTrait;
11			use FaithGen\SDK\Traits\StorageTrait;
12			use FaithGen\SDK\Traits\TitleTrait;
13
14			final class Testimony extends UuidModel
15			{
16			use BelongsToMinistryTrait;
17			use BelongsToUserTrait;
18			use TitleTrait;
19			use CommentableTrait;
20			use ImageableTrait;
21			use StorageTrait;
22
23			protected $table = 'fg_testimonies';
24
25			public function filesDir()
26			{
27			return 'testimonies';
28			}
29
30			public function getFileName(): array
31			{
32			return $this->images()
33			->pluck('name')
34			->toArray();
35			}
36
37			public function scopeApproved($query, User $user = null)
38			{
39			$authedUser = auth('web')->user();
			0 ignored issues – show Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40
41			if ($user === null \|\| $authedUser === null) {
42			$isOwner = false;
43			}
44
45			if ($authedUser && $authedUser->id === $user->id) {
46			$isOwner = true;
47			}
48
49			if (config('faithgen-sdk.source') \|\| $isOwner) {
			0 ignored issues – show Bug introduced 2020-04-13 08:39 UTC by Report Bug Copy Issue Report The variable `$isOwner` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
50			return $query;
51			}
52
53			return $query->whereApproved(true);
54			}
55			}
56

faithgen / testimonies

Testimony A last analyzed 2020-06-25 10:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Testimony A
last analyzed 2020-06-25 10:55 UTC