faithgen / sermons

src/Observers/SermonObserver.php

<?php

namespace FaithGen\Sermons\Observers;

use FaithGen\SDK\Traits\FileTraits;
use FaithGen\Sermons\Jobs\MessageFollowers;
use FaithGen\Sermons\Jobs\ProcessImage;
use FaithGen\Sermons\Jobs\S3Upload;
use FaithGen\Sermons\Jobs\UploadImage;
use FaithGen\Sermons\Models\Sermon;

class SermonObserver
{
    use FileTraits;

    /**
     * Handle the sermon "created" event.
     *
     * @param Sermon $sermon
     * @return void
     */
    public function created(Sermon $sermon)
    {
        MessageFollowers::withChain([
            new UploadImage($sermon, request('image')),

It seems like request('image') can also be of type array; however, parameter $image of FaithGen\Sermons\Jobs\UploadImage::__construct() does only seem to accept string, maybe add an additional type check?

            new ProcessImage($sermon),
            new S3Upload($sermon),
        ])->dispatch($sermon);
    }

    /**
     * Handle the sermon "updated" event.
     *
     * @param Sermon $sermon
     * @return void
     */
    public function updated(Sermon $sermon)

The parameter $sermon is not used and could be removed.

    {
        //
    }

    /**
     * Handle the sermon "deleted" event.
     *
     * @param Sermon $sermon
     * @return void
     */
    public function deleted(Sermon $sermon)
    {
        if ($sermon->image()->exists()) {
            $this->deleteFiles($sermon);
            $sermon->image()->delete();
        }
    }
}