S3Upload - Code Metrics - Inspection of "added save to s3" - faithgen/news - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 033792...9fc33c )

by Innocent

created 2020-05-05 10:27 UTC

S3Upload A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	4
dl	27
loc	27
rs	10
c	0
b	0
f	0

How to fix Duplicated Code

<?php

namespace FaithGen\News\Jobs;

use FaithGen\News\Models\News;
use FaithGen\SDK\Traits\SavesToAmazonS3;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Facades\Log;

class S3Upload implements ShouldQueue
{
    use Dispatchable,
        InteractsWithQueue,
        Queueable,
        SerializesModels,
        SavesToAmazonS3;

    public bool $deleteWhenMissingModels = true;

    protected News $article;

    /**
     * Create a new job instance.
     *
     * @param News $article
     */
    public function __construct(News $article)
    {
        $this->article = $article;
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        try {
            $this->saveFiles($this->article);
        } catch (\Exception $e) {
            Log::error($e->getMessage());
        }
    }
}


1			<?php
2
3			namespace FaithGen\News\Jobs;
4
5			use FaithGen\News\Models\News;
6			use FaithGen\SDK\Traits\SavesToAmazonS3;
7			use Illuminate\Bus\Queueable;
8			use Illuminate\Contracts\Queue\ShouldQueue;
9			use Illuminate\Foundation\Bus\Dispatchable;
10			use Illuminate\Queue\InteractsWithQueue;
11			use Illuminate\Queue\SerializesModels;
12			use Illuminate\Support\Facades\Log;
13
14			class S3Upload implements ShouldQueue
15			{
16			use Dispatchable,
17			InteractsWithQueue,
18			Queueable,
19			SerializesModels,
20			SavesToAmazonS3;
21
22			public bool $deleteWhenMissingModels = true;
			0 ignored issues – show Bug introduced 2020-05-05 10:28 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
23			protected News $article;
24
25			/**
26			* Create a new job instance.
27			*
28			* @param News $article
29			*/
30			public function __construct(News $article)
31			{
32			$this->article = $article;
33			}
34
35			/**
36			* Execute the job.
37			*
38			* @return void
39			*/
40			public function handle()
41			{
42			try {
43			$this->saveFiles($this->article);
44			} catch (\Exception $e) {
45			Log::error($e->getMessage());
46			}
47			}
48			}
49

faithgen / news

Push — master ( 033792...9fc33c )

S3Upload A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like