NewsService - Code Metrics - faithgen/news - Measure and Improve Code Quality continuously with Scrutinizer

NewsService A
last analyzed 2020-05-05 11:31 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	2
dl	0
loc	48
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	getNews()	4	1
A	getUnsetFields()	4	1
A	getModel()	4	1
A	getParentRelationship()	4	1

<?php

namespace FaithGen\News\Services;

use FaithGen\News\Models\News;
use FaithGen\SDK\Traits\FileTraits;
use InnoFlash\LaraStart\Services\CRUDServices;

class NewsService extends CRUDServices
{
    use FileTraits;
    /**
     * @var News
     */
    private $news;

    public function __construct(News $news)
    {
        if (request()->has('news_id')) {
            $this->news = News::findOrFail(request()->news_id);
        } else {
            $this->news = $news;
        }
    }

    /**
     * @return News
     */
    public function getNews(): News
    {
        return $this->news;
    }

    /**
     * This sets the attributes to be removed from the given set for updating or creating.
     * @return mixed
     */
    public function getUnsetFields()
    {
        return ['news_id', 'image'];
    }

    /**
     * This get the model value or class of the model in the service.
     * @return mixed
     */
    public function getModel()
    {
        return $this->getNews();
    }

    public function getParentRelationship()
    {
        return auth()->user()->news();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace FaithGen\News\Services;
4
5			use FaithGen\News\Models\News;
6			use FaithGen\SDK\Traits\FileTraits;
7			use InnoFlash\LaraStart\Services\CRUDServices;
8
9			class NewsService extends CRUDServices
10			{
11			use FileTraits;
12			/**
13			* @var News
14			*/
15			private $news;
16
17			public function __construct(News $news)
18			{
19			if (request()->has('news_id')) {
20			$this->news = News::findOrFail(request()->news_id);
21			} else {
22			$this->news = $news;
23			}
24			}
25
26			/**
27			* @return News
28			*/
29			public function getNews(): News
30			{
31			return $this->news;
32			}
33
34			/**
35			* This sets the attributes to be removed from the given set for updating or creating.
36			* @return mixed
37			*/
38			public function getUnsetFields()
39			{
40			return ['news_id', 'image'];
41			}
42
43			/**
44			* This get the model value or class of the model in the service.
45			* @return mixed
46			*/
47			public function getModel()
48			{
49			return $this->getNews();
50			}
51
52			public function getParentRelationship()
53			{
54			return auth()->user()->news();
			0 ignored issues – show Bug introduced 2020-04-13 09:01 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55			}
56			}
57

faithgen / news

NewsService A last analyzed 2020-05-05 11:31 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

NewsService A
last analyzed 2020-05-05 11:31 UTC