NewsPolicy - Code Metrics - faithgen/news - Measure and Improve Code Quality continuously with Scrutinizer

NewsPolicy A
last analyzed 2020-05-05 11:31 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	3
dl	0
loc	71
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	viewAny()	4	1
A	view()	4	1
A	create()	13	3
A	update()	4	1
A	delete()	4	1

<?php

namespace FaithGen\News\Policies;

use Carbon\Carbon;
use FaithGen\News\Helpers\NewsHelper;
use FaithGen\News\Models\News;
use FaithGen\SDK\Models\Ministry;
use Illuminate\Auth\Access\HandlesAuthorization;

class NewsPolicy
{
    use HandlesAuthorization;

    /**
     * Determine whether the user can view any news.
     *
     * @param \App\Models\Ministry $user
     * @return mixed
     */
    public function viewAny(Ministry $user)

    {
        //
    }

    /**
     * Determine whether the user can view the news.
     *
     * @param Ministry $user
     * @param News $news
     * @return mixed
     */
    public function view(Ministry $user, News $news)
    {
        return $user->id === $news->ministry_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Determine whether the user can create news.
     *
     * @param Ministry $user
     * @return mixed
     */
    public function create(Ministry $user)
    {
        if ($user->account->level !== 'Free') {
            return true;
        } else {
            $newsCount = News::where('ministry_id', $user->id)->whereBetween('created_at', [Carbon::now()->firstOfMonth(), Carbon::now()->lastOfMonth()])->count();
            if ($newsCount >= NewsHelper::$freeNewsCount) {
                return false;
            } else {
                return true;
            }
        }
    }

    /**
     * Determine whether the user can update the news.
     *
     * @param \App\Models\Ministry $user
     * @param News $news
     * @return mixed
     */
    public function update(Ministry $user, News $news)
    {
        return $user->id === $news->ministry_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Determine whether the user can delete the news.
     *
     * @param \App\Models\Ministry $user
     * @param News $news
     * @return mixed
     */
    public static function delete(Ministry $user, News $news)
    {
        return $user->id === $news->ministry_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace FaithGen\News\Policies;
4
5			use Carbon\Carbon;
6			use FaithGen\News\Helpers\NewsHelper;
7			use FaithGen\News\Models\News;
8			use FaithGen\SDK\Models\Ministry;
9			use Illuminate\Auth\Access\HandlesAuthorization;
10
11			class NewsPolicy
12			{
13			use HandlesAuthorization;
14
15			/**
16			* Determine whether the user can view any news.
17			*
18			* @param \App\Models\Ministry $user
19			* @return mixed
20			*/
21			public function viewAny(Ministry $user)
			0 ignored issues – show Unused Code introduced 2020-04-13 09:01 UTC by Report Bug Copy Issue Report The parameter `$user` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
22			{
23			//
24			}
25
26			/**
27			* Determine whether the user can view the news.
28			*
29			* @param Ministry $user
30			* @param News $news
31			* @return mixed
32			*/
33			public function view(Ministry $user, News $news)
34			{
35			return $user->id === $news->ministry_id;
			0 ignored issues – show Documentation introduced 2020-04-13 09:01 UTC by Report Bug Copy Issue Report The property `ministry_id` does not exist on `object<FaithGen\News\Models\News>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36			}
37
38			/**
39			* Determine whether the user can create news.
40			*
41			* @param Ministry $user
42			* @return mixed
43			*/
44			public function create(Ministry $user)
45			{
46			if ($user->account->level !== 'Free') {
47			return true;
48			} else {
49			$newsCount = News::where('ministry_id', $user->id)->whereBetween('created_at', [Carbon::now()->firstOfMonth(), Carbon::now()->lastOfMonth()])->count();
50			if ($newsCount >= NewsHelper::$freeNewsCount) {
51			return false;
52			} else {
53			return true;
54			}
55			}
56			}
57
58			/**
59			* Determine whether the user can update the news.
60			*
61			* @param \App\Models\Ministry $user
62			* @param News $news
63			* @return mixed
64			*/
65			public function update(Ministry $user, News $news)
66			{
67			return $user->id === $news->ministry_id;
			0 ignored issues – show Documentation introduced 2020-04-13 09:01 UTC by Report Bug Copy Issue Report The property `ministry_id` does not exist on `object<FaithGen\News\Models\News>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
68			}
69
70			/**
71			* Determine whether the user can delete the news.
72			*
73			* @param \App\Models\Ministry $user
74			* @param News $news
75			* @return mixed
76			*/
77			public static function delete(Ministry $user, News $news)
78			{
79			return $user->id === $news->ministry_id;
			0 ignored issues – show Documentation introduced 2020-04-13 09:01 UTC by Report Bug Copy Issue Report The property `ministry_id` does not exist on `object<FaithGen\News\Models\News>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
80			}
81			}
82

faithgen / news

NewsPolicy A last analyzed 2020-05-05 11:31 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

NewsPolicy A
last analyzed 2020-05-05 11:31 UTC