SubscriptionController::approveSubscription() - Code Metrics - Inspection of "updated php version:" - faithgen/miscellaneous - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c2d3c3...2d4925 )

by Innocent

created 2020-04-13 13:00 UTC

SubscriptionController::approveSubscription() A

↳ Parent: SubscriptionController

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	9
rs	10

<?php

namespace Faithgen\Miscellaneous\Http\Controllers;

use Faithgen\Miscellaneous\Http\Requests\SubscriptionCreateRequest;
use Faithgen\Miscellaneous\Models\Subscription;
use Faithgen\Miscellaneous\Services\SubscriptionService;
use Illuminate\Routing\Controller;

class SubscriptionController extends Controller
{
    /**
     * @var SubscriptionService
     */
    private SubscriptionService $subscriptionService;

    /**
     * SubscriptionController constructor.
     *
     * @param  SubscriptionService  $subscriptionService
     */
    public function __construct(SubscriptionService $subscriptionService)
    {
        $this->subscriptionService = $subscriptionService;
    }

    /**
     * Subscribes a user to FaithGen.
     *
     * @param  SubscriptionCreateRequest  $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function create(SubscriptionCreateRequest $request)
    {
        return $this->subscriptionService->create($request->validated(),
            'Subscription requested. Please check your email to confirm');
    }

    public function approveSubscription(Subscription $subscription, string $email)
    {
        if ($subscription->email === $email) {
            $subscription->confirmed = true;
            $subscription->save();

            return redirect()->away(config('miscellaneous.success-subscription-url').$email);
        } else {
            abort(422, 'Can not approve this subscription');
        }
    }
}


1			<?php
2
3			namespace Faithgen\Miscellaneous\Http\Controllers;
4
5			use Faithgen\Miscellaneous\Http\Requests\SubscriptionCreateRequest;
6			use Faithgen\Miscellaneous\Models\Subscription;
7			use Faithgen\Miscellaneous\Services\SubscriptionService;
8			use Illuminate\Routing\Controller;
9
10			class SubscriptionController extends Controller
11			{
12			/**
13			* @var SubscriptionService
14			*/
15			private SubscriptionService $subscriptionService;
16
17			/**
18			* SubscriptionController constructor.
19			*
20			* @param SubscriptionService $subscriptionService
21			*/
22			public function __construct(SubscriptionService $subscriptionService)
23			{
24			$this->subscriptionService = $subscriptionService;
25			}
26
27			/**
28			* Subscribes a user to FaithGen.
29			*
30			* @param SubscriptionCreateRequest $request
31			*
32			* @return \Illuminate\Http\JsonResponse
33			*/
34			public function create(SubscriptionCreateRequest $request)
35			{
36			return $this->subscriptionService->create($request->validated(),
37			'Subscription requested. Please check your email to confirm');
38			}
39
40			public function approveSubscription(Subscription $subscription, string $email)
41			{
42			if ($subscription->email === $email) {
43			$subscription->confirmed = true;
44			$subscription->save();
45
46			return redirect()->away(config('miscellaneous.success-subscription-url').$email);
47			} else {
48			abort(422, 'Can not approve this subscription');
49			}
50			}
51			}
52

faithgen / miscellaneous

Push — master ( c2d3c3...2d4925 )

SubscriptionController::approveSubscription() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like