faithgen / laravel-sdk

src/Traits/SavesToAmazonS3.php

<?php

namespace FaithGen\SDK\Traits;

use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Str;
use InvalidArgumentException;

trait SavesToAmazonS3
{
    use FileTraits;

    /**
     * Saves model images to Amazon s3.
     *
     * @param $model
     */
    protected function saveFiles($model)
    {
        if (! in_array(StorageTrait::class, class_uses($model))) {
            throw new InvalidArgumentException('The model you used does not use the Storage trait');
        }

        try {
            foreach ($model->images as $image) {
                $imageFiles = $this->getImages($model->filesDir(), $image->name, $model->getImageDimensions());

                foreach ($imageFiles as $imageFile) {
                    Storage::disk('s3')->put(Str::of($imageFile)->after('public/'), fopen($imageFile, 'r+'), 'public');

It seems like fopen($imageFile, 'r+') can also be of type false; however, parameter $contents of Illuminate\Filesystem\FilesystemAdapter::put() does only seem to accept resource|string, maybe add an additional type check?

                }
            }
            $this->deleteFiles($model);
        } catch (\Exception $e) {
            Log::error($e->getMessage());
        }
    }
}