faithgen / laravel-sdk

src/Helpers/CommentHelper.php

<?php

namespace FaithGen\SDK\Helpers;

use FaithGen\SDK\Http\Resources\Comment as CommentsResource;
use Illuminate\Http\Request;
use InnoFlash\LaraStart\Helper;

This use statement conflicts with another class in this namespace, FaithGen\SDK\Helpers\Helper. Consider defining an alias.

class CommentHelper
{
    /**
     * Creates a comment for the given model.
     *
     * @param $model
     * @param  Request  $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public static function createComment($model, Request $request)
    {
        try {
            if ($user = auth('web')->user()) {
                if ($user->active) {

Accessing active on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    $comment = $model->comments()->create([
                        'comment'        => $request->comment,
                        'creatable_id'   => auth('web')->user()->id,

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                        'creatable_type' => get_class(auth('web')->user()),
                    ]);
                } else {
                    abort(403, 'You are not permitted to comment on this');
                }
            } else {
                $comment = $model->comments()->create([
                    'comment'        => $request->comment,
                    'creatable_id'   => auth()->user()->id,
                    'creatable_type' => get_class(auth()->user()),
                ]);
            }

            return response()->json([
                'success' => true,
                'message' => 'Comment posted',
                'comment' => new CommentsResource($comment),

The variable $comment does not seem to be defined for all execution paths leading up to this point.

            ], 201);
        } catch (\Exception $e) {
            abort(500, $e->getMessage());
        }
    }

    /**
     * Gets the comments for the given model.
     *
     * @param $model
     * @param  Request  $request
     *
     * @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
     */
    public static function getComments($model, Request $request)
    {
        $comments = $model->comments()
            ->latest()
            ->with(['creatable.image'])
            ->paginate(Helper::getLimit($request));

        CommentsResource::wrap('comments');

        return CommentsResource::collection($comments);
    }
}