FaithGen\SDK\Http\Controllers\CommentController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	presenceRegister()	0	4	2
A	showTyping()	0	4	2

<?php

namespace FaithGen\SDK\Http\Controllers;

use FaithGen\SDK\Events\Commenter\TypingRegistered;
use FaithGen\SDK\Events\Commenter\UserPresent;
use FaithGen\SDK\Http\Requests\PresenceRegistryRequest;
use Illuminate\Routing\Controller;

class CommentController extends Controller
{
    /**
     * Shows other users when one is joining or leaving the discussion.
     *
     * @param  PresenceRegistryRequest  $request
     */
    public function presenceRegister(PresenceRegistryRequest $request)
    {
        if (! config('faithgen-sdk.source')) {
            event(new UserPresent(auth('web')->user(), $request->validated()));

It seems like auth('web')->user() can also be of type null; however, parameter $user of FaithGen\SDK\Events\Commenter\UserPresent::__construct() does only seem to accept FaithGen\SDK\Models\User, maybe add an additional type check?

        }
    }

    /**
     * Registers to other users when one is typing a comment.
     *
     * @param  PresenceRegistryRequest  $request
     */
    public function showTyping(PresenceRegistryRequest $request)
    {
        if (! config('faithgen-sdk.source')) {
            event(new TypingRegistered(auth('web')->user(), $request->validated()));

It seems like auth('web')->user() can also be of type null; however, parameter $user of FaithGen\SDK\Events\Commenter\TypingRegistered::__construct() does only seem to accept FaithGen\SDK\Models\User, maybe add an additional type check?

        }
    }
}