Issues in DiscussionPolicy.php (master) - Issues in master - faithgen/discussions - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Policies/DiscussionPolicy.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Faithgen\Discussions\Policies;

use Faithgen\Discussions\Models\Discussion;
use FaithGen\SDK\Models\Image;
use FaithGen\SDK\Models\Ministry;
use Illuminate\Auth\Access\HandlesAuthorization;

class DiscussionPolicy
{
    use HandlesAuthorization;

    private array $denominations = [

        'Free'        => 2,
        'Premium'     => 10000,
        'PremiumPlus' => 100000,
    ];

    /**
     * Decides whether a discussion has got to be created or not.
     *
     * @param  Ministry  $ministry
     *
     * @return bool
     */
    public function create(Ministry $ministry)
    {
        $canCreate = $ministry->ministryDiscussions()
                ->whereBetween('created_at', [now()->firstOfMonth(), now()->lastOfMonth()])
                ->count() <= $this->denominations[$ministry->account->level];

        if ($user = auth('web')->user()) {
            return $canCreate && $user->active;
        }

        return $canCreate;
    }

    /**
     * Authorizes viewing this discussion.
     *
     * @param  Ministry  $ministry
     * @param  Discussion  $discussion
     *
     * @return bool
     */
    public function view(Ministry $ministry, Discussion $discussion)
    {
        return $ministry->id === $discussion->ministry_id;
    }

    /**
     * Decides whether or not a discussion should be deleted.
     *
     * @param  Ministry  $ministry
     * @param  Discussion  $discussion
     *
     * @return bool
     */
    public function delete(Ministry $ministry, Discussion $discussion)
    {
        return $this->canTransact($ministry, $discussion);
    }

    /**
     * Decides whether or not to update this discussion.
     *
     * @param  Ministry  $ministry
     * @param  Discussion  $discussion
     *
     * @return bool
     */
    public function update(Ministry $ministry, Discussion $discussion)
    {
        return $this->canTransact($ministry, $discussion);
    }

    /**
     * Whether or not to delete an image away from a discussion.
     *
     * @param  Ministry  $ministry
     * @param  Discussion  $discussion
     * @param  Image  $image
     *
     * @return bool
     */
    public function deleteImage(Ministry $ministry, Discussion $discussion)
    {
        $image = request()->route('image');

        if ($user = auth('web')->user()) {
            return $ministry->id === $discussion->ministry_id
                && $image->imageable_id === $discussion->id
                && $discussion->discussable_id === $user->id;
        }

        return $ministry->id === $discussion->ministry_id
            && $image->imageable_id === $discussion->id
            && $discussion->discussable_id === $ministry->id;
    }

    /**
     * Checks whether or not to transact on the given discussion.
     *
     * @param  Ministry  $ministry
     * @param  Discussion  $discussion
     *
     * @return bool
     */
    private function canTransact(Ministry $ministry, Discussion $discussion)
    {
        if ($user = auth('web')->user()) {
            return $ministry->id === $discussion->ministry_id
                && auth('web')->user()->id === $discussion->discussable_id;
        }

        return $ministry->id === $discussion->ministry_id;
    }
}


1			<?php
2
3			namespace Faithgen\Discussions\Policies;
4
5			use Faithgen\Discussions\Models\Discussion;
6			use FaithGen\SDK\Models\Image;
7			use FaithGen\SDK\Models\Ministry;
8			use Illuminate\Auth\Access\HandlesAuthorization;
9
10			class DiscussionPolicy
11			{
12			use HandlesAuthorization;
13
14			private array $denominations = [
			0 ignored issues – show Bug introduced 2020-04-15 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ARRAY, expecting T_FUNCTION or T_CONST Loading history...
15			'Free' => 2,
16			'Premium' => 10000,
17			'PremiumPlus' => 100000,
18			];
19
20			/**
21			* Decides whether a discussion has got to be created or not.
22			*
23			* @param Ministry $ministry
24			*
25			* @return bool
26			*/
27			public function create(Ministry $ministry)
28			{
29			$canCreate = $ministry->ministryDiscussions()
30			->whereBetween('created_at', [now()->firstOfMonth(), now()->lastOfMonth()])
31			->count() <= $this->denominations[$ministry->account->level];
32
33			if ($user = auth('web')->user()) {
34			return $canCreate && $user->active;
35			}
36
37			return $canCreate;
38			}
39
40			/**
41			* Authorizes viewing this discussion.
42			*
43			* @param Ministry $ministry
44			* @param Discussion $discussion
45			*
46			* @return bool
47			*/
48			public function view(Ministry $ministry, Discussion $discussion)
49			{
50			return $ministry->id === $discussion->ministry_id;
51			}
52
53			/**
54			* Decides whether or not a discussion should be deleted.
55			*
56			* @param Ministry $ministry
57			* @param Discussion $discussion
58			*
59			* @return bool
60			*/
61			public function delete(Ministry $ministry, Discussion $discussion)
62			{
63			return $this->canTransact($ministry, $discussion);
64			}
65
66			/**
67			* Decides whether or not to update this discussion.
68			*
69			* @param Ministry $ministry
70			* @param Discussion $discussion
71			*
72			* @return bool
73			*/
74			public function update(Ministry $ministry, Discussion $discussion)
75			{
76			return $this->canTransact($ministry, $discussion);
77			}
78
79			/**
80			* Whether or not to delete an image away from a discussion.
81			*
82			* @param Ministry $ministry
83			* @param Discussion $discussion
84			* @param Image $image
85			*
86			* @return bool
87			*/
88			public function deleteImage(Ministry $ministry, Discussion $discussion)
89			{
90			$image = request()->route('image');
91
92			if ($user = auth('web')->user()) {
93			return $ministry->id === $discussion->ministry_id
94			&& $image->imageable_id === $discussion->id
95			&& $discussion->discussable_id === $user->id;
96			}
97
98			return $ministry->id === $discussion->ministry_id
99			&& $image->imageable_id === $discussion->id
100			&& $discussion->discussable_id === $ministry->id;
101			}
102
103			/**
104			* Checks whether or not to transact on the given discussion.
105			*
106			* @param Ministry $ministry
107			* @param Discussion $discussion
108			*
109			* @return bool
110			*/
111			private function canTransact(Ministry $ministry, Discussion $discussion)
112			{
113			if ($user = auth('web')->user()) {
114			return $ministry->id === $discussion->ministry_id
115			&& auth('web')->user()->id === $discussion->discussable_id;
116			}
117
118			return $ministry->id === $discussion->ministry_id;
119			}
120			}
121

faithgen / discussions

Issues (19)

Security Analysis no request data

src/Policies/DiscussionPolicy.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like