DeleteImageRequest - Code Metrics - Inspection of "availaed storage on all apis" - faithgen/discussions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8fcc32...ae3918 )

by Innocent

created 2020-04-15 15:53 UTC

DeleteImageRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	2
dl	0
loc	29
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	authorize()	4	1
A	rules()	6	1
A	failedAuthorization()	4	1

<?php

namespace Faithgen\Discussions\Http\Requests;

use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class DeleteImageRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return $this->user()->can('deleteImage', $this->discussion);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            //
        ];
    }

    public function failedAuthorization()
    {
        throw new AuthorizationException('You are not allowed to remove this image!');
    }
}


1			<?php
2
3			namespace Faithgen\Discussions\Http\Requests;
4
5			use Illuminate\Auth\Access\AuthorizationException;
6			use Illuminate\Foundation\Http\FormRequest;
7
8			class DeleteImageRequest extends FormRequest
9			{
10			/**
11			* Determine if the user is authorized to make this request.
12			*
13			* @return bool
14			*/
15			public function authorize()
16			{
17			return $this->user()->can('deleteImage', $this->discussion);
			0 ignored issues – show Documentation introduced 2020-04-15 15:54 UTC by Report Bug Copy Issue Report The property `discussion` does not exist on `object<Faithgen\Discussi...sts\DeleteImageRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
18			}
19
20			/**
21			* Get the validation rules that apply to the request.
22			*
23			* @return array
24			*/
25			public function rules()
26			{
27			return [
28			//
29			];
30			}
31
32			public function failedAuthorization()
33			{
34			throw new AuthorizationException('You are not allowed to remove this image!');
35			}
36			}
37

faithgen / discussions

Push — master ( 8fcc32...ae3918 )

DeleteImageRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like