CreateRequest::failedAuthorization() - Code Metrics - faithgen/discussions - Measure and Improve Code Quality continuously with Scrutinizer

CreateRequest::failedAuthorization() A
last analyzed 2020-08-22 06:01 UTC

↳ Parent: CreateRequest

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

namespace Faithgen\Discussions\Http\Requests;

use Faithgen\Discussions\Models\Discussion;
use Faithgen\Discussions\Traits\SavesDiscussion;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Foundation\Http\FormRequest;

class CreateRequest extends FormRequest
{
    use SavesDiscussion;

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return $this->user()->can('create', Discussion::class);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return array_merge([
            'title' => 'required|string',
        ], $this->getSaveRules());
    }

    public function failedAuthorization()
    {
        if ($user = auth('web')->user()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            if ($user->active) {
                $message = 'You cant post a discussion because either your ministry is out of tokens for this month';
            } else {
                $message = 'You are not allowed to posting anything on this app';
            }
        } else {
            $message = 'You are out of credit, consider upgrading your subscription to post more discussions';
        }

        throw new AuthorizationException($message);
    }
}


1			<?php
2
3			namespace Faithgen\Discussions\Http\Requests;
4
5			use Faithgen\Discussions\Models\Discussion;
6			use Faithgen\Discussions\Traits\SavesDiscussion;
7			use Illuminate\Auth\Access\AuthorizationException;
8			use Illuminate\Foundation\Http\FormRequest;
9
10			class CreateRequest extends FormRequest
11			{
12			use SavesDiscussion;
13
14			/**
15			* Determine if the user is authorized to make this request.
16			*
17			* @return bool
18			*/
19			public function authorize()
20			{
21			return $this->user()->can('create', Discussion::class);
22			}
23
24			/**
25			* Get the validation rules that apply to the request.
26			*
27			* @return array
28			*/
29			public function rules()
30			{
31			return array_merge([
32			'title' => 'required\|string',
33			], $this->getSaveRules());
34			}
35
36			public function failedAuthorization()
37			{
38			if ($user = auth('web')->user()) {
			0 ignored issues – show Bug introduced 2020-04-15 15:54 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39			if ($user->active) {
40			$message = 'You cant post a discussion because either your ministry is out of tokens for this month';
41			} else {
42			$message = 'You are not allowed to posting anything on this app';
43			}
44			} else {
45			$message = 'You are out of credit, consider upgrading your subscription to post more discussions';
46			}
47
48			throw new AuthorizationException($message);
49			}
50			}
51

faithgen / discussions

CreateRequest::failedAuthorization() A last analyzed 2020-08-22 06:01 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

CreateRequest::failedAuthorization() A
last analyzed 2020-08-22 06:01 UTC