Passed
Pull Request — master (#11)
by Pol
02:31
created

RpIdTokenIssuerMismatchTest::getTestId()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 1
nc 1
nop 0
dl 0
loc 3
rs 10
c 1
b 0
f 0
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Facile\OpenIDClient\ConformanceTest\RpTest\IdToken;
6
7
use PHPUnit\Framework\Assert;
8
use PHPUnit\Framework\AssertionFailedError;
9
use Facile\OpenIDClient\ConformanceTest\RpTest\AbstractRpTest;
10
use Facile\OpenIDClient\ConformanceTest\TestInfo;
11
use Facile\OpenIDClient\Service\AuthorizationService;
12
use function Facile\OpenIDClient\base64url_encode;
13
14
/**
15
 * Request an ID token and verify its 'iss' value.
16
 *
17
 * Identify the incorrect 'iss' value and reject the ID Token after doing ID Token validation.
18
 */
19
class RpIdTokenIssuerMismatchTest extends AbstractRpTest
20
{
21
22
    public function getTestId(): string
23
    {
24
        return 'rp-id_token-issuer-mismatch';
25
    }
26
27
    public function execute(TestInfo $testInfo): void
28
    {
29
        $client = $this->registerClient($testInfo);
30
31
        // Get authorization redirect uri
32
        $authorizationService = new AuthorizationService();
0 ignored issues
show
Bug introduced by
The call to Facile\OpenIDClient\Serv...nService::__construct() has too few arguments starting with tokenSetFactory. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

32
        $authorizationService = /** @scrutinizer ignore-call */ new AuthorizationService();

This check compares calls to functions or methods with their respective definitions. If the call has less arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
33
        $uri = $authorizationService->getAuthorizationUri($client, [
34
            'response_type' => $testInfo->getResponseType(),
35
            'nonce' => base64url_encode(\random_bytes(32)),
36
        ]);
37
38
        // Simulate a redirect and create the server request
39
        $serverRequest = $this->simulateAuthRedirect($uri);
40
41
        $params = $authorizationService->getCallbackParams($serverRequest, $client);
42
43
        try {
44
            $authorizationService->callback($client, $params);
45
            throw new AssertionFailedError('No assertion');
46
        } catch (\Throwable $e) {
47
            Assert::assertSame('Invalid token provided', $e->getMessage());
48
            Assert::assertRegExp('/Unknown issuer/', $e->getPrevious()->getMessage());
0 ignored issues
show
Deprecated Code introduced by
The function PHPUnit\Framework\Assert::assertRegExp() has been deprecated: https://github.com/sebastianbergmann/phpunit/issues/4086 ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

48
            /** @scrutinizer ignore-deprecated */ Assert::assertRegExp('/Unknown issuer/', $e->getPrevious()->getMessage());

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
49
        }
50
    }
51
}
52