Passed
Pull Request — master (#11)
by Pol
02:31
created

RpIdTokenBadCHashTest::execute()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 27
Code Lines 15

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 2
eloc 15
nc 2
nop 1
dl 0
loc 27
rs 9.7666
c 1
b 0
f 0
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Facile\OpenIDClient\ConformanceTest\RpTest\IdToken;
6
7
use PHPUnit\Framework\Assert;
8
use PHPUnit\Framework\AssertionFailedError;
9
use Facile\OpenIDClient\ConformanceTest\RpTest\AbstractRpTest;
10
use Facile\OpenIDClient\ConformanceTest\TestInfo;
11
use Facile\OpenIDClient\Session\AuthSession;
12
use Facile\OpenIDClient\Service\AuthorizationService;
13
use function Facile\OpenIDClient\base64url_encode;
14
15
/**
16
 * Retrieve Authorization Code and ID Token from the Authorization Endpoint, using Hybrid Flow.
17
 * Verify the c_hash value in the returned ID token. 'id_token_signed_response_alg' must NOT be 'none'
18
 *
19
 * Identify the incorrect 'c_hash' value and reject the ID Token after doing Authorization Code Validation.
20
 */
21
class RpIdTokenBadCHashTest extends AbstractRpTest
22
{
23
24
    public function getTestId(): string
25
    {
26
        return 'rp-id_token-bad-c_hash';
27
    }
28
29
    public function execute(TestInfo $testInfo): void
30
    {
31
        $client = $this->registerClient($testInfo);
32
33
        // Get authorization redirect uri
34
        $authorizationService = new AuthorizationService();
0 ignored issues
show
Bug introduced by
The call to Facile\OpenIDClient\Serv...nService::__construct() has too few arguments starting with tokenSetFactory. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

34
        $authorizationService = /** @scrutinizer ignore-call */ new AuthorizationService();

This check compares calls to functions or methods with their respective definitions. If the call has less arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
35
36
        $authSession = AuthSession::fromArray([
37
            'nonce' => base64url_encode(\random_bytes(32)),
38
        ]);
39
40
        $uri = $authorizationService->getAuthorizationUri($client, [
41
            'response_type' => $testInfo->getResponseType(),
42
            'nonce' => $authSession->getNonce(),
43
        ]);
44
45
        // Simulate a redirect and create the server request
46
        $serverRequest = $this->simulateAuthRedirect($uri);
47
48
        $params = $authorizationService->getCallbackParams($serverRequest, $client);
49
50
        try {
51
            $authorizationService->callback($client, $params, null, $authSession);
52
            throw new AssertionFailedError('No assertion');
53
        } catch (\Throwable $e) {
54
            Assert::assertSame('Invalid token provided', $e->getMessage());
55
            Assert::assertRegExp('/c_hash mismatch/', $e->getPrevious()->getMessage());
0 ignored issues
show
Deprecated Code introduced by
The function PHPUnit\Framework\Assert::assertRegExp() has been deprecated: https://github.com/sebastianbergmann/phpunit/issues/4086 ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

55
            /** @scrutinizer ignore-deprecated */ Assert::assertRegExp('/c_hash mismatch/', $e->getPrevious()->getMessage());

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
56
        }
57
    }
58
}
59