Facile\OpenIDClient\ConformanceTest\RpTest\NonceRequestParameter\RpNonceUnlessCodeFlowTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getTestId()	0	3	1
A	execute()	0	30	2

<?php

declare(strict_types=1);

namespace Facile\OpenIDClient\ConformanceTest\RpTest\NonceRequestParameter;

use PHPUnit\Framework\Assert;
use PHPUnit\Framework\AssertionFailedError;
use Facile\OpenIDClient\ConformanceTest\RpTest\AbstractRpTest;
use Facile\OpenIDClient\ConformanceTest\TestInfo;
use Facile\OpenIDClient\Exception\InvalidArgumentException;
use Facile\OpenIDClient\Session\AuthSession;
use Facile\OpenIDClient\Service\AuthorizationService;
use Facile\OpenIDClient\Service\UserInfoService;
use function Facile\OpenIDClient\base64url_encode;

/**
 * Always send a 'nonce' value as a request parameter while using implicit or hybrid flow.
 * Verify the 'nonce' value returned in the ID Token.
 *
 * An ID Token, either from the Authorization Endpoint or from the Token Endpoint, containing the same 'nonce' value
 * as passed in the authentication request when using hybrid flow or implicit flow.
 */
class RpNonceUnlessCodeFlowTest extends AbstractRpTest
{

    public function getTestId(): string
    {
        return 'rp-nonce-unless-code-flow';
    }

    public function execute(TestInfo $testInfo): void
    {
        $client = $this->registerClient($testInfo);

        $authorizationService = new AuthorizationService();

The call to Facile\OpenIDClient\Service\AuthorizationService::__construct() has too few arguments starting with tokenSetFactory.

        try {
            $authorizationService->getAuthorizationUri($client, [
                'response_type' => $testInfo->getResponseType(),
            ]);

            throw new AssertionFailedError('No assertion');
        } catch (InvalidArgumentException $e) {
            Assert::assertRegExp('/nonce MUST be provided for implicit and hybrid flows/', $e->getMessage());

The function PHPUnit\Framework\Assert::assertRegExp() has been deprecated: https://github.com/sebastianbergmann/phpunit/issues/4086

        }

        $nonce = base64url_encode(\random_bytes(32));
        $authSession = AuthSession::fromArray(['nonce' => $nonce]);

        $uri = $authorizationService->getAuthorizationUri($client, [
            'response_type' => $testInfo->getResponseType(),
            'nonce' => $nonce,
        ]);
        // Simulate a redirect and create the server request
        $serverRequest = $this->simulateAuthRedirect($uri);

        $params = $authorizationService->getCallbackParams($serverRequest, $client);
        $tokenSet = $authorizationService->callback($client, $params, null, $authSession);

The assignment to $tokenSet is dead and can be removed.

        Assert::assertTrue(true);
    }
}