LogPrinter - Code Metrics - Inspection of "Fix issue with warning generated by bad LogPrinter..." - facile-it/paraunit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 588d10...6487a1 )

by Alessandro

created 2017-01-26 16:35 UTC

LogPrinter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	305
Duplicated Lines	20.66 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

98.21%

Importance

Changes

Metric	Value
wmc	26
lcom	1
cbo	8
dl	63
loc	305
ccs	110
cts	112
cp	0.9821
rs	10
c	0
b	0
f	0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	addWarning()	12	12	1
A	addFailure()	12	12	1
A	addIncompleteTest()	12	12	1
A	addRiskyTest()	12	12	1
A	addSkippedTest()	12	12	1
B	startTestSuite()	3	25	4
A	endTestSuite()	0	6	1
A	startTest()	0	13	1
A	endTest()	0	6	2
A	writeCase()	0	20	4
A	getLogFilename()	0	6	1
A	getTestFilename()	0	6	1
A	getLogDirectory()	0	9	2
A	addError()	0	12	1
A	writeArray()	0	16	3

How to fix Duplicated Code

<?php

namespace Paraunit\Parser\JSON;

use Paraunit\Configuration\StaticOutputPath;

/**
 * This class comes from \PHPUnit_Util_Log_JSON.
 * It's copied and refactored here because it's deprecated in PHPUnit 5.7 and it will be dropped in PHPUnit 6
 *
 * Class LogPrinter
 * @package Paraunit\Parser\JSON
 */
class LogPrinter extends \PHPUnit_Util_Printer implements \PHPUnit_Framework_TestListener
{
    /** @var string */
    private $logDirectory;

    /** @var int */
    private $testSuiteLevel;

    /** @var string */
    private $currentTestSuiteName;

    /** @var string */
    private $currentTestName;

    /** @var bool */
    private $currentTestPass;

    /**
     * LogPrinter constructor.
     */
    public function __construct()
    {
        $this->logDirectory = null;
        $this->testSuiteLevel = 0;
    }

    /**
     * An error occurred.
     *
     * @param \PHPUnit_Framework_Test $test
     * @param \Exception              $e
     * @param float                   $time
     */
    public function addError(\PHPUnit_Framework_Test $test, \Exception $e, $time)
    {
        $this->writeCase(
            'error',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            \PHPUnit_Framework_TestFailure::exceptionToString($e),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * A warning occurred.
     *
     * @param \PHPUnit_Framework_Test    $test
     * @param \PHPUnit_Framework_Warning $e
     * @param float                      $time
     */
    public function addWarning(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_Warning $e, $time)

    {
        $this->writeCase(
            'warning',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            \PHPUnit_Framework_TestFailure::exceptionToString($e),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * A failure occurred.
     *
     * @param \PHPUnit_Framework_Test                 $test
     * @param \PHPUnit_Framework_AssertionFailedError $e
     * @param float                                   $time
     */
    public function addFailure(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_AssertionFailedError $e, $time)

    {
        $this->writeCase(
            'fail',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            \PHPUnit_Framework_TestFailure::exceptionToString($e),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * Incomplete test.
     *
     * @param \PHPUnit_Framework_Test $test
     * @param \Exception              $e
     * @param float                   $time
     */
    public function addIncompleteTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)

    {
        $this->writeCase(
            'error',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            'Incomplete Test: ' . $e->getMessage(),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * Risky test.
     *
     * @param \PHPUnit_Framework_Test $test
     * @param \Exception              $e
     * @param float                   $time
     */
    public function addRiskyTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)

    {
        $this->writeCase(
            'error',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            'Risky Test: ' . $e->getMessage(),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * Skipped test.
     *
     * @param \PHPUnit_Framework_Test $test
     * @param \Exception              $e
     * @param float                   $time
     */
    public function addSkippedTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)

    {
        $this->writeCase(
            'error',
            $time,
            \PHPUnit_Util_Filter::getFilteredStacktrace($e, false),

            'Skipped Test: ' . $e->getMessage(),
            $test
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->currentTestPass = false;
    }

    /**
     * A testsuite started.
     *
     * @param \PHPUnit_Framework_TestSuite $suite
     * @throws \RuntimeException
     */
    public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)
    {
        if ($this->testSuiteLevel === 0) {
            $logFilename = $this->getLogFilename($suite);

            $logDir = dirname($logFilename);
            if (! @mkdir($logDir, 0777, true) && !is_dir($logDir)) {

                throw new \RuntimeException('Cannot create folder for JSON logs');
            }

            $this->out = fopen($logFilename, 'wt');
        }

        $this->testSuiteLevel++;
        $this->currentTestSuiteName = $suite->getName();
        $this->currentTestName      = '';

        $this->writeArray(
            array(
                'event' => 'suiteStart',
                'suite' => $this->currentTestSuiteName,
                'tests' => count($suite)
            )
        );
    }

    /**
     * A testsuite ended.
     *
     * @param \PHPUnit_Framework_TestSuite $suite
     */
    public function endTestSuite(\PHPUnit_Framework_TestSuite $suite)
    {
        $this->testSuiteLevel--;
        $this->currentTestSuiteName = '';
        $this->currentTestName      = '';
    }

    /**
     * A test started.
     *
     * @param \PHPUnit_Framework_Test $test
     */
    public function startTest(\PHPUnit_Framework_Test $test)
    {
        $this->currentTestName = \PHPUnit_Util_Test::describe($test);
        $this->currentTestPass = true;

        $this->writeArray(
            array(
                'event' => 'testStart',
                'suite' => $this->currentTestSuiteName,
                'test'  => $this->currentTestName
            )
        );
    }

    /**
     * A test ended.
     *
     * @param \PHPUnit_Framework_Test $test
     * @param float                  $time
     */
    public function endTest(\PHPUnit_Framework_Test $test, $time)
    {
        if ($this->currentTestPass) {
            $this->writeCase('pass', $time, array(), '', $test);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    /**
     * @param string                           $status
     * @param float                            $time
     * @param array                            $trace
     * @param string                           $message
     * @param \PHPUnit_Framework_TestCase|null $test
     */
    protected function writeCase($status, $time, array $trace = array(), $message = '', $test = null)
    {
        $output = '';
        // take care of TestSuite producing error (e.g. by running into exception) as TestSuite doesn't have hasOutput
        if ($test !== null && method_exists($test, 'hasOutput') && $test->hasOutput()) {
            $output = $test->getActualOutput();
        }
        $this->writeArray(
            array(
                'event'   => 'test',
                'suite'   => $this->currentTestSuiteName,
                'test'    => $this->currentTestName,
                'status'  => $status,
                'time'    => $time,
                'trace'   => $trace,
                'message' => \PHPUnit_Util_String::convertToUtf8($message),
                'output'  => $output,
            )
        );
    }

    /**
     * @param array $buffer
     */
    public function writeArray($buffer)
    {
        array_walk_recursive($buffer, function (&$input) {
            if (is_string($input)) {
                $input = \PHPUnit_Util_String::convertToUtf8($input);
            }
        });

        $flags = 0;

        if (defined('JSON_PRETTY_PRINT')) {
            $flags |= JSON_PRETTY_PRINT;
        }

        $this->write(json_encode($buffer, $flags));
    }

    /**
     * @param \PHPUnit_Framework_TestSuite $suite
     * @return string
     */
    private function getLogFilename(\PHPUnit_Framework_TestSuite $suite)
    {
        $testFilename = $this->getTestFilename($suite);
        
        return $this->getLogDirectory() . md5($testFilename) . '.json.log';
    }

    /**
     * @param \PHPUnit_Framework_TestSuite $suite
     * @return string
     */
    private function getTestFilename(\PHPUnit_Framework_TestSuite $suite)
    {
        $reflection = new \ReflectionClass($suite->getName());
        
        return $reflection->getFileName();
    }

    /**
     * @return string
     */
    private function getLogDirectory()
    {
        $this->logDirectory = StaticOutputPath::getPath();
        if (substr($this->logDirectory, -1) !== DIRECTORY_SEPARATOR) {
            $this->logDirectory .= DIRECTORY_SEPARATOR;
        }

        return $this->logDirectory;
    }
}


1			<?php
2
3			namespace Paraunit\Parser\JSON;
4
5			use Paraunit\Configuration\StaticOutputPath;
6
7			/**
8			* This class comes from \PHPUnit_Util_Log_JSON.
9			* It's copied and refactored here because it's deprecated in PHPUnit 5.7 and it will be dropped in PHPUnit 6
10			*
11			* Class LogPrinter
12			* @package Paraunit\Parser\JSON
13			*/
14			class LogPrinter extends \PHPUnit_Util_Printer implements \PHPUnit_Framework_TestListener
15			{
16			/** @var string */
17			private $logDirectory;
18
19			/** @var int */
20			private $testSuiteLevel;
21
22			/** @var string */
23			private $currentTestSuiteName;
24
25			/** @var string */
26			private $currentTestName;
27
28			/** @var bool */
29			private $currentTestPass;
30
31			/**
32			* LogPrinter constructor.
33			*/
34	10		public function __construct()
35			{
36	10		$this->logDirectory = null;
37	10		$this->testSuiteLevel = 0;
38	10		}
39
40			/**
41			* An error occurred.
42			*
43			* @param \PHPUnit_Framework_Test $test
44			* @param \Exception $e
45			* @param float $time
46			*/
47	1		public function addError(\PHPUnit_Framework_Test $test, \Exception $e, $time)
48			{
49	1		$this->writeCase(
50	1		'error',
51			$time,
52	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
53	1		\PHPUnit_Framework_TestFailure::exceptionToString($e),
54			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			);
56
57	1		$this->currentTestPass = false;
58	1		}
59
60			/**
61			* A warning occurred.
62			*
63			* @param \PHPUnit_Framework_Test $test
64			* @param \PHPUnit_Framework_Warning $e
65			* @param float $time
66			*/
67	1	View Code Duplication	public function addWarning(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_Warning $e, $time)
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68			{
69	1		$this->writeCase(
70	1		'warning',
71			$time,
72	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
73	1		\PHPUnit_Framework_TestFailure::exceptionToString($e),
74			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75			);
76
77	1		$this->currentTestPass = false;
78	1		}
79
80			/**
81			* A failure occurred.
82			*
83			* @param \PHPUnit_Framework_Test $test
84			* @param \PHPUnit_Framework_AssertionFailedError $e
85			* @param float $time
86			*/
87	1	View Code Duplication	public function addFailure(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_AssertionFailedError $e, $time)
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88			{
89	1		$this->writeCase(
90	1		'fail',
91			$time,
92	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
93	1		\PHPUnit_Framework_TestFailure::exceptionToString($e),
94			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
95			);
96
97	1		$this->currentTestPass = false;
98	1		}
99
100			/**
101			* Incomplete test.
102			*
103			* @param \PHPUnit_Framework_Test $test
104			* @param \Exception $e
105			* @param float $time
106			*/
107	1	View Code Duplication	public function addIncompleteTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108			{
109	1		$this->writeCase(
110	1		'error',
111			$time,
112	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
113	1		'Incomplete Test: ' . $e->getMessage(),
114			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
115			);
116
117	1		$this->currentTestPass = false;
118	1		}
119
120			/**
121			* Risky test.
122			*
123			* @param \PHPUnit_Framework_Test $test
124			* @param \Exception $e
125			* @param float $time
126			*/
127	1	View Code Duplication	public function addRiskyTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128			{
129	1		$this->writeCase(
130	1		'error',
131			$time,
132	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
133	1		'Risky Test: ' . $e->getMessage(),
134			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
135			);
136
137	1		$this->currentTestPass = false;
138	1		}
139
140			/**
141			* Skipped test.
142			*
143			* @param \PHPUnit_Framework_Test $test
144			* @param \Exception $e
145			* @param float $time
146			*/
147	1	View Code Duplication	public function addSkippedTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148			{
149	1		$this->writeCase(
150	1		'error',
151			$time,
152	1		\PHPUnit_Util_Filter::getFilteredStacktrace($e, false),
			0 ignored issues – show Bug introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report It seems like `\PHPUnit_Util_Filter::ge...edStacktrace($e, false)` targeting `PHPUnit_Util_Filter::getFilteredStacktrace()` can also be of type `string`; however, `Paraunit\Parser\JSON\LogPrinter::writeCase()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
153	1		'Skipped Test: ' . $e->getMessage(),
154			$test
			0 ignored issues – show Documentation introduced 2017-01-21 23:17 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
155			);
156
157	1		$this->currentTestPass = false;
158	1		}
159
160			/**
161			* A testsuite started.
162			*
163			* @param \PHPUnit_Framework_TestSuite $suite
164			* @throws \RuntimeException
165			*/
166	9		public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)
167			{
168	9		if ($this->testSuiteLevel === 0) {
169	9		$logFilename = $this->getLogFilename($suite);
170
171	9		$logDir = dirname($logFilename);
172	9	View Code Duplication	if (! @mkdir($logDir, 0777, true) && !is_dir($logDir)) {
			0 ignored issues – show Duplication introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
173			throw new \RuntimeException('Cannot create folder for JSON logs');
174			}
175
176	9		$this->out = fopen($logFilename, 'wt');
177			}
178
179	9		$this->testSuiteLevel++;
180	9		$this->currentTestSuiteName = $suite->getName();
181	9		$this->currentTestName = '';
182
183	9		$this->writeArray(
184			array(
185	9		'event' => 'suiteStart',
186	9		'suite' => $this->currentTestSuiteName,
187	9		'tests' => count($suite)
188			)
189			);
190	9		}
191
192			/**
193			* A testsuite ended.
194			*
195			* @param \PHPUnit_Framework_TestSuite $suite
196			*/
197	1		public function endTestSuite(\PHPUnit_Framework_TestSuite $suite)
198			{
199	1		$this->testSuiteLevel--;
200	1		$this->currentTestSuiteName = '';
201	1		$this->currentTestName = '';
202	1		}
203
204			/**
205			* A test started.
206			*
207			* @param \PHPUnit_Framework_Test $test
208			*/
209	7		public function startTest(\PHPUnit_Framework_Test $test)
210			{
211	7		$this->currentTestName = \PHPUnit_Util_Test::describe($test);
212	7		$this->currentTestPass = true;
213
214	7		$this->writeArray(
215			array(
216	7		'event' => 'testStart',
217	7		'suite' => $this->currentTestSuiteName,
218	7		'test' => $this->currentTestName
219			)
220			);
221	7		}
222
223			/**
224			* A test ended.
225			*
226			* @param \PHPUnit_Framework_Test $test
227			* @param float $time
228			*/
229	1		public function endTest(\PHPUnit_Framework_Test $test, $time)
230			{
231	1		if ($this->currentTestPass) {
232	1		$this->writeCase('pass', $time, array(), '', $test);
			0 ignored issues – show Documentation introduced 2017-01-20 15:02 UTC by Report Bug Copy Issue Report `$test` is of type `object<PHPUnit_Framework_Test>`, but the function expects a `object<PHPUnit_Framework_TestCase>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
233			}
234	1		}
235
236			/**
237			* @param string $status
238			* @param float $time
239			* @param array $trace
240			* @param string $message
241			* @param \PHPUnit_Framework_TestCase\|null $test
242			*/
243	7		protected function writeCase($status, $time, array $trace = array(), $message = '', $test = null)
244			{
245	7		$output = '';
246			// take care of TestSuite producing error (e.g. by running into exception) as TestSuite doesn't have hasOutput
247	7		if ($test !== null && method_exists($test, 'hasOutput') && $test->hasOutput()) {
248			$output = $test->getActualOutput();
249			}
250	7		$this->writeArray(
251			array(
252	7		'event' => 'test',
253	7		'suite' => $this->currentTestSuiteName,
254	7		'test' => $this->currentTestName,
255	7		'status' => $status,
256	7		'time' => $time,
257	7		'trace' => $trace,
258	7		'message' => \PHPUnit_Util_String::convertToUtf8($message),
259	7		'output' => $output,
260			)
261			);
262	7		}
263
264			/**
265			* @param array $buffer
266			*/
267			public function writeArray($buffer)
268			{
269	9		array_walk_recursive($buffer, function (&$input) {
270	9		if (is_string($input)) {
271	9		$input = \PHPUnit_Util_String::convertToUtf8($input);
272			}
273	9		});
274
275	9		$flags = 0;
276
277	9		if (defined('JSON_PRETTY_PRINT')) {
278	9		$flags \|= JSON_PRETTY_PRINT;
279			}
280
281	9		$this->write(json_encode($buffer, $flags));
282	9		}
283
284			/**
285			* @param \PHPUnit_Framework_TestSuite $suite
286			* @return string
287			*/
288	10		private function getLogFilename(\PHPUnit_Framework_TestSuite $suite)
289			{
290	10		$testFilename = $this->getTestFilename($suite);
291
292	10		return $this->getLogDirectory() . md5($testFilename) . '.json.log';
293			}
294
295			/**
296			* @param \PHPUnit_Framework_TestSuite $suite
297			* @return string
298			*/
299	10		private function getTestFilename(\PHPUnit_Framework_TestSuite $suite)
300			{
301	10		$reflection = new \ReflectionClass($suite->getName());
302
303	10		return $reflection->getFileName();
304			}
305
306			/**
307			* @return string
308			*/
309	10		private function getLogDirectory()
310			{
311	10		$this->logDirectory = StaticOutputPath::getPath();
312	10		if (substr($this->logDirectory, -1) !== DIRECTORY_SEPARATOR) {
313	10		$this->logDirectory .= DIRECTORY_SEPARATOR;
314			}
315
316	10		return $this->logDirectory;
317			}
318			}
319

facile-it / paraunit

Push — master ( 588d10...6487a1 )

LogPrinter A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like