Paraunit\Parser\JSONLogParser

Complexity

Total Complexity

11

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

95.12%

Importance

Changes	4
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	addParser()	0	4	1
A	parse()	0	8	2
A	extractTestResult()	0	10	3
A	checkErrorMessage()	0	13	4

<?php

namespace Paraunit\Parser;

use Paraunit\Exception\JSONLogNotFoundException;
use Paraunit\Exception\RecoverableTestErrorException;
use Paraunit\Process\ProcessResultInterface;

/**
 * Class JSONLogParser
 * @package Paraunit\Parser
 */
class JSONLogParser
{
    /** @var  JSONLogFetcher */
    private $logLocator;

    /** @var JSONParserChainElementInterface[] */
    protected $parsers;

    /**
     * JSONLogParser constructor.
     * @param JSONLogFetcher $logLocator
     */
    public function __construct(JSONLogFetcher $logLocator)
    {
        $this->logLocator = $logLocator;
        $this->parsers = array();
    }

    /**
     * @param JSONParserChainElementInterface $parser
     */
    public function addParser(JSONParserChainElementInterface $parser)
    {
        $this->parsers[] = $parser;
    }

    public function parse(ProcessResultInterface $process)
    {
        $logs = json_decode($this->logLocator->fetch($process));

$process is of type object<Paraunit\Process\ProcessResultInterface>, but the function expects a object<Paraunit\Process\ParaunitProcessInterface>.

        foreach ($logs as $singleLog) {
            $this->extractTestResult($process, $singleLog);
        }
    }

    /**
     * @param ProcessResultInterface $process
     * @param \stdClass $logItem
     * @return bool False if the parsing is still waiting for a test to give results
     */
    private function extractTestResult(ProcessResultInterface $process, \stdClass $logItem)
    {
        foreach ($this->parsers as $parser) {
            if ($parser->parsingFoundResult($process, $logItem)) {
                return true;
            }
        }

        return false;
    }

    private function checkErrorMessage(\stdClass $logItem)

This method is not used, and could be removed.

    {
        switch (true) {

It seems like you are loosely comparing preg_match('/^Incomplete Test: /', $logItem->message) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

It seems like you are loosely comparing preg_match('/^Skipped Test: /', $logItem->message) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

It seems like you are loosely comparing preg_match('/^Risky Test: /', $logItem->message) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

            case preg_match('/^Incomplete Test: /', $logItem->message):
                return 'I';
            case preg_match('/^Skipped Test: /', $logItem->message):
                return 'S';
            case preg_match('/^Risky Test: /', $logItem->message):
                return 'R';
            default:
                return 'E';
        }
    }
}