JSONLogFetcher::fetch() - Code Metrics - Inspection of "We're near, just one test failing" - facile-it/paraunit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — output_parsers_refactor ( 755930...b5c5df )

by Alessandro

created 2016-03-12 16:43 UTC

JSONLogFetcher::fetch() A

↳ Parent: JSONLogFetcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	12
ccs	4
cts	5
cp	0.8
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2.032

<?php

namespace Paraunit\Parser;

use Paraunit\Configuration\JSONLogFilename;
use Paraunit\Exception\JSONLogNotFoundException;
use Paraunit\Process\ParaunitProcessInterface;

/**
 * Class JSONLogFetcher
 * @package Paraunit\Parser
 */
class JSONLogFetcher
{
    /** @var  JSONLogFilename */
    private $fileName;

    /**
     * JSONLogFetcher constructor.
     * @param JSONLogFilename $fileName
     */
    public function __construct(JSONLogFilename $fileName)
    {
        $this->fileName = $fileName;
    }

    /**
     * @param ParaunitProcessInterface $process
     * @return array
     * @throws JSONLogNotFoundException
     */
    public function fetch(ParaunitProcessInterface $process)
    {
        $filePath = $this->fileName->generate($process);

        if ( ! file_exists($filePath)) {
            throw new JSONLogNotFoundException($process);
        }

        return json_decode(
            $this->cleanLog(file_get_contents($filePath))
        );
    }

    /**
     * @param string $jsonString The dirty output
     * @return string            The normalized log, as an array of JSON objects
     */
    private static function cleanLog($jsonString)
    {
        $splitted = preg_replace('/\}\{/', '},{', $jsonString);

        return '[' . $splitted . ']';
    }
}


1		<?php
2
3		namespace Paraunit\Parser;
4
5		use Paraunit\Configuration\JSONLogFilename;
6		use Paraunit\Exception\JSONLogNotFoundException;
7		use Paraunit\Process\ParaunitProcessInterface;
8
9		/**
10		* Class JSONLogFetcher
11		* @package Paraunit\Parser
12		*/
13		class JSONLogFetcher
14		{
15		/** @var JSONLogFilename */
16		private $fileName;
17
18		/**
19		* JSONLogFetcher constructor.
20		* @param JSONLogFilename $fileName
21		*/
22	1	public function __construct(JSONLogFilename $fileName)
23		{
24	1	$this->fileName = $fileName;
25	1	}
26
27		/**
28		* @param ParaunitProcessInterface $process
29		* @return array
30		* @throws JSONLogNotFoundException
31		*/
32	1	public function fetch(ParaunitProcessInterface $process)
33		{
34	1	$filePath = $this->fileName->generate($process);
35
36	1	if ( ! file_exists($filePath)) {
37	1	throw new JSONLogNotFoundException($process);
38		}
39
40		return json_decode(
41		$this->cleanLog(file_get_contents($filePath))
42		);
43		}
44
45		/**
46		* @param string $jsonString The dirty output
47		* @return string The normalized log, as an array of JSON objects
48		*/
49		private static function cleanLog($jsonString)
50		{
51		$splitted = preg_replace('/\}\{/', '},{', $jsonString);
52
53		return '[' . $splitted . ']';
54		}
55		}
56

facile-it / paraunit

Push — output_parsers_refactor ( 755930...b5c5df )

JSONLogFetcher::fetch() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like