CoverageMerger::merge() - Code Metrics - Inspection of "Merge pull request #114 from facile-it/fix-failure..." - facile-it/paraunit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1a3a48...6e0e69 )

by Alessandro

created 2017-12-13 14:12 UTC

CoverageMerger::merge() A

↳ Parent: CoverageMerger

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Paraunit\Coverage;

use Paraunit\Lifecycle\ProcessEvent;
use Paraunit\Process\AbstractParaunitProcess;
use Paraunit\Proxy\Coverage\CodeCoverage;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Class CoverageMerger
 * @package Paraunit\Coverage
 */
class CoverageMerger implements EventSubscriberInterface
{
    /** @var CoverageFetcher */
    private $coverageFetcher;

    /** @var CodeCoverage */
    private $coverageData;

    /**
     * CoverageMerger constructor.
     * @param CoverageFetcher $coverageFetcher
     */
    public function __construct(CoverageFetcher $coverageFetcher)
    {
        $this->coverageFetcher = $coverageFetcher;
    }

    public static function getSubscribedEvents(): array
    {
        return [
            ProcessEvent::PROCESS_PARSING_COMPLETED => 'onProcessParsingCompleted',
        ];
    }

    /**
     * @param ProcessEvent $processEvent
     */
    public function onProcessParsingCompleted(ProcessEvent $processEvent)
    {
        $process = $processEvent->getProcess();
        if ($process->isToBeRetried()) {
            return;
        }

        $this->merge($process);
    }

    private function merge(AbstractParaunitProcess $process)
    {
        $newCoverageData = $this->coverageFetcher->fetch($process);

        if ($this->coverageData instanceof CodeCoverage) {
            $this->coverageData->merge($newCoverageData);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $this->coverageData = $newCoverageData;
        }
    }

    public function getCoverageData(): CodeCoverage
    {
        return $this->coverageData;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Paraunit\Coverage;
6
7		use Paraunit\Lifecycle\ProcessEvent;
8		use Paraunit\Process\AbstractParaunitProcess;
9		use Paraunit\Proxy\Coverage\CodeCoverage;
10		use Symfony\Component\EventDispatcher\EventSubscriberInterface;
11
12		/**
13		* Class CoverageMerger
14		* @package Paraunit\Coverage
15		*/
16		class CoverageMerger implements EventSubscriberInterface
17		{
18		/** @var CoverageFetcher */
19		private $coverageFetcher;
20
21		/** @var CodeCoverage */
22		private $coverageData;
23
24		/**
25		* CoverageMerger constructor.
26		* @param CoverageFetcher $coverageFetcher
27		*/
28	12	public function __construct(CoverageFetcher $coverageFetcher)
29		{
30	12	$this->coverageFetcher = $coverageFetcher;
31		}
32
33	11	public static function getSubscribedEvents(): array
34		{
35		return [
36	11	ProcessEvent::PROCESS_PARSING_COMPLETED => 'onProcessParsingCompleted',
37		];
38		}
39
40		/**
41		* @param ProcessEvent $processEvent
42		*/
43	3	public function onProcessParsingCompleted(ProcessEvent $processEvent)
44		{
45	3	$process = $processEvent->getProcess();
46	3	if ($process->isToBeRetried()) {
47		return;
48		}
49
50	3	$this->merge($process);
51		}
52
53	3	private function merge(AbstractParaunitProcess $process)
54		{
55	3	$newCoverageData = $this->coverageFetcher->fetch($process);
56
57	3	if ($this->coverageData instanceof CodeCoverage) {
58	1	$this->coverageData->merge($newCoverageData);
		0 ignored issues – show Documentation introduced 2017-11-30 22:33 UTC by Report Bug Copy Issue Report `$newCoverageData` is of type `object<Paraunit\Proxy\Coverage\CodeCoverage>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59		} else {
60	3	$this->coverageData = $newCoverageData;
61		}
62		}
63
64	3	public function getCoverageData(): CodeCoverage
65		{
66	3	return $this->coverageData;
67		}
68		}
69

facile-it / paraunit

Push — master ( 1a3a48...6e0e69 )

CoverageMerger::merge() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like