JSONLogFetcher::fetch() - Code Metrics - Inspection of "Refactor test results as value object" - facile-it/paraunit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Alessandro

created 2016-03-16 22:58 UTC

JSONLogFetcher::fetch() A

↳ Parent: JSONLogFetcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
c	5
b	0
f	0
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	9.4285
cc	2
eloc	8
nc	2
nop	1
crap	2

<?php

namespace Paraunit\Parser;

use Paraunit\Configuration\JSONLogFilename;
use Paraunit\Process\ParaunitProcessInterface;

/**
 * Class JSONLogFetcher
 * @package Paraunit\Parser
 */
class JSONLogFetcher
{
    const LOG_ENDING_STATUS = 'paraunitEnd';

    /** @var  JSONLogFilename */
    private $fileName;

    /**
     * JSONLogFetcher constructor.
     * @param JSONLogFilename $fileName
     */
    public function __construct(JSONLogFilename $fileName)
    {
        $this->fileName = $fileName;
    }

    /**
     * @param ParaunitProcessInterface $process
     * @return array
     */
    public function fetch(ParaunitProcessInterface $process)
    {
        $filePath = $this->fileName->generate($process);
        $fileContent = '';

        if (file_exists($filePath)) {
            $fileContent = file_get_contents($filePath);
        }

        $logs = json_decode($this->cleanLog($fileContent));
        $logs[] = $this->createLogEnding();

        return $logs;
    }

    /**
     * @param string $jsonString The dirty output
     * @return string            The normalized log, as an array of JSON objects
     */
    private static function cleanLog($jsonString)
    {
        $splitted = preg_replace('/\}\{/', '},{', $jsonString);

        return '[' . $splitted . ']';
    }

    private function createLogEnding()
    {
        $logEnding = new \stdClass();
        $logEnding->status = self::LOG_ENDING_STATUS;

        return $logEnding;
    }
}


1		<?php
2
3		namespace Paraunit\Parser;
4
5		use Paraunit\Configuration\JSONLogFilename;
6		use Paraunit\Process\ParaunitProcessInterface;
7
8		/**
9		* Class JSONLogFetcher
10		* @package Paraunit\Parser
11		*/
12		class JSONLogFetcher
13		{
14		const LOG_ENDING_STATUS = 'paraunitEnd';
15
16		/** @var JSONLogFilename */
17		private $fileName;
18
19		/**
20		* JSONLogFetcher constructor.
21		* @param JSONLogFilename $fileName
22		*/
23	23	public function __construct(JSONLogFilename $fileName)
24		{
25	23	$this->fileName = $fileName;
26	23	}
27
28		/**
29		* @param ParaunitProcessInterface $process
30		* @return array
31		*/
32	22	public function fetch(ParaunitProcessInterface $process)
33		{
34	22	$filePath = $this->fileName->generate($process);
35	22	$fileContent = '';
36
37	22	if (file_exists($filePath)) {
38	21	$fileContent = file_get_contents($filePath);
39	21	}
40
41	22	$logs = json_decode($this->cleanLog($fileContent));
42	22	$logs[] = $this->createLogEnding();
43
44	22	return $logs;
45		}
46
47		/**
48		* @param string $jsonString The dirty output
49		* @return string The normalized log, as an array of JSON objects
50		*/
51	22	private static function cleanLog($jsonString)
52		{
53	22	$splitted = preg_replace('/\}\{/', '},{', $jsonString);
54
55	22	return '[' . $splitted . ']';
56		}
57
58	22	private function createLogEnding()
59		{
60	22	$logEnding = new \stdClass();
61	22	$logEnding->status = self::LOG_ENDING_STATUS;
62
63	22	return $logEnding;
64		}
65		}
66

facile-it / paraunit

Pull Request — master (#37)

JSONLogFetcher::fetch() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like