Issues in Query.php (master) - Issues in master - facile-it/mongodb-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

src/Models/Query.php (1 issue)

Labels

Severity

Minor 1

<?php

declare(strict_types=1);

namespace Facile\MongoDbBundle\Models;

/**
 * Class Query.
 *
 * @internal
 */
final class Query
{
    /** @var float */
    private $start;

    /** @var string */
    private $method;

    /** @var string */
    private $collection;

    /** @var array */
    private $filters;

    /** @var array|object */
    private $data;

    /** @var array */
    private $options;

    /** @var float */
    private $executionTime;

    /** @var string */
    private $readPreference;

    /** @var string */
    private $client;

    /** @var string */
    private $database;

    /**
     * Query constructor.
     */
    public function __construct()
    {
        $this->start = microtime(true);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->client = 'undefined';
        $this->database = 'undefined';
        $this->collection = 'undefined';
        $this->method = 'undefined';
        $this->filters = [];
        $this->data = [];
        $this->options = [];
        $this->executionTime = 0;
        $this->readPreference = 'undefined';
    }

    /**
     * @return float
     */
    public function getStart(): float
    {
        return $this->start;
    }

    /**
     * @return string
     */
    public function getCollection(): string
    {
        return $this->collection;
    }

    /**
     * @param string $collection
     */
    public function setCollection(string $collection)
    {
        $this->collection = $collection;
    }

    /**
     * @return string
     */
    public function getMethod(): string
    {
        return $this->method;
    }

    /**
     * @param string $method
     */
    public function setMethod(string $method)
    {
        $this->method = $method;
    }

    /**
     * @return array
     */
    public function getFilters(): array
    {
        return $this->filters;
    }

    /**
     * @param array|object $filters
     */
    public function setFilters($filters)
    {
        $this->filters = (array) ($filters ?? []);
    }

    /**
     * @return array|object
     */
    public function getData()
    {
        return $this->data;
    }

    /**
     * @param array|object $data
     */
    public function setData($data): void
    {
        $this->data = $data ?? [];
    }

    /**
     * @return array
     */
    public function getOptions(): array
    {
        return $this->options;
    }

    /**
     * @param array $options
     */
    public function setOptions(array $options)
    {
        $this->options = $options;
    }

    /**
     * @return float
     */
    public function getExecutionTime(): float
    {
        return $this->executionTime;
    }

    public function setExecutionTime(float $executionTime)
    {
        $this->executionTime = $executionTime;
    }

    /**
     * @return string
     */
    public function getReadPreference(): string
    {
        return $this->readPreference;
    }

    /**
     * @param string $readPreference
     */
    public function setReadPreference(string $readPreference)
    {
        $this->readPreference = $readPreference;
    }

    /**
     * @return string
     */
    public function getClient(): string
    {
        return $this->client;
    }

    /**
     * @param string $client
     */
    public function setClient(string $client)
    {
        $this->client = $client;
    }

    /**
     * @return string
     */
    public function getDatabase(): string
    {
        return $this->database;
    }

    /**
     * @param string $database
     */
    public function setDatabase(string $database)
    {
        $this->database = $database;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Facile\MongoDbBundle\Models;
6
7		/**
8		* Class Query.
9		*
10		* @internal
11		*/
12		final class Query
13		{
14		/** @var float */
15		private $start;
16
17		/** @var string */
18		private $method;
19
20		/** @var string */
21		private $collection;
22
23		/** @var array */
24		private $filters;
25
26		/** @var array\|object */
27		private $data;
28
29		/** @var array */
30		private $options;
31
32		/** @var float */
33		private $executionTime;
34
35	34	/** @var string */
36		private $readPreference;
37	34
38	34	/** @var string */
39	34	private $client;
40	34
41	34	/** @var string */
42	34	private $database;
43	34
44	34	/**
45	34	* Query constructor.
46	34	*/
47	34	public function __construct()
48		{
49		$this->start = microtime(true);
		0 ignored issues – show Documentation Bug introduced 2021-01-14 10:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `microtime(true)` can also be of type `string`. However, the property `$start` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
50		$this->client = 'undefined';
51		$this->database = 'undefined';
52	13	$this->collection = 'undefined';
53		$this->method = 'undefined';
54	13	$this->filters = [];
55		$this->data = [];
56		$this->options = [];
57		$this->executionTime = 0;
58		$this->readPreference = 'undefined';
59		}
60	12
61		/**
62	12	* @return float
63		*/
64		public function getStart(): float
65		{
66		return $this->start;
67		}
68	24
69		/**
70	24	* @return string
71	24	*/
72		public function getCollection(): string
73		{
74		return $this->collection;
75		}
76	14
77		/**
78	14	* @param string $collection
79		*/
80		public function setCollection(string $collection)
81		{
82		$this->collection = $collection;
83		}
84	26
85		/**
86	26	* @return string
87	26	*/
88		public function getMethod(): string
89		{
90		return $this->method;
91		}
92	28
93		/**
94	28	* @param string $method
95		*/
96		public function setMethod(string $method)
97		{
98		$this->method = $method;
99		}
100	31
101		/**
102	31	* @return array
103	31	*/
104		public function getFilters(): array
105		{
106		return $this->filters;
107		}
108	14
109		/**
110	14	* @param array\|object $filters
111		*/
112		public function setFilters($filters)
113		{
114		$this->filters = (array) ($filters ?? []);
115		}
116	20
117		/**
118	20	* @return array\|object
119	20	*/
120		public function getData()
121		{
122		return $this->data;
123		}
124	27
125		/**
126	27	* @param array\|object $data
127		*/
128		public function setData($data): void
129		{
130		$this->data = $data ?? [];
131		}
132	20
133		/**
134	20	* @return array
135	20	*/
136		public function getOptions(): array
137		{
138		return $this->options;
139		}
140	2
141		/**
142	2	* @param array $options
143		*/
144		public function setOptions(array $options)
145		{
146		$this->options = $options;
147		}
148	13
149		/**
150	13	* @return float
151	13	*/
152		public function getExecutionTime(): float
153		{
154		return $this->executionTime;
155		}
156	1
157		public function setExecutionTime(float $executionTime)
158	1	{
159		$this->executionTime = $executionTime;
160		}
161
162		/**
163		* @return string
164	13	*/
165		public function getReadPreference(): string
166	13	{
167	13	return $this->readPreference;
168		}
169
170		/**
171		* @param string $readPreference
172	3	*/
173		public function setReadPreference(string $readPreference)
174	3	{
175		$this->readPreference = $readPreference;
176		}
177
178		/**
179		* @return string
180	16	*/
181		public function getClient(): string
182	16	{
183	16	return $this->client;
184		}
185
186		/**
187		* @param string $client
188	3	*/
189		public function setClient(string $client)
190	3	{
191		$this->client = $client;
192		}
193
194		/**
195		* @return string
196	16	*/
197		public function getDatabase(): string
198	16	{
199	16	return $this->database;
200		}
201
202		/**
203		* @param string $database
204		*/
205		public function setDatabase(string $database)
206		{
207		$this->database = $database;
208		}
209		}
210

facile-it / mongodb-bundle

Issues (21)

src/Models/Query.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like