MongoFixturesLoader::__construct() - Code Metrics - Inspection of "Mongo fixture support" - facile-it/mongodb-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — index_loading_feature (a31c33)

by Alessandro

created 2016-10-06 10:13 UTC

MongoFixturesLoader::__construct() A

↳ Parent: MongoFixturesLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Facile\MongoDbBundle\Fixtures;

use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Class MongoFixturesLoader.
 */
class MongoFixturesLoader
{
    /** @var  array|MongoFixtureInterface[] */
    private $loadedClasses;

    /** @var ContainerInterface */
    private $container;

    /**
     * MongoFixturesLoader constructor.
     *
     * @param ContainerInterface $container
     */
    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
    }

    /**
     * @param string $dir
     *
     * @return array
     */
    public function loadFromDirectory(string $dir)
    {
        if (!is_dir($dir)) {
            throw new \InvalidArgumentException(sprintf('"%s" does not exist', $dir));
        }

        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir),
            \RecursiveIteratorIterator::LEAVES_ONLY
        );
        return $this->loadFromIterator($iterator);
    }

    /**
     * @param string $fileName
     *
     * @return array
     */
    public function loadFromFile(string $fileName)
    {
        if (!is_readable($fileName)) {
            throw new \InvalidArgumentException(sprintf('"%s" does not exist or is not readable', $fileName));
        }

        $iterator = new \ArrayIterator(array(new \SplFileInfo($fileName)));
        return $this->loadFromIterator($iterator);
    }

    /**
     * @param \Iterator $iterator
     *
     * @return array
     */
    private function loadFromIterator(\Iterator $iterator)
    {
        $includedFiles = array();
        foreach ($iterator as $file) {
            if (($fileName = $file->getBasename('.php')) == $file->getBasename()) {
                continue;
            }
            $sourceFile = realpath($file->getPathName());
            require_once $sourceFile;
            $includedFiles[] = $sourceFile;
        }

        $classes = array();
        $declared = get_declared_classes();
        foreach ($declared as $className) {
            $reflClass = new \ReflectionClass($className);
            $sourceFile = $reflClass->getFileName();

            if (in_array($sourceFile, $includedFiles)) {
                $classes[] = $this->buildFixture($className);
            }
        }

        return $classes;
    }

    /**
     * @param MongoFixtureInterface $list
     */
    public function addInstance(MongoFixtureInterface $list)
    {
        $listClass = get_class($list);

        if (!isset($this->loadedClasses[$listClass])) {
            $this->loadedClasses[$listClass] = $list;
        }
    }

    /**
     * @return array|MongoFixtureInterface[]
     */
    public function getLoadedClasses()
    {
        return $this->loadedClasses;
    }

    /**
     * @param string $className
     *
     * @return MongoFixtureInterface
     */
    private function buildFixture($className): MongoFixtureInterface
    {
        $instance = new $className;

        if ($instance instanceof AbstractContainerAwareFixture) {
            $instance->setContainer($this->container);
        }

        $classes[] = $instance;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $this->addInstance($instance);

        return $instance;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Facile\MongoDbBundle\Fixtures;
6
7			use Symfony\Component\DependencyInjection\ContainerInterface;
8
9			/**
10			* Class MongoFixturesLoader.
11			*/
12			class MongoFixturesLoader
13			{
14			/** @var array\|MongoFixtureInterface[] */
15			private $loadedClasses;
16
17			/** @var ContainerInterface */
18			private $container;
19
20			/**
21			* MongoFixturesLoader constructor.
22			*
23			* @param ContainerInterface $container
24			*/
25			public function __construct(ContainerInterface $container)
26			{
27			$this->container = $container;
28			}
29
30			/**
31			* @param string $dir
32			*
33			* @return array
34			*/
35			public function loadFromDirectory(string $dir)
36			{
37			if (!is_dir($dir)) {
38			throw new \InvalidArgumentException(sprintf('"%s" does not exist', $dir));
39			}
40
41			$iterator = new \RecursiveIteratorIterator(
42			new \RecursiveDirectoryIterator($dir),
43			\RecursiveIteratorIterator::LEAVES_ONLY
44			);
45			return $this->loadFromIterator($iterator);
46			}
47
48			/**
49			* @param string $fileName
50			*
51			* @return array
52			*/
53			public function loadFromFile(string $fileName)
54			{
55			if (!is_readable($fileName)) {
56			throw new \InvalidArgumentException(sprintf('"%s" does not exist or is not readable', $fileName));
57			}
58
59			$iterator = new \ArrayIterator(array(new \SplFileInfo($fileName)));
60			return $this->loadFromIterator($iterator);
61			}
62
63			/**
64			* @param \Iterator $iterator
65			*
66			* @return array
67			*/
68			private function loadFromIterator(\Iterator $iterator)
69			{
70			$includedFiles = array();
71			foreach ($iterator as $file) {
72			if (($fileName = $file->getBasename('.php')) == $file->getBasename()) {
73			continue;
74			}
75			$sourceFile = realpath($file->getPathName());
76			require_once $sourceFile;
77			$includedFiles[] = $sourceFile;
78			}
79
80			$classes = array();
81			$declared = get_declared_classes();
82			foreach ($declared as $className) {
83			$reflClass = new \ReflectionClass($className);
84			$sourceFile = $reflClass->getFileName();
85
86			if (in_array($sourceFile, $includedFiles)) {
87			$classes[] = $this->buildFixture($className);
88			}
89			}
90
91			return $classes;
92			}
93
94			/**
95			* @param MongoFixtureInterface $list
96			*/
97			public function addInstance(MongoFixtureInterface $list)
98			{
99			$listClass = get_class($list);
100
101			if (!isset($this->loadedClasses[$listClass])) {
102			$this->loadedClasses[$listClass] = $list;
103			}
104			}
105
106			/**
107			* @return array\|MongoFixtureInterface[]
108			*/
109			public function getLoadedClasses()
110			{
111			return $this->loadedClasses;
112			}
113
114			/**
115			* @param string $className
116			*
117			* @return MongoFixtureInterface
118			*/
119			private function buildFixture($className): MongoFixtureInterface
120			{
121			$instance = new $className;
122
123			if ($instance instanceof AbstractContainerAwareFixture) {
124			$instance->setContainer($this->container);
125			}
126
127			$classes[] = $instance;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-06 10:16 UTC by Report Bug Copy Issue Report `$classes` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$classes = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
128			$this->addInstance($instance);
129
130			return $instance;
131			}
132			}
133

facile-it / mongodb-bundle

Branch — index_loading_feature (a31c33)

MongoFixturesLoader::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like