ConnectionConfiguration::getConnectionUri() - Code Metrics - Inspection of "connection configuration refactoring" - facile-it/mongodb-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Alessandro

created 2016-08-10 17:53 UTC

ConnectionConfiguration::getConnectionUri() B

↳ Parent: ConnectionConfiguration

Complexity

Conditions	4
Paths	3

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	30
ccs	19
cts	19
cp	1
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	20
nc	3
nop	1
crap	4

<?php

declare(strict_types=1);

namespace Facile\MongoDbBundle\Models;

/**
 * Class ConnectionConfiguration.
 */
class ConnectionConfiguration
{
    /** @var string */
    private $host;
    /** @var int */
    private $port;
    /** @var string */
    private $username;
    /** @var string */
    private $password;

    /**
     * ConnectionConfiguration constructor.
     *
     * @param string $host
     * @param int    $port
     * @param string $username
     * @param string $password
     */
    public function __construct(string $host, int $port, string $username = '', string $password = '')
    {
        $this->host = $host;
        $this->port = $port;
        $this->username = $username;
        $this->password = $password;
    }

    /**
     * @return string
     */
    public function getHost(): string
    {
        return $this->host;
    }

    /**
     * @return int
     */
    public function getPort(): int
    {
        return $this->port;
    }

    /**
     * @return string
     */
    public function getUsername(): string
    {
        return $this->username;
    }

    /**
     * @return bool
     */
    public function hasCredentials(): bool
    {
        return !empty($this->username);
    }

    /**
     * @return string
     */
    public function getPassword(): string
    {
        return $this->password;
    }

    /**
     * @param string $databaseName
     *
     * @return string
     */
    public function getConnectionUri(string $databaseName = null): string
    {
        // Refactor with a uriBuilder service or something like that
        if ($this->hasCredentials() && !is_null($databaseName)) {
            return sprintf(
                'mongodb://%s:%s@%s:%d/%s',
                $this->username,
                $this->password,
                $this->host,
                $this->port,
                $databaseName
            );
        }

        if ($this->hasCredentials()) {
            return sprintf(
                'mongodb://%s:%s@%s:%d',
                $this->username,
                $this->password,
                $this->host,
                $this->port
            );
        }

        return sprintf(
            'mongodb://%s:%d',
            $this->host,
            $this->port
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Facile\MongoDbBundle\Models;
6
7		/**
8		* Class ConnectionConfiguration.
9		*/
10		class ConnectionConfiguration
11		{
12		/** @var string */
13		private $host;
14		/** @var int */
15		private $port;
16		/** @var string */
17		private $username;
18		/** @var string */
19		private $password;
20
21		/**
22		* ConnectionConfiguration constructor.
23		*
24		* @param string $host
25		* @param int $port
26		* @param string $username
27		* @param string $password
28		*/
29	4	public function __construct(string $host, int $port, string $username = '', string $password = '')
30		{
31	4	$this->host = $host;
32	4	$this->port = $port;
33	4	$this->username = $username;
34	4	$this->password = $password;
35	4	}
36
37		/**
38		* @return string
39		*/
40	2	public function getHost(): string
41		{
42	2	return $this->host;
43		}
44
45		/**
46		* @return int
47		*/
48	2	public function getPort(): int
49		{
50	2	return $this->port;
51		}
52
53		/**
54		* @return string
55		*/
56	2	public function getUsername(): string
57		{
58	2	return $this->username;
59		}
60
61		/**
62		* @return bool
63		*/
64	4	public function hasCredentials(): bool
65		{
66	4	return !empty($this->username);
67		}
68
69		/**
70		* @return string
71		*/
72	2	public function getPassword(): string
73		{
74	2	return $this->password;
75		}
76
77		/**
78		* @param string $databaseName
79		*
80		* @return string
81		*/
82	4	public function getConnectionUri(string $databaseName = null): string
83		{
84		// Refactor with a uriBuilder service or something like that
85	4	if ($this->hasCredentials() && !is_null($databaseName)) {
86	2	return sprintf(
87	2	'mongodb://%s:%s@%s:%d/%s',
88	2	$this->username,
89	2	$this->password,
90	2	$this->host,
91	2	$this->port,
92		$databaseName
93		);
94		}
95
96	2	if ($this->hasCredentials()) {
97	1	return sprintf(
98	1	'mongodb://%s:%s@%s:%d',
99	1	$this->username,
100	1	$this->password,
101	1	$this->host,
102	1	$this->port
103		);
104		}
105
106	1	return sprintf(
107	1	'mongodb://%s:%d',
108	1	$this->host,
109	1	$this->port
110		);
111		}
112		}
113

facile-it / mongodb-bundle

Pull Request — master (#5)

ConnectionConfiguration::getConnectionUri() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like