PropertyTemplate::generate() - Code Metrics - Inspection of "Implement a Proxy that extends original mock objec..." - facile-it/moka - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Alberto

created 2017-07-06 12:09 UTC

PropertyTemplate::generate() A

↳ Parent: PropertyTemplate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Moka\Generator\Template;

/**
 * Class PropertyTemplate
 * @package Moka\Generator\Template
 */
class PropertyTemplate implements TemplateInterface
{
    use VisibilityTrait;

    const TEMPLATE = '
        %s %s $%s;
    ';

    /**
     * @param \ReflectionProperty $property
     * @return string
     */
    public static function generate(\Reflector $property): string
    {
        return static::doGenerate($property);

    }

    /**
     * @param \ReflectionProperty $property
     * @return string
     */
    protected static function doGenerate(\ReflectionProperty $property): string
    {
        $visibility = static::getVisibility($property);

        $static = $property->isStatic() ? 'static' : '';

        $name = $property->getName();

        return sprintf(
            self::TEMPLATE,
            $visibility,
            $static,
            $name
        );
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Moka\Generator\Template;
5
6		/**
7		* Class PropertyTemplate
8		* @package Moka\Generator\Template
9		*/
10		class PropertyTemplate implements TemplateInterface
11		{
12		use VisibilityTrait;
13
14		const TEMPLATE = '
15		%s %s $%s;
16		';
17
18		/**
19		* @param \ReflectionProperty $property
20		* @return string
21		*/
22	4	public static function generate(\Reflector $property): string
23		{
24	4	return static::doGenerate($property);
		1 ignored issue – show Compatibility introduced 2017-07-06 12:13 UTC by Report Bug Copy Issue Report `$property` of type `object<Reflector>` is not a sub-type of `object<ReflectionProperty>`. It seems like you assume a concrete implementation of the interface `Reflector` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
25		}
26
27		/**
28		* @param \ReflectionProperty $property
29		* @return string
30		*/
31	4	protected static function doGenerate(\ReflectionProperty $property): string
32		{
33	4	$visibility = static::getVisibility($property);
34
35	4	$static = $property->isStatic() ? 'static' : '';
36
37	4	$name = $property->getName();
38
39	4	return sprintf(
40	4	self::TEMPLATE,
41	4	$visibility,
42	4	$static,
43	4	$name
44		);
45		}
46		}
47

facile-it / moka

Pull Request — master (#37)

PropertyTemplate::generate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like