ProxyGenerator::__construct() - Code Metrics - Inspection of "Merge pull request #37 from facile-it/feature/prox..." - facile-it/moka - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ee214...32fd8d )

by Alberto

created 2017-07-12 15:12 UTC

ProxyGenerator::__construct() A

↳ Parent: ProxyGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php
declare(strict_types=1);

namespace Moka\Generator;

use Moka\Exception\InvalidArgumentException;
use Moka\Exception\MockNotCreatedException;
use Moka\Generator\Template\ClassTemplate;
use Moka\Proxy\ProxyInterface;
use Moka\Proxy\ProxyTrait;
use Moka\Strategy\MockingStrategyInterface;

/**
 * Class ProxyGenerator
 * @package Moka\Generator
 */
class ProxyGenerator
{
    /**
     * @var MockingStrategyInterface
     */
    private $mockingStrategy;

    /**
     * ProxyGenerator constructor.
     * @param MockingStrategyInterface $mockingStrategy
     */
    public function __construct(MockingStrategyInterface $mockingStrategy)
    {
        $this->mockingStrategy = $mockingStrategy;
    }

    /**
     * @param string $fqcn
     * @return ProxyInterface
     *
     * @throws MockNotCreatedException
     * @throws InvalidArgumentException
     */
    public function get(string $fqcn): ProxyInterface
    {
        $mock = $this->mockingStrategy->build($fqcn);
        $mockFQCN = get_class($this->mockingStrategy->get($mock));
        $mockClass = new \ReflectionClass($mockFQCN);

        $proxyCode = ClassTemplate::generate($mockClass);
        $proxyFQCN = eval($proxyCode);

        return $this->getInstance($proxyFQCN)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->__moka_setMock($mock)
            ->__moka_setMockingStrategy($this->mockingStrategy);
    }

    /**
     * @param string $proxyFQCN
     * @return ProxyInterface|ProxyTrait
     */
    protected function getInstance(string $proxyFQCN): ProxyInterface
    {
        $proxyClass = new \ReflectionClass($proxyFQCN);

        /** @var ProxyInterface|ProxyTrait $proxy */
        $proxy = $proxyClass->newInstance();

        return $proxy;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Moka\Generator;
5
6		use Moka\Exception\InvalidArgumentException;
7		use Moka\Exception\MockNotCreatedException;
8		use Moka\Generator\Template\ClassTemplate;
9		use Moka\Proxy\ProxyInterface;
10		use Moka\Proxy\ProxyTrait;
11		use Moka\Strategy\MockingStrategyInterface;
12
13		/**
14		* Class ProxyGenerator
15		* @package Moka\Generator
16		*/
17		class ProxyGenerator
18		{
19		/**
20		* @var MockingStrategyInterface
21		*/
22		private $mockingStrategy;
23
24		/**
25		* ProxyGenerator constructor.
26		* @param MockingStrategyInterface $mockingStrategy
27		*/
28	4	public function __construct(MockingStrategyInterface $mockingStrategy)
29		{
30	4	$this->mockingStrategy = $mockingStrategy;
31		}
32
33		/**
34		* @param string $fqcn
35		* @return ProxyInterface
36		*
37		* @throws MockNotCreatedException
38		* @throws InvalidArgumentException
39		*/
40	10	public function get(string $fqcn): ProxyInterface
41		{
42	10	$mock = $this->mockingStrategy->build($fqcn);
43	10	$mockFQCN = get_class($this->mockingStrategy->get($mock));
44	10	$mockClass = new \ReflectionClass($mockFQCN);
45
46	10	$proxyCode = ClassTemplate::generate($mockClass);
47	10	$proxyFQCN = eval($proxyCode);
48
49	10	return $this->getInstance($proxyFQCN)
		1 ignored issue – show Bug introduced 2017-07-06 12:13 UTC by Report Bug Copy Issue Report The method `__moka_setMock` does only exist in `Moka\Proxy\ProxyTrait`, but not in `Moka\Proxy\ProxyInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50	10	->__moka_setMock($mock)
51	10	->__moka_setMockingStrategy($this->mockingStrategy);
52		}
53
54		/**
55		* @param string $proxyFQCN
56		* @return ProxyInterface\|ProxyTrait
57		*/
58	10	protected function getInstance(string $proxyFQCN): ProxyInterface
59		{
60	10	$proxyClass = new \ReflectionClass($proxyFQCN);
61
62		/** @var ProxyInterface\|ProxyTrait $proxy */
63	10	$proxy = $proxyClass->newInstance();
64
65	10	return $proxy;
66		}
67		}
68

facile-it / moka

Push — master ( 7ee214...32fd8d )

ProxyGenerator::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like