Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class ProxyGeneratorFactory |
|
14 | { |
||
15 | /** |
||
16 | * @var array|ProxyGenerator[] |
||
17 | */ |
||
18 | private static $proxyGenerators = []; |
||
19 | |||
20 | /** |
||
21 | * @param MockingStrategyInterface $mockingStrategy |
||
22 | * @return ProxyGenerator |
||
23 | */ |
||
24 | 8 | public static function get(MockingStrategyInterface $mockingStrategy): ProxyGenerator |
|
33 | |||
34 | /** |
||
35 | * @param MockingStrategyInterface $mockingStrategy |
||
36 | * @return string |
||
37 | */ |
||
38 | 8 | private static function key(MockingStrategyInterface $mockingStrategy): string |
|
42 | |||
43 | /** |
||
44 | * @param MockingStrategyInterface $mockingStrategy |
||
45 | * @return ProxyGenerator |
||
46 | */ |
||
47 | 2 | protected static function build(MockingStrategyInterface $mockingStrategy): ProxyGenerator |
|
51 | } |
||
52 |