Moka\Generator\Template\ProxyMethodTemplate::doGenerate()

Complexity

Conditions	7
Paths	32

Size

Total Lines	33
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected static function doGenerate(\ReflectionMethod $method): string
    {
        $static = $method->isStatic() ? 'static' : '';

        $parameters = $method->getParameters();
        $parametersCode = [];
        if ($parameters) {

The expression $parameters of type ReflectionParameter[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($parameters as $parameter) {
                $parametersCode[] = ProxyParameterTemplate::generate($parameter);
            }
        }

        $originalReturnType = $method->getReturnType();
        $returnType = $originalReturnType
            ? ProxyReturnTypeTemplate::generate($method)
            : '';

        $returnStatement = null === $originalReturnType || 'void' !== (string)$originalReturnType
            ? 'return'
            : '';

        $methodName = $method->getName();

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

        return sprintf(
            self::TEMPLATE,
            $static,
            $methodName,
            implode(',', $parametersCode),
            $returnType,
            $returnStatement,
            $methodName
        );
    }
}