Moka\Generator\ProxyMethodGenerator::generateMethodString()

Complexity

Conditions	7
Paths	16

Size

Total Lines	32
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	7.0052

Importance

Changes

0

<?php
    public static function generateMethodString(\ReflectionMethod $method)
    {
        $static = $method->isStatic() ? 'static' : '';
        $originalReturnType = $method->getReturnType();

        $returnType = !$originalReturnType ? '' : ProxyReturnGenerator::generateMethodReturnType($originalReturnType, $method);

        $parameters = $method->getParameters();
        $arguments = [];
        if ($parameters) {

The expression $parameters of type ReflectionParameter[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($method->getParameters() as $parameter) {
                $arguments[] = ProxyArgumentGenerator::generateMethodParameter($parameter);
            }
        }

        $method->getReturnType();

        $returnStatement = 'return ';
        if (null !== $originalReturnType && self::getType($originalReturnType) === 'void') {
            $returnStatement = '';
        }

        return sprintf(
            self::$template,
            $static,
            $method->getName(),

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

            implode(', ', $arguments),
            $returnType,
            $returnStatement,
            $method->getName()

Consider using $method->name. There is an issue with getName() and APC-enabled PHP versions.

        );
    }