View GitHub Repository json-api-ts

Schedule Inspection
Subscribe
Passed
Push — master ( 850f91...109844 )
by Alberto
04:39 queued 02:29
created

lib/ResourceRecord.js   A

↳ Parent: Project

Complexity

Total Complexity 7
Complexity/F 1.75

Size

Lines of Code 22
Function Count 4

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
wmc 7
eloc 17
mnd 3
bc 3
fnc 4
dl 0
loc 22
bpm 0.75
cpm 1.75
noi 4
c 0
b 0
f 0
rs 10
1 
"use strict";
2 
var __assign = (this && this.__assign) || function () {
3 
    __assign = Object.assign || function(t) {
4 
        for (var s, i = 1, n = arguments.length; i < n; i++) {
5 
            s = arguments[i];
6 
            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
0 ignored issues
– show
Coding Style Best Practice introduced by
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.

Consider:

if (a > 0)
    b = 42;

If you or someone else later decides to put another statement in, only the first statement will be executed.

if (a > 0)
    console.log("a > 0");
    b = 42;

In this case the statement b = 42 will always be executed, while the logging statement will be executed conditionally.

if (a > 0) {
    console.log("a > 0");
    b = 42;
}

ensures that the proper code will be executed conditionally no matter how many statements are added or removed.

Loading history...
Complexity introduced by
A for in loop automatically includes the property of any prototype object, consider checking the key using hasOwnProperty.

When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically:

var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
Loading history...
7 
                t[p] = s[p];
0 ignored issues
– show
Coding Style Best Practice introduced by
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.

Consider:

if (a > 0)
    b = 42;

If you or someone else later decides to put another statement in, only the first statement will be executed.

if (a > 0)
    console.log("a > 0");
    b = 42;

In this case the statement b = 42 will always be executed, while the logging statement will be executed conditionally.

if (a > 0) {
    console.log("a > 0");
    b = 42;
}

ensures that the proper code will be executed conditionally no matter how many statements are added or removed.

Loading history...
8 
        }
9 
        return t;
10 
    };
11 
    return __assign.apply(this, arguments);
12 
};
13 
Object.defineProperty(exports, "__esModule", { value: true });
14 
var ResourceIdentifier_1 = require("./ResourceIdentifier");
15 
exports.ResourceRecord = {
16 
    fromResources: function (resources) {
17 
        return resources.reduce(function (record, resource) {
18 
            var _a;
19 
            return (__assign(__assign({}, record), (_a = {}, _a[ResourceIdentifier_1.ResourceIdentifier.iso.string.get(resource)] = resource, _a)));
0 ignored issues
– show
Comprehensibility introduced by
Usage of the sequence operator is discouraged, since it may lead to obfuscated code.

The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression.

This operator is most often used in for statements.

Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator.

This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements.

var a,b,c;

a = 1, b = 1,  c= 3;

could just as well be written as:

var a,b,c;

a = 1;
b = 1;
c = 3;

To learn more about the sequence operator, please refer to the MDN.

Loading history...
20 
        }, {});
21 
    }
22 
};
23