Completed
Push — master ( f93ccb...d2e371 )
by Alessandro
03:39
created

Factory::createPublisher()   B

Complexity

Conditions 3
Paths 4

Size

Total Lines 27
Code Lines 16

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 11
CRAP Score 3.0052

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 27
ccs 11
cts 12
cp 0.9167
rs 8.8571
cc 3
eloc 16
nc 4
nop 8
crap 3.0052

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace Facile\CrossbarHTTPPublisherBundle\Publisher;
4
5
use GuzzleHttp\Client as GuzzleClient;
6
7
/**
8
 * Class Factory
9
 * @package Facile\CrossbarHTTPPublisherBundle\Publisher
10
 */
11
class Factory
12
{
13
    /**
14
     * @param string $protocol
15
     * @param string $host
16
     * @param int $port
17
     * @param string $path
18
     * @param string $key
19
     * @param string $secret
20
     * @param bool|string $hostname
21
     * @param bool $ignoreSsl
22
     * @return Publisher
23
     */
24 2
    public function createPublisher($protocol, $host, $port, $path, $key, $secret, $hostname, $ignoreSsl)
25
    {
26 2
        $config = array();
27
28 2
        $config['base_url'] = sprintf(
29 2
            '%s://%s:%s%s',
30
            $protocol,
31
            $host,
32
            $port,
33
            $path
34
        );
35 2
        $config['base_uri'] = $config['base_url']; // Guzzle 6 compat
36
37 2
        $config['defaults']['headers']['Content-Type'] = 'application/json';
38
39 2
        if (null !== $hostname) {
40
            $config['defaults']['headers']['Host'] = $hostname;
41
        }
42
43 2
        if ($ignoreSsl) {
44 2
            $config['defaults']['verify'] = false;
45
        }
46
47 2
        $guzzleClient = new GuzzleClient($config);
48
49 2
        return new Publisher($guzzleClient, $key, $secret);
50
    }
51
}
52