facebook / facebook-php-sdk-v4

src/Facebook/PseudoRandomString/OpenSslPseudoRandomStringGenerator.php

Spacing +3 added lines, -3 removed lines

@@ -40,7 +40,7 @@ 
     public function __construct()
     {
         if (!function_exists('openssl_random_pseudo_bytes')) {
-            throw new FacebookSDKException(static::ERROR_MESSAGE . 'The function openssl_random_pseudo_bytes() does not exist.');
+            throw new FacebookSDKException(static::ERROR_MESSAGE.'The function openssl_random_pseudo_bytes() does not exist.');
         }
     }
 
@@ -55,11 +55,11 @@ 
         $binaryString = openssl_random_pseudo_bytes($length, $wasCryptographicallyStrong);
 
         if ($binaryString === false) {
-            throw new FacebookSDKException(static::ERROR_MESSAGE . 'openssl_random_pseudo_bytes() returned an unknown error.');
+            throw new FacebookSDKException(static::ERROR_MESSAGE.'openssl_random_pseudo_bytes() returned an unknown error.');
         }
 
         if ($wasCryptographicallyStrong !== true) {
-            throw new FacebookSDKException(static::ERROR_MESSAGE . 'openssl_random_pseudo_bytes() returned a pseudo-random string but it was not cryptographically secure and cannot be used.');
+            throw new FacebookSDKException(static::ERROR_MESSAGE.'openssl_random_pseudo_bytes() returned a pseudo-random string but it was not cryptographically secure and cannot be used.');
         }
 
         return $this->binToHex($binaryString, $length);

src/Facebook/PseudoRandomString/McryptPseudoRandomStringGenerator.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
     {
         if (!function_exists('mcrypt_create_iv')) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'The function mcrypt_create_iv() does not exist.'
             );
         }
@@ -58,7 +58,7 @@ 
 
         if ($binaryString === false) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'mcrypt_create_iv() returned an error.'
             );
         }

src/Facebook/PseudoRandomString/UrandomPseudoRandomStringGenerator.php

Spacing +4 added lines, -4 removed lines

@@ -42,14 +42,14 @@ 
     {
         if (ini_get('open_basedir')) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'There is an open_basedir constraint that prevents access to /dev/urandom.'
             );
         }
 
         if (!is_readable('/dev/urandom')) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'Unable to read from /dev/urandom.'
             );
         }
@@ -65,7 +65,7 @@ 
         $stream = fopen('/dev/urandom', 'rb');
         if (!is_resource($stream)) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'Unable to open stream to /dev/urandom.'
             );
         }
@@ -79,7 +79,7 @@ 
 
         if (!$binaryString) {
             throw new FacebookSDKException(
-                static::ERROR_MESSAGE .
+                static::ERROR_MESSAGE.
                 'Stream to /dev/urandom returned no data.'
             );
         }

src/Facebook/GraphNodes/GraphNodeFactory.php

Spacing +10 added lines, -10 removed lines

@@ -104,7 +104,7 @@ 
      */
     public function makeGraphAchievement()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphAchievement');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphAchievement');
     }
 
     /**
@@ -116,7 +116,7 @@ 
      */
     public function makeGraphAlbum()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphAlbum');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphAlbum');
     }
 
     /**
@@ -128,7 +128,7 @@ 
      */
     public function makeGraphPage()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphPage');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphPage');
     }
 
     /**
@@ -140,7 +140,7 @@ 
      */
     public function makeGraphSessionInfo()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphSessionInfo');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphSessionInfo');
     }
 
     /**
@@ -152,7 +152,7 @@ 
      */
     public function makeGraphUser()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphUser');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphUser');
     }
 
     /**
@@ -164,7 +164,7 @@ 
      */
     public function makeGraphEvent()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphEvent');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphEvent');
     }
 
     /**
@@ -176,7 +176,7 @@ 
      */
     public function makeGraphGroup()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphGroup');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphGroup');
     }
 
     /**
@@ -195,7 +195,7 @@ 
         $this->validateResponseCastableAsGraphEdge();
 
         if ($subclassName && $auto_prefix) {
-            $subclassName = static::BASE_GRAPH_OBJECT_PREFIX . $subclassName;
+            $subclassName = static::BASE_GRAPH_OBJECT_PREFIX.$subclassName;
         }
 
         return $this->castAsGraphNodeOrGraphEdge($this->decodedBody, $subclassName);
@@ -337,7 +337,7 @@ 
         $metaData = $this->getMetaData($data);
 
         // We'll need to make an edge endpoint for this in case it's a GraphEdge (for cursor pagination)
-        $parentGraphEdgeEndpoint = $parentNodeId && $parentKey ? '/' . $parentNodeId . '/' . $parentKey : null;
+        $parentGraphEdgeEndpoint = $parentNodeId && $parentKey ? '/'.$parentNodeId.'/'.$parentKey : null;
         $className = static::BASE_GRAPH_EDGE_CLASS;
 
         return new $className($this->response->getRequest(), $dataList, $metaData, $parentGraphEdgeEndpoint, $subclassName);
@@ -387,6 +387,6 @@ 
             return;
         }
 
-        throw new FacebookSDKException('The given subclass "' . $subclassName . '" is not valid. Cannot cast to an object that is not a GraphNode subclass.', 620);
+        throw new FacebookSDKException('The given subclass "'.$subclassName.'" is not valid. Cannot cast to an object that is not a GraphNode subclass.', 620);
     }
 }

src/Facebook/GraphNodes/GraphObjectFactory.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
      */
     public function makeGraphEvent()
     {
-        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX . 'GraphEvent');
+        return $this->makeGraphNode(static::BASE_GRAPH_OBJECT_PREFIX.'GraphEvent');
     }
 
     /**

src/Facebook/FacebookClient.php

Spacing +2 added lines, -2 removed lines

@@ -163,13 +163,13 @@
     public function prepareRequestMessage(FacebookRequest $request)
     {
         $postToVideoUrl = $request->containsVideoUploads();
-        $url = $this->getBaseGraphUrl($postToVideoUrl) . $request->getUrl();
+        $url = $this->getBaseGraphUrl($postToVideoUrl).$request->getUrl();
 
         // If we're sending files they should be sent as multipart/form-data
         if ($request->containsFileUploads()) {
             $requestBody = $request->getMultipartBody();
             $request->setHeaders([
-                'Content-Type' => 'multipart/form-data; boundary=' . $requestBody->getBoundary(),
+                'Content-Type' => 'multipart/form-data; boundary='.$requestBody->getBoundary(),
             ]);
         } else {
             $requestBody = $request->getUrlEncodedBody();

src/Facebook/FacebookResponse.php

Doc Comments +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
     /**
      * Returns the exception that was thrown for this request.
      *
-     * @return FacebookResponseException|null
+     * @return FacebookSDKException
      */
     public function getThrownException()
     {

tests/FacebookBatchRequestTest.php

Doc Comments +6 added lines

@@ -328,6 +328,9 @@ 
         $this->assertEquals($expectedBatchParams, $params);
     }
 
+    /**
+     * @param string $expectedToken
+     */
     private function assertRequestContainsAppAndToken(FacebookRequest $request, FacebookApp $expectedApp, $expectedToken)
     {
         $app = $request->getApp();
@@ -347,6 +350,9 @@ 
         return $headers;
     }
 
+    /**
+     * @param integer $number
+     */
     private function createAndAppendRequestsTo(FacebookBatchRequest $batchRequest, $number)
     {
         for ($i = 0; $i < $number; $i++) {

Spacing +11 added lines, -11 removed lines

@@ -224,7 +224,7 @@ 
                 [
                     'headers' => $headers,
                     'method' => 'GET',
-                    'relative_url' => '/' . $apiVersion . '/foo?foo=bar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
+                    'relative_url' => '/'.$apiVersion.'/foo?foo=bar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
                     'name' => 'foo_name',
                 ],
             ],
@@ -233,7 +233,7 @@ 
                 [
                     'headers' => $headers,
                     'method' => 'POST',
-                    'relative_url' => '/' . $apiVersion . '/bar',
+                    'relative_url' => '/'.$apiVersion.'/bar',
                     'body' => 'bar=baz&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
                     'name' => 'foo_name',
                 ],
@@ -243,7 +243,7 @@ 
                 [
                     'headers' => $headers,
                     'method' => 'DELETE',
-                    'relative_url' => '/' . $apiVersion . '/bar?access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
+                    'relative_url' => '/'.$apiVersion.'/bar?access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
                     'name' => 'foo_name',
                 ],
             ],
@@ -254,7 +254,7 @@ 
     {
         $request = new FacebookRequest(null, null, 'POST', '/bar', [
             'message' => 'foobar',
-            'source' => new FacebookFile(__DIR__ . '/foo.txt'),
+            'source' => new FacebookFile(__DIR__.'/foo.txt'),
         ]);
 
         $batchRequest = $this->createBatchRequest();
@@ -273,7 +273,7 @@ 
         $this->assertEquals([
             'headers' => $this->defaultHeaders(),
             'method' => 'POST',
-            'relative_url' => '/' . Facebook::DEFAULT_GRAPH_VERSION . '/bar',
+            'relative_url' => '/'.Facebook::DEFAULT_GRAPH_VERSION.'/bar',
             'body' => 'message=foobar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
             'name' => 'foo_name',
             'attached_files' => $attachedFiles,
@@ -292,8 +292,8 @@ 
         $expectedHeaders = json_encode($this->defaultHeaders());
         $version = Facebook::DEFAULT_GRAPH_VERSION;
         $expectedBatchParams = [
-            'batch' => '[{"headers":' . $expectedHeaders . ',"method":"GET","relative_url":"\\/' . $version . '\\/foo?access_token=bar_token&appsecret_proof=2ceec40b7b9fd7d38fff1767b766bcc6b1f9feb378febac4612c156e6a8354bd","name":"foo_name"},'
-                . '{"headers":' . $expectedHeaders . ',"method":"POST","relative_url":"\\/' . $version . '\\/bar","body":"foo=bar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9"}]',
+            'batch' => '[{"headers":'.$expectedHeaders.',"method":"GET","relative_url":"\\/'.$version.'\\/foo?access_token=bar_token&appsecret_proof=2ceec40b7b9fd7d38fff1767b766bcc6b1f9feb378febac4612c156e6a8354bd","name":"foo_name"},'
+                . '{"headers":'.$expectedHeaders.',"method":"POST","relative_url":"\\/'.$version.'\\/bar","body":"foo=bar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9"}]',
             'include_headers' => true,
             'access_token' => 'foo_token',
             'appsecret_proof' => 'df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
@@ -307,7 +307,7 @@ 
         $batchRequest->add(new FacebookRequest(null, 'bar_token', 'GET', '/foo'), 'foo_name');
         $batchRequest->add(new FacebookRequest(null, null, 'POST', '/me/photos', [
             'message' => 'foobar',
-            'source' => new FacebookFile(__DIR__ . '/foo.txt'),
+            'source' => new FacebookFile(__DIR__.'/foo.txt'),
         ]));
         $batchRequest->prepareRequestsForBatch();
 
@@ -319,8 +319,8 @@ 
         $expectedHeaders = json_encode($this->defaultHeaders());
         $version = Facebook::DEFAULT_GRAPH_VERSION;
         $expectedBatchParams = [
-            'batch' => '[{"headers":' . $expectedHeaders . ',"method":"GET","relative_url":"\\/' . $version . '\\/foo?access_token=bar_token&appsecret_proof=2ceec40b7b9fd7d38fff1767b766bcc6b1f9feb378febac4612c156e6a8354bd","name":"foo_name"},'
-                . '{"headers":' . $expectedHeaders . ',"method":"POST","relative_url":"\\/' . $version . '\\/me\\/photos","body":"message=foobar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9","attached_files":"' . $attachedFiles . '"}]',
+            'batch' => '[{"headers":'.$expectedHeaders.',"method":"GET","relative_url":"\\/'.$version.'\\/foo?access_token=bar_token&appsecret_proof=2ceec40b7b9fd7d38fff1767b766bcc6b1f9feb378febac4612c156e6a8354bd","name":"foo_name"},'
+                . '{"headers":'.$expectedHeaders.',"method":"POST","relative_url":"\\/'.$version.'\\/me\\/photos","body":"message=foobar&access_token=foo_token&appsecret_proof=df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9","attached_files":"'.$attachedFiles.'"}]',
             'include_headers' => true,
             'access_token' => 'foo_token',
             'appsecret_proof' => 'df4256903ba4e23636cc142117aa632133d75c642bd2a68955be1443bd14deb9',
@@ -341,7 +341,7 @@ 
     {
         $headers = [];
         foreach (FacebookRequest::getDefaultHeaders() as $name => $value) {
-            $headers[] = $name . ': ' . $value;
+            $headers[] = $name.': '.$value;
         }
 
         return $headers;

tests/Http/RequestUrlEncodedTest.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
     {
         $message = new RequestBodyUrlEncoded([
             'foo' => 'bar',
-            'faz' => [1,2,3],
+            'faz' => [1, 2, 3],
             'targeting' => [
               'countries' => 'US,GB',
               'age_min' => 13,