Completed
Pull Request — master (#191)
by Emanuele
03:10
created
src/FacebookAds/Object/Traits/CannotDelete.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -24,10 +24,8 @@
 block discarded – undo
24 24
 
25 25
 namespace FacebookAds\Object\Traits;
26 26
 
27
-trait CannotDelete
28
-{
29
-    public function delete(array $params = array())
30
-    {
27
+trait CannotDelete {
28
+    public function delete(array $params = array()) {
31 29
         throw new \Exception(
32 30
             __CLASS__.' does not have '.__FUNCTION__.' function.'
33 31
         );
Please login to merge, or discard this patch.
src/FacebookAds/Object/Traits/FieldValidation.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -29,16 +29,14 @@
 block discarded – undo
29 29
 /**
30 30
  * @method static EnumInstanceInterface getFieldsEnum()
31 31
  */
32
-trait FieldValidation
33
-{
32
+trait FieldValidation {
34 33
     /**
35 34
      * @param string $name
36 35
      * @param mixed $value
37 36
      * @throws \InvalidArgumentException
38 37
      * @staticvar array $fields
39 38
      */
40
-    public function __set($name, $value)
41
-    {
39
+    public function __set($name, $value) {
42 40
         if (static::getFieldsEnum()->isValidValue($name)) {
43 41
             parent::__set($name, $value);
44 42
         } else {
Please login to merge, or discard this patch.
src/FacebookAds/Object/PartnerCategory.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,8 +30,7 @@  discard block
 block discarded – undo
30 30
 use FacebookAds\Object\Traits\CannotUpdate;
31 31
 use FacebookAds\Object\Traits\FieldValidation;
32 32
 
33
-class PartnerCategory extends AbstractCrudObject
34
-{
33
+class PartnerCategory extends AbstractCrudObject {
35 34
     use CannotCreate;
36 35
     use CannotDelete;
37 36
     use CannotUpdate;
@@ -40,16 +39,14 @@  discard block
 block discarded – undo
40 39
     /**
41 40
      * @return string
42 41
      */
43
-    protected function getEndpoint()
44
-    {
42
+    protected function getEndpoint() {
45 43
         return 'partnercategories';
46 44
     }
47 45
 
48 46
     /**
49 47
      * @return PartnerCategoryFields
50 48
      */
51
-    public static function getFieldsEnum()
52
-    {
49
+    public static function getFieldsEnum() {
53 50
         return PartnerCategoryFields::getInstance();
54 51
     }
55 52
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/ProductFeedUpload.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -30,24 +30,21 @@  discard block
 block discarded – undo
30 30
 use FacebookAds\Object\Traits\CannotDelete;
31 31
 use FacebookAds\Object\Traits\CannotUpdate;
32 32
 
33
-class ProductFeedUpload extends AbstractCrudObject
34
-{
33
+class ProductFeedUpload extends AbstractCrudObject {
35 34
     use CannotDelete;
36 35
     use CannotUpdate;
37 36
 
38 37
     /**
39 38
      * @return string
40 39
      */
41
-    protected function getEndpoint()
42
-    {
40
+    protected function getEndpoint() {
43 41
         return 'uploads';
44 42
     }
45 43
 
46 44
     /**
47 45
      * @return ProductFeedUploadFields
48 46
      */
49
-    public static function getFieldsEnum()
50
-    {
47
+    public static function getFieldsEnum() {
51 48
         return ProductFeedUploadFields::getInstance();
52 49
     }
53 50
 
@@ -56,8 +53,7 @@  discard block
 block discarded – undo
56 53
      * @param array $params
57 54
      * @return Cursor
58 55
      */
59
-    public function getErrors(array $fields = array(), array $params = array())
60
-    {
56
+    public function getErrors(array $fields = array(), array $params = array()) {
61 57
         return $this->getManyByConnection(
62 58
             ProductFeedUploadError::className(), $fields, $params);
63 59
     }
Please login to merge, or discard this patch.
src/FacebookAds/Object/Lead.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,8 +29,7 @@  discard block
 block discarded – undo
29 29
 use FacebookAds\Object\Traits\CannotDelete;
30 30
 use FacebookAds\Object\Traits\CannotUpdate;
31 31
 
32
-class Lead extends AbstractCrudObject
33
-{
32
+class Lead extends AbstractCrudObject {
34 33
     use CannotCreate;
35 34
     use CannotUpdate;
36 35
     use CannotDelete;
@@ -38,16 +37,14 @@  discard block
 block discarded – undo
38 37
     /**
39 38
      * @return string
40 39
      */
41
-    protected function getEndpoint()
42
-    {
40
+    protected function getEndpoint() {
43 41
         return 'leads';
44 42
     }
45 43
 
46 44
     /**
47 45
      * @return LeadFields
48 46
      */
49
-    public static function getFieldsEnum()
50
-    {
47
+    public static function getFieldsEnum() {
51 48
         return LeadFields::getInstance();
52 49
     }
53 50
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/LookalikeAudience.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,21 +26,18 @@
 block discarded – undo
26 26
 
27 27
 use FacebookAds\Object\Fields\LookalikeAudienceFields;
28 28
 
29
-class LookalikeAudience extends AbstractCrudObject
30
-{
29
+class LookalikeAudience extends AbstractCrudObject {
31 30
     /**
32 31
      * @return string
33 32
      */
34
-    protected function getEndpoint()
35
-    {
33
+    protected function getEndpoint() {
36 34
         return 'customaudiences';
37 35
     }
38 36
 
39 37
     /**
40 38
      * @return LookalikeAudienceFields
41 39
      */
42
-    public static function getFieldsEnum()
43
-    {
40
+    public static function getFieldsEnum() {
44 41
         return LookalikeAudienceFields::getInstance();
45 42
     }
46 43
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/Insights.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,13 +26,11 @@
 block discarded – undo
26 26
 
27 27
 use FacebookAds\Object\Fields\InsightsFields;
28 28
 
29
-class Insights extends AbstractObject
30
-{
29
+class Insights extends AbstractObject {
31 30
     /**
32 31
      * @return InsightsFields
33 32
      */
34
-    public static function getFieldsEnum()
35
-    {
33
+    public static function getFieldsEnum() {
36 34
         return InsightsFields::getInstance();
37 35
     }
38 36
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/ConnectionObject.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,15 +27,13 @@
 block discarded – undo
27 27
 use FacebookAds\Object\Fields\ConnectionObjectFields;
28 28
 use FacebookAds\Object\Traits\FieldValidation;
29 29
 
30
-class ConnectionObject extends AbstractObject
31
-{
30
+class ConnectionObject extends AbstractObject {
32 31
     use FieldValidation;
33 32
 
34 33
     /**
35 34
      * @return ConnectionObjectFields
36 35
      */
37
-    public static function getFieldsEnum()
38
-    {
36
+    public static function getFieldsEnum() {
39 37
         return ConnectionObjectFields::getInstance();
40 38
     }
41 39
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/TargetingSearch.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,7 @@
 block discarded – undo
28 28
 use FacebookAds\Cursor;
29 29
 use FacebookAds\Http\RequestInterface;
30 30
 
31
-class TargetingSearch extends AbstractObject
32
-{
31
+class TargetingSearch extends AbstractObject {
33 32
     /**
34 33
      * @param string $query
35 34
      * @param string $type
Please login to merge, or discard this patch.