Completed
Pull Request — master (#191)
by Emanuele
03:10
created
src/FacebookAds/Object/CustomAudienceNormalizers/MadidNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class MadidNormalizer implements ValueNormalizerInterface
32
-{
31
+class MadidNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::MADID;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return strtolower(trim($key_value));
51 48
     }
52 49
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/CustomAudienceNormalizers/StateNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class StateNormalizer implements ValueNormalizerInterface
32
-{
31
+class StateNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::STATE;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return preg_replace('/[^a-zA-Z]/', '', strtolower(trim($key_value)));
51 48
     }
52 49
 }
Please login to merge, or discard this patch.
FacebookAds/Object/CustomAudienceNormalizers/FirstNameInitialNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class FirstNameInitialNormalizer implements ValueNormalizerInterface
32
-{
31
+class FirstNameInitialNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::FIRST_NAME_INITIAL;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return preg_replace(
51 48
             '/[^a-zA-Z]/',
52 49
             '',
Please login to merge, or discard this patch.
src/FacebookAds/Object/CustomAudienceNormalizers/DateNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class DateNormalizer implements ValueNormalizerInterface
32
-{
31
+class DateNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return in_array($key, array(
41 39
             CustomAudienceMultikeySchemaFields::BIRTH_DATE,
42 40
             CustomAudienceMultikeySchemaFields::BIRTH_MONTH
@@ -48,8 +46,7 @@  discard block
 block discarded – undo
48 46
      * @param string $key_value
49 47
      * @return string
50 48
      */
51
-    public function normalize($key, $key_value)
52
-    {
49
+    public function normalize($key, $key_value) {
53 50
         return str_pad(
54 51
             preg_replace('/[^0-9]/', '', $key_value),
55 52
             2,
Please login to merge, or discard this patch.
src/FacebookAds/Object/CustomAudienceNormalizers/CityNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class CityNormalizer implements ValueNormalizerInterface
32
-{
31
+class CityNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::CITY;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return preg_replace('/[^a-zA-Z]/', '', strtolower(trim($key_value)));
51 48
     }
52 49
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/CustomAudienceNormalizers/GenderNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class GenderNormalizer implements ValueNormalizerInterface
32
-{
31
+class GenderNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::GENDER;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return substr($key_value, 0, 1);
51 48
     }
52 49
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/CustomAudienceNormalizers/EmailNormalizer.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,15 +28,13 @@  discard block
 block discarded – undo
28 28
 use FacebookAds\Object\CustomAudienceNormalizers\ValueNormalizerInterface;
29 29
 use FacebookAds\Object\Fields\CustomAudienceMultikeySchemaFields;
30 30
 
31
-class EmailNormalizer implements ValueNormalizerInterface
32
-{
31
+class EmailNormalizer implements ValueNormalizerInterface {
33 32
     /**
34 33
      * @param string $key
35 34
      * @param string $key_value
36 35
      * @return boolean
37 36
      */
38
-    public function shouldNormalize($key, $key_value)
39
-    {
37
+    public function shouldNormalize($key, $key_value) {
40 38
         return $key === CustomAudienceMultikeySchemaFields::EMAIL;
41 39
     }
42 40
 
@@ -45,8 +43,7 @@  discard block
 block discarded – undo
45 43
      * @param string $key_value
46 44
      * @return string
47 45
      */
48
-    public function normalize($key, $key_value)
49
-    {
46
+    public function normalize($key, $key_value) {
50 47
         return trim(strtolower($key_value), ' \t\r\n\0\x0B.');
51 48
     }
52 49
 }
Please login to merge, or discard this patch.
src/FacebookAds/Object/AbstractAsyncJobObject.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -27,8 +27,7 @@  discard block
 block discarded – undo
27 27
 use FacebookAds\Http\RequestInterface;
28 28
 use FacebookAds\Object\Traits\CannotUpdate;
29 29
 
30
-abstract class AbstractAsyncJobObject extends AbstractCrudObject
31
-{
30
+abstract class AbstractAsyncJobObject extends AbstractCrudObject {
32 31
     use CannotUpdate;
33 32
 
34 33
     /**
@@ -39,8 +38,7 @@  discard block
 block discarded – undo
39 38
     /**
40 39
      * @return string
41 40
      */
42
-    protected function getCompletitionPercentageFieldName()
43
-    {
41
+    protected function getCompletitionPercentageFieldName() {
44 42
         return 'async_percent_completion';
45 43
     }
46 44
 
@@ -51,8 +49,7 @@  discard block
 block discarded – undo
51 49
      * @return $this
52 50
      * @throws \Exception
53 51
      */
54
-    public function create(array $params = array())
55
-    {
52
+    public function create(array $params = array()) {
56 53
         if ($this->data[static::FIELD_ID]) {
57 54
             throw new \Exception("Object has already an ID");
58 55
         }
@@ -73,8 +70,7 @@  discard block
 block discarded – undo
73 70
      * This method won't fetch new data, you are required to call read() before
74 71
      * @return bool
75 72
      */
76
-    public function isComplete()
77
-    {
73
+    public function isComplete() {
78 74
         return $this->{$this->getCompletitionPercentageFieldName()} === 100;
79 75
     }
80 76
 
Please login to merge, or discard this patch.
src/FacebookAds/Object/AbstractArchivableCrudObject.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
 use FacebookAds\Http\RequestInterface;
28 28
 
29
-abstract class AbstractArchivableCrudObject extends AbstractCrudObject
30
-{
29
+abstract class AbstractArchivableCrudObject extends AbstractCrudObject {
31 30
     /**
32 31
      * @var string
33 32
      */
@@ -56,8 +55,7 @@  discard block
 block discarded – undo
56 55
     /**
57 56
      * @return string
58 57
      */
59
-    public function getStatusParamName()
60
-    {
58
+    public function getStatusParamName() {
61 59
         return self::STATUS_PARAM_NAME;
62 60
     }
63 61
 
@@ -67,8 +65,7 @@  discard block
 block discarded – undo
67 65
      * @param array $params
68 66
      * @return void
69 67
      */
70
-    public function archive(array $params = array())
71
-    {
68
+    public function archive(array $params = array()) {
72 69
         $this->getApi()->call(
73 70
             $this->getNodePath(),
74 71
             RequestInterface::METHOD_POST,
@@ -84,8 +81,7 @@  discard block
 block discarded – undo
84 81
      * @param array $params
85 82
      * @return void
86 83
      */
87
-    public function delete(array $params = array())
88
-    {
84
+    public function delete(array $params = array()) {
89 85
         $this->getApi()->call(
90 86
             $this->getNodePath(),
91 87
             RequestInterface::METHOD_POST,
Please login to merge, or discard this patch.