Issues in CompilerEngine.php (master) - Issues in master - facade/ignition - Measure and Improve Code Quality continuously with Scrutinizer

Issues (38)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Views/Engines/CompilerEngine.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Facade\Ignition\Views\Engines;

use Exception;
use Facade\Ignition\Exceptions\ViewException;
use Facade\Ignition\Exceptions\ViewExceptionWithSolution;
use Facade\Ignition\Views\Compilers\BladeSourceMapCompiler;
use Facade\Ignition\Views\Concerns\CollectsViewExceptions;
use Facade\IgnitionContracts\ProvidesSolution;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Arr;
use Illuminate\Support\Collection;
use ReflectionProperty;
use Throwable;

class CompilerEngine extends \Illuminate\View\Engines\CompilerEngine
{
    use CollectsViewExceptions;

    protected $currentPath = null;

    /**
     * Get the evaluated contents of the view.
     *
     * @param  string $path
     * @param  array $data
     *
     * @return string
     */
    public function get($path, array $data = [])
    {
        $this->currentPath = $path;

        $this->collectViewData($path, $data);

        return parent::get($path, $data);
    }

    /**
     * Handle a view exception.
     *
     * @param  \Exception $baseException
     * @param  int $obLevel
     *
     * @return void
     *
     * @throws \Exception
     */
    protected function handleViewException(Throwable $baseException, $obLevel)
    {
        while (ob_get_level() > $obLevel) {
            ob_end_clean();
        }

        if ($baseException instanceof ViewException) {
            throw $baseException;
        }

        $viewExceptionClass = ViewException::class;

        if (in_array(ProvidesSolution::class, class_implements($baseException))) {
            $viewExceptionClass = ViewExceptionWithSolution::class;
        }

        $exception = new $viewExceptionClass(
            $this->getMessage($baseException),
            0,
            1,
            $this->getCompiledViewName($baseException->getFile()),
            $this->getBladeLineNumber($baseException->getFile(), $baseException->getLine()),
            $baseException
        );

        if ($viewExceptionClass === ViewExceptionWithSolution::class) {
            $exception->setSolution($baseException->getSolution());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        $this->modifyViewsInTrace($exception);

        $exception->setView($this->getCompiledViewName($baseException->getFile()));
        $exception->setViewData($this->getCompiledViewData($baseException->getFile()));

        throw $exception;
    }

    protected function getBladeLineNumber(string $compiledPath, int $exceptionLineNumber): int
    {
        $viewPath = $this->getCompiledViewName($compiledPath);

        if (! $viewPath) {
            return $exceptionLineNumber;
        }

        $sourceMapCompiler = new BladeSourceMapCompiler(app(Filesystem::class), 'not-needed');

        return $sourceMapCompiler->detectLineNumber($viewPath, $exceptionLineNumber);
    }

    protected function modifyViewsInTrace(ViewException $exception)
    {
        $trace = Collection::make($exception->getPrevious()->getTrace())
            ->map(function ($trace) {
                if ($compiledData = $this->findCompiledView(Arr::get($trace, 'file', ''))) {
                    $trace['file'] = $compiledData['path'];
                    $trace['line'] = $this->getBladeLineNumber($trace['file'], $trace['line']);
                }

                return $trace;
            })->toArray();

        $traceProperty = new ReflectionProperty('Exception', 'trace');
        $traceProperty->setAccessible(true);
        $traceProperty->setValue($exception, $trace);
    }
}


1			<?php
2
3			namespace Facade\Ignition\Views\Engines;
4
5			use Exception;
6			use Facade\Ignition\Exceptions\ViewException;
7			use Facade\Ignition\Exceptions\ViewExceptionWithSolution;
8			use Facade\Ignition\Views\Compilers\BladeSourceMapCompiler;
9			use Facade\Ignition\Views\Concerns\CollectsViewExceptions;
10			use Facade\IgnitionContracts\ProvidesSolution;
11			use Illuminate\Filesystem\Filesystem;
12			use Illuminate\Support\Arr;
13			use Illuminate\Support\Collection;
14			use ReflectionProperty;
15			use Throwable;
16
17			class CompilerEngine extends \Illuminate\View\Engines\CompilerEngine
18			{
19			use CollectsViewExceptions;
20
21			protected $currentPath = null;
22
23			/**
24			* Get the evaluated contents of the view.
25			*
26			* @param string $path
27			* @param array $data
28			*
29			* @return string
30			*/
31			public function get($path, array $data = [])
32			{
33			$this->currentPath = $path;
34
35			$this->collectViewData($path, $data);
36
37			return parent::get($path, $data);
38			}
39
40			/**
41			* Handle a view exception.
42			*
43			* @param \Exception $baseException
44			* @param int $obLevel
45			*
46			* @return void
47			*
48			* @throws \Exception
49			*/
50			protected function handleViewException(Throwable $baseException, $obLevel)
51			{
52			while (ob_get_level() > $obLevel) {
53			ob_end_clean();
54			}
55
56			if ($baseException instanceof ViewException) {
57			throw $baseException;
58			}
59
60			$viewExceptionClass = ViewException::class;
61
62			if (in_array(ProvidesSolution::class, class_implements($baseException))) {
63			$viewExceptionClass = ViewExceptionWithSolution::class;
64			}
65
66			$exception = new $viewExceptionClass(
67			$this->getMessage($baseException),
68			0,
69			1,
70			$this->getCompiledViewName($baseException->getFile()),
71			$this->getBladeLineNumber($baseException->getFile(), $baseException->getLine()),
72			$baseException
73			);
74
75			if ($viewExceptionClass === ViewExceptionWithSolution::class) {
76			$exception->setSolution($baseException->getSolution());
			0 ignored issues – show Bug introduced 2020-01-20 17:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Throwable` as the method `getSolution()` does only exist in the following implementations of said interface: `Facade\Ignition\Exceptions\InvalidConfig`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
77			}
78
79			$this->modifyViewsInTrace($exception);
80
81			$exception->setView($this->getCompiledViewName($baseException->getFile()));
82			$exception->setViewData($this->getCompiledViewData($baseException->getFile()));
83
84			throw $exception;
85			}
86
87			protected function getBladeLineNumber(string $compiledPath, int $exceptionLineNumber): int
88			{
89			$viewPath = $this->getCompiledViewName($compiledPath);
90
91			if (! $viewPath) {
92			return $exceptionLineNumber;
93			}
94
95			$sourceMapCompiler = new BladeSourceMapCompiler(app(Filesystem::class), 'not-needed');
96
97			return $sourceMapCompiler->detectLineNumber($viewPath, $exceptionLineNumber);
98			}
99
100			protected function modifyViewsInTrace(ViewException $exception)
101			{
102			$trace = Collection::make($exception->getPrevious()->getTrace())
103			->map(function ($trace) {
104			if ($compiledData = $this->findCompiledView(Arr::get($trace, 'file', ''))) {
105			$trace['file'] = $compiledData['path'];
106			$trace['line'] = $this->getBladeLineNumber($trace['file'], $trace['line']);
107			}
108
109			return $trace;
110			})->toArray();
111
112			$traceProperty = new ReflectionProperty('Exception', 'trace');
113			$traceProperty->setAccessible(true);
114			$traceProperty->setValue($exception, $trace);
115			}
116			}
117

facade / ignition

Issues (38)

Security Analysis not enabled

src/Views/Engines/CompilerEngine.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like