UndefinedVariableSolutionProvider::getNameAndView() - Code Metrics - Inspection of "Automatically fix blade variable typos and optiona..." - facade/ignition - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#38)

by James

created 2019-09-01 15:14 UTC

getNameAndView() A

↳ Parent: UndefinedVariableSolutionProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Facade\Ignition\SolutionProviders;

use Throwable;
use Facade\IgnitionContracts\Solution;
use Facade\IgnitionContracts\BaseSolution;
use Facade\Ignition\Exceptions\ViewException;
use Facade\IgnitionContracts\HasSolutionsForThrowable;
use Facade\Ignition\Solutions\MakeViewVariableOptionalSolution;
use Facade\Ignition\Solutions\SuggestCorrectVariableNameSolution;

class UndefinedVariableSolutionProvider implements HasSolutionsForThrowable
{
    private $variableName;

    private $viewFile;

    public function canSolve(Throwable $throwable): bool
    {
        if (! $throwable instanceof ViewException) {
            return false;
        }

        return $this->getNameAndView($throwable) !== null;
    }

    public function getSolutions(Throwable $throwable): array
    {
        $solutions = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        extract($this->getNameAndView($throwable));

        $solutions = collect($throwable->getViewData())->map(function ($value, $key) use ($variableName) {
            similar_text($variableName, $key, $percentage);

            return ['match' => $percentage, 'value' => $value];
        })->sortByDesc('match')->filter(function ($var, $key) {

            return $var['match'] > 40;
        })->keys()->map(function ($suggestion) use ($variableName, $viewFile) {
            return new SuggestCorrectVariableNameSolution($variableName, $viewFile, $suggestion);
        })->map(function ($solution) {
            // If the solution isn't runnable, then just return the suggestions without the fix
            if ($solution->isRunnable()) {
                return $solution;
            } else {
                return BaseSolution::create($solution->getSolutionTitle())
                    ->setSolutionDescription($solution->getSolutionActionDescription());
            }
        })->toArray();

        $optionalSolution = new MakeViewVariableOptionalSolution($variableName, $viewFile);
        if ($optionalSolution->isRunnable()) {
            $solutions[] = $optionalSolution;
        } else {
            $solutions[] = BaseSolution::create($optionalSolution->getSolutionTitle())
                ->setSolutionDescription($optionalSolution->getSolutionActionDescription());
        }

        return $solutions;
    }

    private function getNameAndView(Throwable $throwable)
    {
        $pattern = '/Undefined variable: (.*?) \(View: (.*?)\)/';

        preg_match($pattern, $throwable->getMessage(), $matches);
        if (count($matches) === 3) {
            [$string, $variableName, $viewFile] = $matches;


            return compact('variableName', 'viewFile');
        }
    }
}


1			<?php
2
3			namespace Facade\Ignition\SolutionProviders;
4
5			use Throwable;
6			use Facade\IgnitionContracts\Solution;
7			use Facade\IgnitionContracts\BaseSolution;
8			use Facade\Ignition\Exceptions\ViewException;
9			use Facade\IgnitionContracts\HasSolutionsForThrowable;
10			use Facade\Ignition\Solutions\MakeViewVariableOptionalSolution;
11			use Facade\Ignition\Solutions\SuggestCorrectVariableNameSolution;
12
13			class UndefinedVariableSolutionProvider implements HasSolutionsForThrowable
14			{
15			private $variableName;
16
17			private $viewFile;
18
19			public function canSolve(Throwable $throwable): bool
20			{
21			if (! $throwable instanceof ViewException) {
22			return false;
23			}
24
25			return $this->getNameAndView($throwable) !== null;
26			}
27
28			public function getSolutions(Throwable $throwable): array
29			{
30			$solutions = [];
			0 ignored issues – show Unused Code introduced 2019-09-01 13:44 UTC by Report Bug Copy Issue Report `$solutions` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31
32			extract($this->getNameAndView($throwable));
			0 ignored issues – show Bug introduced 2019-09-01 13:44 UTC by Report Bug Copy Issue Report `$this->getNameAndView($throwable)` cannot be passed to `extract()` as the parameter `$var_array` expects a reference. Loading history...
33			$solutions = collect($throwable->getViewData())->map(function ($value, $key) use ($variableName) {
34			similar_text($variableName, $key, $percentage);
35
36			return ['match' => $percentage, 'value' => $value];
37			})->sortByDesc('match')->filter(function ($var, $key) {
			0 ignored issues – show Unused Code introduced 2019-09-01 13:44 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38			return $var['match'] > 40;
39			})->keys()->map(function ($suggestion) use ($variableName, $viewFile) {
40			return new SuggestCorrectVariableNameSolution($variableName, $viewFile, $suggestion);
41			})->map(function ($solution) {
42			// If the solution isn't runnable, then just return the suggestions without the fix
43			if ($solution->isRunnable()) {
44			return $solution;
45			} else {
46			return BaseSolution::create($solution->getSolutionTitle())
47			->setSolutionDescription($solution->getSolutionActionDescription());
48			}
49			})->toArray();
50
51			$optionalSolution = new MakeViewVariableOptionalSolution($variableName, $viewFile);
52			if ($optionalSolution->isRunnable()) {
53			$solutions[] = $optionalSolution;
54			} else {
55			$solutions[] = BaseSolution::create($optionalSolution->getSolutionTitle())
56			->setSolutionDescription($optionalSolution->getSolutionActionDescription());
57			}
58
59			return $solutions;
60			}
61
62			private function getNameAndView(Throwable $throwable)
63			{
64			$pattern = '/Undefined variable: (.?) \(View: (.?)\)/';
65
66			preg_match($pattern, $throwable->getMessage(), $matches);
67			if (count($matches) === 3) {
68			[$string, $variableName, $viewFile] = $matches;
			0 ignored issues – show Bug introduced 2019-09-01 13:48 UTC by Report Bug Copy Issue Report The variable `$string` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2019-09-01 13:48 UTC by Report Bug Copy Issue Report The variable `$variableName` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2019-09-01 13:48 UTC by Report Bug Copy Issue Report The variable `$viewFile` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
69
70			return compact('variableName', 'viewFile');
71			}
72			}
73			}
74

facade / ignition

Pull Request — master (#38)

getNameAndView() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like