Inspection of "Load javascript assets via URL. Fixes #16" - facade/ignition - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36b547...bd3e66 )

by Marcel

created 2019-09-18 08:09 UTC

Status

Unused Use Statements +35 added lines, -35 removed lines patch added patch discarded remove patch

@@ -2,58 +2,58 @@
 block discarded – undo
 
 namespace Facade\Ignition;
 
-use Throwable;
-use Monolog\Logger;
-use Illuminate\Support\Arr;
 use Facade\FlareClient\Flare;
-use Illuminate\Log\LogManager;
-use Illuminate\Queue\QueueManager;
 use Facade\FlareClient\Http\Client;
-use Illuminate\Support\Facades\Log;
-use Whoops\Handler\HandlerInterface;
-use Illuminate\Support\Facades\Route;
-use Illuminate\Foundation\Application;
+use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
+use Facade\Ignition\Commands\TestCommand;
+use Facade\Ignition\Context\LaravelContextDetector;
+use Facade\Ignition\DumpRecorder\DumpRecorder;
+use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
 use Facade\Ignition\ErrorPage\Renderer;
-use Facade\Ignition\Middleware\AddLogs;
-use Illuminate\Support\ServiceProvider;
+use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
+use Facade\Ignition\Http\Controllers\HealthCheckController;
+use Facade\Ignition\Http\Controllers\IgnitionAssetsController;
+use Facade\Ignition\Http\Controllers\ScriptController;
+use Facade\Ignition\Http\Controllers\ShareReportController;
+use Facade\Ignition\Http\Controllers\StyleController;
+use Facade\Ignition\Http\Middleware\IgnitionEnabled;
+use Facade\Ignition\LogRecorder\LogRecorder;
 use Facade\Ignition\Logger\FlareHandler;
 use Facade\Ignition\Middleware\AddDumps;
-use Illuminate\Log\Events\MessageLogged;
-use Facade\Ignition\Commands\TestCommand;
+use Facade\Ignition\Middleware\AddEnvironmentInformation;
+use Facade\Ignition\Middleware\AddGitInformation;
+use Facade\Ignition\Middleware\AddLogs;
 use Facade\Ignition\Middleware\AddQueries;
-use Facade\Ignition\LogRecorder\LogRecorder;
 use Facade\Ignition\Middleware\AddSolutions;
-use Facade\Ignition\Views\Engines\PhpEngine;
-use Facade\Ignition\DumpRecorder\DumpRecorder;
 use Facade\Ignition\Middleware\SetNotifierName;
 use Facade\Ignition\QueryRecorder\QueryRecorder;
-use Facade\Ignition\Middleware\AddGitInformation;
-use Facade\Ignition\Views\Engines\CompilerEngine;
-use Facade\Ignition\Context\LaravelContextDetector;
-use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
-use Facade\Ignition\Http\Middleware\IgnitionEnabled;
-use Facade\Ignition\Http\Controllers\StyleController;
-use Facade\Ignition\Http\Controllers\ScriptController;
-use Facade\Ignition\Middleware\AddEnvironmentInformation;
-use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
-use Facade\Ignition\Http\Controllers\HealthCheckController;
-use Facade\Ignition\Http\Controllers\ShareReportController;
-use Facade\Ignition\Http\Controllers\IgnitionAssetsController;
-use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
-use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
-use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
 use Facade\Ignition\SolutionProviders\BadMethodCallSolutionProvider;
 use Facade\Ignition\SolutionProviders\DefaultDbNameSolutionProvider;
+use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
+use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
 use Facade\Ignition\SolutionProviders\MergeConflictSolutionProvider;
 use Facade\Ignition\SolutionProviders\MissingAppKeySolutionProvider;
 use Facade\Ignition\SolutionProviders\MissingColumnSolutionProvider;
 use Facade\Ignition\SolutionProviders\MissingImportSolutionProvider;
+use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
+use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
 use Facade\Ignition\SolutionProviders\TableNotFoundSolutionProvider;
+use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
+use Facade\Ignition\Views\Engines\CompilerEngine;
+use Facade\Ignition\Views\Engines\PhpEngine;
+use Illuminate\Foundation\Application;
+use Illuminate\Log\Events\MessageLogged;
+use Illuminate\Log\LogManager;
+use Illuminate\Queue\QueueManager;
+use Illuminate\Support\Arr;
+use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Facades\Route;
+use Illuminate\Support\ServiceProvider;
 use Illuminate\View\Engines\CompilerEngine as LaravelCompilerEngine;
-use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
-use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
-use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
-use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
+use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
+use Monolog\Logger;
+use Throwable;
+use Whoops\Handler\HandlerInterface;
 
 class IgnitionServiceProvider extends ServiceProvider
 {

Please login to merge, or discard this patch.

		@@ -2,58 +2,58 @@
		block discarded – undo
2	2
3	3	namespace Facade\Ignition;
4	4
5		-use Throwable;
6		-use Monolog\Logger;
7		-use Illuminate\Support\Arr;
8	5	use Facade\FlareClient\Flare;
9		-use Illuminate\Log\LogManager;
10		-use Illuminate\Queue\QueueManager;
11	6	use Facade\FlareClient\Http\Client;
12		-use Illuminate\Support\Facades\Log;
13		-use Whoops\Handler\HandlerInterface;
14		-use Illuminate\Support\Facades\Route;
15		-use Illuminate\Foundation\Application;
	7	+use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
	8	+use Facade\Ignition\Commands\TestCommand;
	9	+use Facade\Ignition\Context\LaravelContextDetector;
	10	+use Facade\Ignition\DumpRecorder\DumpRecorder;
	11	+use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
16	12	use Facade\Ignition\ErrorPage\Renderer;
17		-use Facade\Ignition\Middleware\AddLogs;
18		-use Illuminate\Support\ServiceProvider;
	13	+use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
	14	+use Facade\Ignition\Http\Controllers\HealthCheckController;
	15	+use Facade\Ignition\Http\Controllers\IgnitionAssetsController;
	16	+use Facade\Ignition\Http\Controllers\ScriptController;
	17	+use Facade\Ignition\Http\Controllers\ShareReportController;
	18	+use Facade\Ignition\Http\Controllers\StyleController;
	19	+use Facade\Ignition\Http\Middleware\IgnitionEnabled;
	20	+use Facade\Ignition\LogRecorder\LogRecorder;
19	21	use Facade\Ignition\Logger\FlareHandler;
20	22	use Facade\Ignition\Middleware\AddDumps;
21		-use Illuminate\Log\Events\MessageLogged;
22		-use Facade\Ignition\Commands\TestCommand;
	23	+use Facade\Ignition\Middleware\AddEnvironmentInformation;
	24	+use Facade\Ignition\Middleware\AddGitInformation;
	25	+use Facade\Ignition\Middleware\AddLogs;
23	26	use Facade\Ignition\Middleware\AddQueries;
24		-use Facade\Ignition\LogRecorder\LogRecorder;
25	27	use Facade\Ignition\Middleware\AddSolutions;
26		-use Facade\Ignition\Views\Engines\PhpEngine;
27		-use Facade\Ignition\DumpRecorder\DumpRecorder;
28	28	use Facade\Ignition\Middleware\SetNotifierName;
29	29	use Facade\Ignition\QueryRecorder\QueryRecorder;
30		-use Facade\Ignition\Middleware\AddGitInformation;
31		-use Facade\Ignition\Views\Engines\CompilerEngine;
32		-use Facade\Ignition\Context\LaravelContextDetector;
33		-use Facade\Ignition\ErrorPage\IgnitionWhoopsHandler;
34		-use Facade\Ignition\Http\Middleware\IgnitionEnabled;
35		-use Facade\Ignition\Http\Controllers\StyleController;
36		-use Facade\Ignition\Http\Controllers\ScriptController;
37		-use Facade\Ignition\Middleware\AddEnvironmentInformation;
38		-use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
39		-use Facade\Ignition\Http\Controllers\HealthCheckController;
40		-use Facade\Ignition\Http\Controllers\ShareReportController;
41		-use Facade\Ignition\Http\Controllers\IgnitionAssetsController;
42		-use Facade\Ignition\Http\Controllers\ExecuteSolutionController;
43		-use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
44		-use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
45	30	use Facade\Ignition\SolutionProviders\BadMethodCallSolutionProvider;
46	31	use Facade\Ignition\SolutionProviders\DefaultDbNameSolutionProvider;
	32	+use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
	33	+use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
47	34	use Facade\Ignition\SolutionProviders\MergeConflictSolutionProvider;
48	35	use Facade\Ignition\SolutionProviders\MissingAppKeySolutionProvider;
49	36	use Facade\Ignition\SolutionProviders\MissingColumnSolutionProvider;
50	37	use Facade\Ignition\SolutionProviders\MissingImportSolutionProvider;
	38	+use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
	39	+use Facade\Ignition\SolutionProviders\SolutionProviderRepository;
51	40	use Facade\Ignition\SolutionProviders\TableNotFoundSolutionProvider;
	41	+use Facade\Ignition\SolutionProviders\ViewNotFoundSolutionProvider;
	42	+use Facade\Ignition\Views\Engines\CompilerEngine;
	43	+use Facade\Ignition\Views\Engines\PhpEngine;
	44	+use Illuminate\Foundation\Application;
	45	+use Illuminate\Log\Events\MessageLogged;
	46	+use Illuminate\Log\LogManager;
	47	+use Illuminate\Queue\QueueManager;
	48	+use Illuminate\Support\Arr;
	49	+use Illuminate\Support\Facades\Log;
	50	+use Illuminate\Support\Facades\Route;
	51	+use Illuminate\Support\ServiceProvider;
52	52	use Illuminate\View\Engines\CompilerEngine as LaravelCompilerEngine;
53		-use Facade\Ignition\SolutionProviders\MissingPackageSolutionProvider;
54		-use Facade\Ignition\SolutionProviders\InvalidRouteActionSolutionProvider;
55		-use Facade\Ignition\SolutionProviders\IncorrectValetDbCredentialsSolutionProvider;
56		-use Facade\IgnitionContracts\SolutionProviderRepository as SolutionProviderRepositoryContract;
	53	+use Illuminate\View\Engines\PhpEngine as LaravelPhpEngine;
	54	+use Monolog\Logger;
	55	+use Throwable;
	56	+use Whoops\Handler\HandlerInterface;
57	57
58	58	class IgnitionServiceProvider extends ServiceProvider
59	59	{

facade / ignition

Push — master ( 36b547...bd3e66 )

Status

Category

Unused Use Statements +35 added lines, -35 removed lines patch added patch discarded remove patch