Passed
Pull Request — master (#114)
by
unknown
01:24
created

benedict.dicts.keylist.keylist_dict   B

Complexity

Total Complexity 50

Size/Duplication

Total Lines 125
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 105
dl 0
loc 125
rs 8.4
c 0
b 0
f 0
wmc 50

15 Methods

Rating   Name   Duplication   Size   Complexity  
A KeylistDict.__contains__() 0 4 2
A KeylistDict.__init__() 0 2 1
A KeylistDict.__delitem__() 0 5 2
A KeylistDict._contains_by_keys() 0 5 2
A KeylistDict.__getitem__() 0 4 2
A KeylistDict.set() 0 2 1
A KeylistDict.setdefault() 0 5 2
A KeylistDict.pop() 0 4 2
A KeylistDict.__setitem__() 0 5 2
A KeylistDict._getitem_by_keys() 0 9 5
B KeylistDict._pop_by_keys() 0 17 8
A KeylistDict.get() 0 4 2
A KeylistDict._delitem_by_keys() 0 12 5
D KeylistDict._get_by_keys() 0 21 13
A KeylistDict._setitem_by_keys() 0 2 1

How to fix   Complexity   

Complexity

Complex classes like benedict.dicts.keylist.keylist_dict often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# -*- coding: utf-8 -*-
2
3
from benedict.dicts.base import BaseDict
4
from benedict.dicts.keylist import keylist_util
5
from benedict.dicts.keylist.keylist_util import generator_to_list, pop_in_generator
6
from benedict.utils import type_util
7
8
9
class KeylistDict(BaseDict):
10
    def __init__(self, *args, **kwargs):
11
        super(KeylistDict, self).__init__(*args, **kwargs)
12
13
    def __contains__(self, key):
14
        if type_util.is_list_or_tuple(key):
15
            return self._contains_by_keys(key)
16
        return super(KeylistDict, self).__contains__(key)
17
18
    def _contains_by_keys(self, keys):
19
        parent, _, _ = keylist_util.get_item(self, keys)
20
        if type_util.is_dict_or_list_or_tuple(parent):
21
            return True
22
        return False
23
24
    def __delitem__(self, key):
25
        if type_util.is_list_or_tuple(key):
26
            self._delitem_by_keys(key)
27
            return
28
        super(KeylistDict, self).__delitem__(key)
29
30
    def _delitem_by_keys(self, keys):
31
        parent, key, _ = keylist_util.get_item(self, keys)
32
        if type_util.is_dict_or_list(parent) and type_util.is_wildcard(key):
33
            parent.clear()
34
            return
35
        elif type_util.is_dict_or_list(parent):
36
            del parent[key]
37
            return
38
        elif type_util.is_tuple(parent):
39
            # raise the standard TypeError
40
            del parent[key]
41
        raise KeyError(f"Invalid keys: '{keys}'")
42
43
    def __getitem__(self, key):
44
        if type_util.is_list_or_tuple(key):
45
            return self._getitem_by_keys(key)
46
        return super(KeylistDict, self).__getitem__(key)
47
48
    def _getitem_by_keys(self, keys):
49
        parent, key, val = keylist_util.get_item(self, keys)
50
        if type_util.is_generator(val):
51
            return generator_to_list(val)
52
        elif type_util.is_list(parent) and type_util.is_wildcard(key):
53
            return parent
54
        elif type_util.is_dict_or_list_or_tuple(parent):
55
            return parent[key]
56
        raise KeyError(f"Invalid keys: '{keys}'")
57
58
    def __setitem__(self, key, value):
59
        if type_util.is_list_or_tuple(key):
60
            self._setitem_by_keys(key, value)
61
            return
62
        super(KeylistDict, self).__setitem__(key, value)
63
64
    def _setitem_by_keys(self, keys, value):
65
        keylist_util.set_item(self, keys, value)
66
67
    def get(self, key, default=None):
68
        if type_util.is_list_or_tuple(key):
69
            return self._get_by_keys(key, default)
70
        return super(KeylistDict, self).get(key, default)
71
72
    def _get_by_keys(self, keys, default=None):
73
        parent, key, value = keylist_util.get_item(self, keys)
74
        if type_util.is_generator(value) and type_util.is_generator(parent):
75
            data = generator_to_list(value)
76
            if type_util.is_integer(key):
77
                return data[key]
78
            return data
79
        if type_util.is_list_of_list(parent) and type_util.is_wildcard(key):
80
            return value
81
        elif type_util.is_list(parent) and type_util.is_wildcard(key):
82
            return parent
83
        elif type_util.is_wildcard(keys[-2]):
84
            if type_util.is_list_of_dicts(parent):
85
                return [item.get(key) for item in parent]
86
            elif type_util.is_list_of_list(parent):
87
                return value
88
        elif type_util.is_dict(parent):
89
            return parent.get(key, default)
90
        elif type_util.is_list_or_tuple(parent):
91
            return parent[key]
92
        return default
93
94
    def pop(self, key, *args):
95
        if type_util.is_list_or_tuple(key):
96
            return self._pop_by_keys(key, *args)
97
        return super(KeylistDict, self).pop(key, *args)
98
99
    def _pop_by_keys(self, keys, *args):
100
        parent, key, val = keylist_util.get_item(self, keys)
101
        if type_util.is_dict(parent):
102
            return parent.pop(key, *args)
103
        elif type_util.is_generator(val) and type_util.is_generator(parent):
104
            return pop_in_generator(key, parent)
105
        elif type_util.is_wildcard(key):
106
            data = [parent.pop(0) for _ in range(len(parent))]
107
            return data
108
        elif type_util.is_list(parent):
109
            return parent.pop(key)
110
        elif type_util.is_tuple(parent):
111
            # raise the standard TypeError
112
            del parent[key]
113
        if args:
114
            return args[0]
115
        raise KeyError(f"Invalid keys: '{keys}'")
116
117
    def set(self, key, value):
118
        self[key] = value
119
120
    def setdefault(self, key, default=None):
121
        if key not in self:
122
            self[key] = default
123
            return default
124
        return self[key]
125