Passed
Pull Request — master (#114)
by
unknown
04:20
created

KeylistDict._pop_by_keys()   C

Complexity

Conditions 10

Size

Total Lines 19
Code Lines 17

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
eloc 17
dl 0
loc 19
rs 5.9999
c 0
b 0
f 0
cc 10
nop 3

How to fix   Complexity   

Complexity

Complex classes like benedict.dicts.keylist.keylist_dict.KeylistDict._pop_by_keys() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# -*- coding: utf-8 -*-
2
3
from benedict.dicts.base import BaseDict
4
from benedict.dicts.keylist import keylist_util
5
from benedict.utils import type_util
6
7
8
class KeylistDict(BaseDict):
9
    def __init__(self, *args, **kwargs):
10
        super(KeylistDict, self).__init__(*args, **kwargs)
11
12
    def __contains__(self, key):
13
        if type_util.is_list_or_tuple(key):
14
            return self._contains_by_keys(key)
15
        return super(KeylistDict, self).__contains__(key)
16
17
    def _contains_by_keys(self, keys):
18
        parent, _, _ = keylist_util.get_item(self, keys)
19
        if type_util.is_dict_or_list_or_tuple(parent):
20
            return True
21
        return False
22
23
    def __delitem__(self, key):
24
        if type_util.is_list_or_tuple(key):
25
            self._delitem_by_keys(key)
26
            return
27
        super(KeylistDict, self).__delitem__(key)
28
29
    def _delitem_by_keys(self, keys):
30
        parent, key, _ = keylist_util.get_item(self, keys)
31
        if type_util.is_wildcard(key):
32
            self[keys[:-1]].clear()
33
            return
34
        elif type_util.is_dict_or_list(parent):
35
            del parent[key]
36
            return
37
        elif type_util.is_tuple(parent):
38
            # raise the standard TypeError
39
            del parent[key]
40
        raise KeyError(f"Invalid keys: '{keys}'")
41
42
    def __getitem__(self, key):
43
        if type_util.is_list_or_tuple(key):
44
            return self._getitem_by_keys(key)
45
        return super(KeylistDict, self).__getitem__(key)
46
47
    def _getitem_by_keys(self, keys):
48
        parent, key, _ = keylist_util.get_item(self, keys)
49
        if type_util.is_list(parent) and type_util.is_wildcard(key):
50
            return parent
51
        if type_util.is_list_of_dicts(parent) and type_util.any_wildcard_in_list(keys):
52
            return [item.get(key) for item in parent]
53
        if type_util.is_dict_or_list_or_tuple(parent):
54
            return parent[key]
55
        raise KeyError(f"Invalid keys: '{keys}'")
56
57
    def __setitem__(self, key, value):
58
        if type_util.is_list_or_tuple(key):
59
            self._setitem_by_keys(key, value)
60
            return
61
        super(KeylistDict, self).__setitem__(key, value)
62
63
    def _setitem_by_keys(self, keys, value):
64
        keylist_util.set_item(self, keys, value)
65
66
    def get(self, key, default=None):
67
        if type_util.is_list_or_tuple(key):
68
            return self._get_by_keys(key, default)
69
        return super(KeylistDict, self).get(key, default)
70
71
    def _get_by_keys(self, keys, default=None):
72
        parent, key, _ = keylist_util.get_item(self, keys)
73
        if type_util.is_list(parent) and type_util.is_wildcard(key):
74
            return parent
75
        elif type_util.is_wildcard(keys[-2]):
76
            if type_util.is_list_of_dicts(parent):
77
                return [item.get(key) for item in parent]
78
            if type_util.is_list_of_list(parent):
79
                return _
80
        elif type_util.is_dict(parent):
81
            return parent.get(key, default)
82
        elif type_util.is_list_or_tuple(parent):
83
            return parent[key]
84
        return default
85
86
    def pop(self, key, *args):
87
        if type_util.is_list_or_tuple(key):
88
            return self._pop_by_keys(key, *args)
89
        return super(KeylistDict, self).pop(key, *args)
90
91
    def _pop_by_keys(self, keys, *args):
92
        parent, key, _ = keylist_util.get_item(self, keys)
93
        if type_util.is_dict(parent):
94
            return parent.pop(key, *args)
95
        elif type_util.is_list(parent) and type_util.is_wildcard(key):
96
            del self[keys[:-1]]
97
            return parent
98
        elif type_util.is_list_of_dicts(parent) and type_util.any_wildcard_in_list(
99
            keys
100
        ):
101
            return [_item.pop(key) if key in _item else None for _item in parent]
102
        elif type_util.is_list(parent):
103
            return parent.pop(key)
104
        elif type_util.is_tuple(parent):
105
            # raise the standard TypeError
106
            del parent[key]
107
        if args:
108
            return args[0]
109
        raise KeyError(f"Invalid keys: '{keys}'")
110
111
    def set(self, key, value):
112
        self[key] = value
113
114
    def setdefault(self, key, default=None):
115
        if key not in self:
116
            self[key] = default
117
            return default
118
        return self[key]
119