Passed
Pull Request — master (#114)
by
unknown
01:29
created

benedict.dicts.keylist.keylist_dict   B

Complexity

Total Complexity 49

Size/Duplication

Total Lines 125
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 103
dl 0
loc 125
rs 8.48
c 0
b 0
f 0
wmc 49

15 Methods

Rating   Name   Duplication   Size   Complexity  
A KeylistDict.__contains__() 0 4 2
A KeylistDict.__init__() 0 2 1
A KeylistDict.__delitem__() 0 5 2
A KeylistDict._contains_by_keys() 0 5 2
A KeylistDict.__getitem__() 0 4 2
A KeylistDict._delitem_by_keys() 0 12 4
A KeylistDict.set() 0 2 1
A KeylistDict.pop() 0 4 2
A KeylistDict.__setitem__() 0 5 2
B KeylistDict._getitem_by_keys() 0 14 8
A KeylistDict.setdefault() 0 5 2
C KeylistDict._pop_by_keys() 0 19 10
A KeylistDict.get() 0 4 2
B KeylistDict._get_by_keys() 0 14 8
A KeylistDict._setitem_by_keys() 0 2 1

How to fix   Complexity   

Complexity

Complex classes like benedict.dicts.keylist.keylist_dict often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# -*- coding: utf-8 -*-
2
from itertools import chain
3
4
from benedict.dicts.base import BaseDict
5
from benedict.dicts.keylist import keylist_util
6
from benedict.utils import type_util
7
8
9
class KeylistDict(BaseDict):
10
    def __init__(self, *args, **kwargs):
11
        super(KeylistDict, self).__init__(*args, **kwargs)
12
13
    def __contains__(self, key):
14
        if type_util.is_list_or_tuple(key):
15
            return self._contains_by_keys(key)
16
        return super(KeylistDict, self).__contains__(key)
17
18
    def _contains_by_keys(self, keys):
19
        parent, _, _ = keylist_util.get_item(self, keys)
20
        if type_util.is_dict_or_list_or_tuple(parent):
21
            return True
22
        return False
23
24
    def __delitem__(self, key):
25
        if type_util.is_list_or_tuple(key):
26
            self._delitem_by_keys(key)
27
            return
28
        super(KeylistDict, self).__delitem__(key)
29
30
    def _delitem_by_keys(self, keys):
31
        parent, key, _ = keylist_util.get_item(self, keys)
32
        if type_util.is_wildcard(key):
33
            self[keys[:-1]].clear()
34
            return
35
        elif type_util.is_dict_or_list(parent):
36
            del parent[key]
37
            return
38
        elif type_util.is_tuple(parent):
39
            # raise the standard TypeError
40
            del parent[key]
41
        raise KeyError(f"Invalid keys: '{keys}'")
42
43
    def __getitem__(self, key):
44
        if type_util.is_list_or_tuple(key):
45
            return self._getitem_by_keys(key)
46
        return super(KeylistDict, self).__getitem__(key)
47
48
    def _getitem_by_keys(self, keys):
49
        parent, key, _ = keylist_util.get_item(self, keys)
50
        if type_util.is_list(parent) and type_util.is_wildcard(key):
51
            return parent
52
        elif type_util.is_list_of_dicts(parent) and type_util.any_wildcard_in_list(
53
            keys
54
        ):
55
            data = [item.get(key) for item in parent]
56
            if type_util.is_list_of_dicts(data) or type_util.is_list_of_list(data):
57
                return list(chain.from_iterable(data))
58
            return data
59
        elif type_util.is_dict_or_list_or_tuple(parent):
60
            return parent[key]
61
        raise KeyError(f"Invalid keys: '{keys}'")
62
63
    def __setitem__(self, key, value):
64
        if type_util.is_list_or_tuple(key):
65
            self._setitem_by_keys(key, value)
66
            return
67
        super(KeylistDict, self).__setitem__(key, value)
68
69
    def _setitem_by_keys(self, keys, value):
70
        keylist_util.set_item(self, keys, value)
71
72
    def get(self, key, default=None):
73
        if type_util.is_list_or_tuple(key):
74
            return self._get_by_keys(key, default)
75
        return super(KeylistDict, self).get(key, default)
76
77
    def _get_by_keys(self, keys, default=None):
78
        parent, key, value = keylist_util.get_item(self, keys)
79
        if type_util.is_list(parent) and type_util.is_wildcard(key):
80
            return parent
81
        elif type_util.is_wildcard(keys[-2]):
82
            if type_util.is_list_of_dicts(parent):
83
                return [item.get(key) for item in parent]
84
            elif type_util.is_list_of_list(parent):
85
                return value
86
        elif type_util.is_dict(parent):
87
            return parent.get(key, default)
88
        elif type_util.is_list_or_tuple(parent):
89
            return parent[key]
90
        return default
91
92
    def pop(self, key, *args):
93
        if type_util.is_list_or_tuple(key):
94
            return self._pop_by_keys(key, *args)
95
        return super(KeylistDict, self).pop(key, *args)
96
97
    def _pop_by_keys(self, keys, *args):
98
        parent, key, _ = keylist_util.get_item(self, keys)
99
        if type_util.is_dict(parent):
100
            return parent.pop(key, *args)
101
        elif type_util.is_list(parent) and type_util.is_wildcard(key):
102
            del self[keys[:-1]]
103
            return parent
104
        elif type_util.is_list_of_dicts(parent) and type_util.any_wildcard_in_list(
105
            keys
106
        ):
107
            return [_item.pop(key) if key in _item else None for _item in parent]
108
        elif type_util.is_list(parent):
109
            return parent.pop(key)
110
        elif type_util.is_tuple(parent):
111
            # raise the standard TypeError
112
            del parent[key]
113
        if args:
114
            return args[0]
115
        raise KeyError(f"Invalid keys: '{keys}'")
116
117
    def set(self, key, value):
118
        self[key] = value
119
120
    def setdefault(self, key, default=None):
121
        if key not in self:
122
            self[key] = default
123
            return default
124
        return self[key]
125