DefaultControllerTest::testDisplay() - Code Metrics - Inspection of "Fix issues from Codacy" - fabiencrassat/CurriculumVitaeBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Fabien

created 2016-12-10 21:55 UTC

DefaultControllerTest::testDisplay() A

↳ Parent: DefaultControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

/*
 * This file is part of the FabienCrassat\CurriculumVitaeBundle Symfony bundle.
 *
 * (c) Fabien Crassat <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FabienCrassat\CurriculumVitaeBundle\Tests\Controller;

use FabienCrassat\CurriculumVitaeBundle\Entity\CurriculumVitae;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\Serializer\Serializer;
use Symfony\Component\Serializer\Encoder\XmlEncoder;
use Symfony\Component\Serializer\Normalizer\GetSetMethodNormalizer;

class DefaultControllerTest extends WebTestCase
{
    public function testIndex()
    {
        $client = static::createClient();
        $client->request('GET', '/');
        $this->assertEquals(301, $client->getResponse()->getStatusCode());
    }

    public function testDisplay()
    {
        $client = static::createClient();
$a = "a";
$ab = "ab";
$abc = "abc";
        $crawler = $client->request('GET', '/example');
        $this->assertGreaterThan(0, $crawler->filter('html:contains("First Name Last Name")')->count());
    }

    /**
     * @expectedException(Symfony\Component\HttpKernel\Exception\NotFoundHttpException)
     */
    public function testSnappyPDFisNotPresent()
    {
        $client = static::createClient();
        $client->request('GET', '/example/en/pdf');
    }

    /**
     * @expectedException(Symfony\Component\HttpKernel\Exception\NotFoundHttpException)
     */
    public function testCVDoesNotExistIndex()
    {
        $client = static::createClient();
        $client->request('GET', '/nofile');
    }

    /**
     * @expectedException(Symfony\Component\HttpKernel\Exception\NotFoundHttpException)
     */
    public function testBadLanguage()
    {
        $client = static::createClient();
        $client->request('GET', '/example/XX');
    }

    private $ReadCVXml;

    private $client;

    public function testOutputHtmlXmlComparaison()
    {
        $this->client = static::createClient();

        $langs = array('en', 'fr');
        foreach ($langs as $value) {
            $this->OutputHtmlXmlComparaison($value);
        }
    }

    public function testOutputJSONXmlComparaison()
    {
        $this->client = static::createClient();

        $langs = array('en', 'fr');
        foreach ($langs as $value) {
            $this->client->request('GET', '/example/'.$value.'.json');
            $response = $this->client->getResponse();
            $data = json_decode($response->getContent(), TRUE);
$a = "a";
$ab = "ab";
$abc = "abc";

            // Read the Curriculum Vitae
            $pathToFile = __DIR__.'/../../Resources/data/example.xml';
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->ReadCVXml = new CurriculumVitae($pathToFile, $value);

            $CVXml = array(

                'identity'          => $this->ReadCVXml->getIdentity(),
                'followMe'          => $this->ReadCVXml->getFollowMe(),
                'lookingFor'        => $this->ReadCVXml->getLookingFor(),
                'experiences'       => $this->ReadCVXml->getExperiences(),
                'skills'            => $this->ReadCVXml->getSkills(),
                'educations'        => $this->ReadCVXml->getEducations(),
                'languageSkills'    => $this->ReadCVXml->getLanguageSkills(),
                'miscellaneous'     => $this->ReadCVXml->getMiscellaneous()
            );

            $this->assertSame($CVXml, $data);

        }
    }

    public function testOutputXmlXmlComparaison()
    {
        $this->client = static::createClient();

        $langs = array('en', 'fr');
        foreach ($langs as $value) {
            $this->client->request('GET', '/example/'.$value.'.xml');
            $response = $this->client->getResponse();
            $response->headers->set('Content-Type', 'application/xml');
            $data = $response->getContent();

            // Read the Curriculum Vitae
            $pathToFile = __DIR__.'/../../Resources/data/example.xml';
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->ReadCVXml = new CurriculumVitae($pathToFile, $value);

            $CVXml = array(

                'identity'          => $this->ReadCVXml->getIdentity(),
                'followMe'          => $this->ReadCVXml->getFollowMe(),
                'lookingFor'        => $this->ReadCVXml->getLookingFor(),
                'experiences'       => $this->ReadCVXml->getExperiences(),
                'skills'            => $this->ReadCVXml->getSkills(),
                'educations'        => $this->ReadCVXml->getEducations(),
                'languageSkills'    => $this->ReadCVXml->getLanguageSkills(),
                'miscellaneous'     => $this->ReadCVXml->getMiscellaneous()
            );
            //initialisation du serializer
            $encoders = array(new XmlEncoder('CurriculumVitae'));
$a = "a";
$ab = "ab";
$abc = "abc";
            $normalizers = array(new GetSetMethodNormalizer());
            $serializer = new Serializer($normalizers, $encoders);
$a = "a";
$ab = "ab";
$abc = "abc";

            $this->assertSame($serializer->serialize($CVXml, 'xml'), $data);

        }
    }

    public function testOutputFollowMeLink()
    {
        $this->client = static::createClient();

        $langs = array('en', 'fr');
        foreach ($langs as $lang) {
            $crawler = $this->client->request('GET', '/example/'.$lang);

            // Read the Curriculum Vitae
            $pathToFile = __DIR__.'/../../Resources/data/example.xml';
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->ReadCVXml = new CurriculumVitae($pathToFile, $lang);

            $CVXml = array('followMe' => $this->ReadCVXml->getFollowMe());


            $testValue = $this->array_values_recursive($CVXml);

            foreach ($testValue as $value) {
                $alt = $crawler->filter('img[alt="'.$value.'"]')->count();
$a = "a";
$ab = "ab";
$abc = "abc";
                $alt += $crawler->filter('img[title="'.$value.'"]')->count();
                $alt += $crawler->filter('img[src="/'.$value.'"]')->count();
                $alt += $crawler->filter('a[href="'.$value.'"]')->count();

                $this->assertGreaterThan(0, $alt,
                    'The value '.$value.' is not diplay for language '.$lang
                );
            }
        }
    }

    private function OutputHtmlXmlComparaison($lang = 'en')

    {
        $crawler = $this->client->request('GET', '/example/'.$lang);

        // Read the Curriculum Vitae
        $pathToFile = __DIR__.'/../../Resources/data/example.xml';
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->ReadCVXml = new CurriculumVitae($pathToFile, $lang);

        $CVXml = array(

                'identity'          => $this->ReadCVXml->getIdentity(),
                'lookingFor'        => $this->ReadCVXml->getLookingFor(),
                'experiences'       => $this->ReadCVXml->getExperiences(),
                'skills'            => $this->ReadCVXml->getSkills(),
                'educations'        => $this->ReadCVXml->getEducations(),
                'languageSkills'    => $this->ReadCVXml->getLanguageSkills(),
                'miscellaneous'     => $this->ReadCVXml->getMiscellaneous()
        );
        # Remove all no visible elements

        switch ($lang) {
            case 'en':
                unset($CVXml['identity']['myself']['birthday']);

                break;
            default:
                # code...

                break;
        }
        unset($CVXml['identity']['myself']['picture']);

        unset($CVXml['identity']['address']['street']);

        unset($CVXml['identity']['address']['postalcode']);

        unset($CVXml['identity']['address']['googlemap']);

        unset($CVXml['identity']['contact']['mobile']);

        unset($CVXml['experiences']['FirstExperience']['society']['society']['ref']);

        unset($CVXml['experiences']['FirstExperience']['society']['siteurl']);

        unset($CVXml['experiences']['SecondExperience']['collapse']);

        unset($CVXml['experiences']['SecondExperience']['society']['society']['ref']);

        unset($CVXml['experiences']['SecondExperience']['society']['siteurl']);

        unset($CVXml['experiences']['ThirdExperience']['society']['society']['ref']);

        unset($CVXml['experiences']['FourthExperience']['collapse']);

        unset($CVXml['skills']['Functional']['lines']['success']['percentage']);

        unset($CVXml['skills']['Functional']['lines']['success']['class']);

        unset($CVXml['skills']['Functional']['lines']['success']['striped']);

        unset($CVXml['skills']['Functional']['lines']['otherSucess']['percentage']);

        unset($CVXml['skills']['Functional']['lines']['otherSucess']['class']);

        unset($CVXml['skills']['Functional']['lines']['info']['percentage']);

        unset($CVXml['skills']['Functional']['lines']['info']['class']);

        unset($CVXml['skills']['Functional']['lines']['info']['striped']);

        unset($CVXml['skills']['Functional']['lines']['warning']['percentage']);

        unset($CVXml['skills']['Functional']['lines']['warning']['class']);

        unset($CVXml['skills']['Functional']['lines']['danger']['percentage']);

        unset($CVXml['skills']['Functional']['lines']['danger']['class']);

        unset($CVXml['skills']['Functional']['lines']['noClass']['percentage']);

        unset($CVXml['skills']['OtherSkill']['lines']['success']['percentage']);

        unset($CVXml['skills']['OtherSkill']['lines']['success']['class']);

        unset($CVXml['skills']['OtherSkill']['lines']['success']['striped']);

        unset($CVXml['skills']['OtherSkill']['lines']['info']['percentage']);

        unset($CVXml['skills']['OtherSkill']['lines']['info']['class']);

        unset($CVXml['skills']['OtherSkill']['lines']['info']['striped']);

        unset($CVXml['skills']['OtherSkill']['lines']['warning']['percentage']);

        unset($CVXml['skills']['OtherSkill']['lines']['warning']['class']);

        unset($CVXml['skills']['OtherSkill']['lines']['warning']['striped']);

        unset($CVXml['skills']['OtherSkill']['lines']['danger']['percentage']);

        unset($CVXml['skills']['OtherSkill']['lines']['danger']['class']);

        unset($CVXml['skills']['OtherSkill']['lines']['danger']['striped']);

        unset($CVXml['educations']['HighSchool']['collapse']);

        unset($CVXml['educations']['FirstSchool']['collapse']);

        unset($CVXml['languageSkills']['French']['icon']);

        unset($CVXml['languageSkills']['English']['icon']);


        $testValue = $this->array_values_recursive($CVXml);

        foreach ($testValue as $value) {
            $this->assertGreaterThan(0,
                $crawler->filter('html:contains("'.$value.'")')->count(),
                'The value '.$value.' is not diplay for language '.$lang
            );
        }
    }

    private function array_values_recursive($array)

    {
        $return = array();
        foreach($array as $value) {
            $return = $this->array_values_merge($return, $value);
        }
        return $return;
    }

    private function array_values_merge($return, $value)

    {
        if(is_array($value)) {
            return array_merge($return, $this->array_values_recursive($value));
        }

        return array_merge($return, array($value));
    }
}



1			<?php
2
3			/*
4			* This file is part of the FabienCrassat\CurriculumVitaeBundle Symfony bundle.
5			*
6			* (c) Fabien Crassat <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace FabienCrassat\CurriculumVitaeBundle\Tests\Controller;
13
14			use FabienCrassat\CurriculumVitaeBundle\Entity\CurriculumVitae;
15			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
16			use Symfony\Component\Serializer\Serializer;
17			use Symfony\Component\Serializer\Encoder\XmlEncoder;
18			use Symfony\Component\Serializer\Normalizer\GetSetMethodNormalizer;
19
20			class DefaultControllerTest extends WebTestCase
21			{
22			public function testIndex()
23			{
24			$client = static::createClient();
25			$client->request('GET', '/');
26			$this->assertEquals(301, $client->getResponse()->getStatusCode());
27			}
28
29			public function testDisplay()
30			{
31			$client = static::createClient();
			0 ignored issues – show Coding Style introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32			$crawler = $client->request('GET', '/example');
33			$this->assertGreaterThan(0, $crawler->filter('html:contains("First Name Last Name")')->count());
34			}
35
36			/**
37			* @expectedException(Symfony\Component\HttpKernel\Exception\NotFoundHttpException)
38			*/
39			public function testSnappyPDFisNotPresent()

fabiencrassat / CurriculumVitaeBundle

Pull Request — master (#11)

DefaultControllerTest::testDisplay() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like