AgeCalculator - Code Metrics - Inspection of "Fix issues from Codacy" - fabiencrassat/CurriculumVitaeBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Fabien

created 2016-12-10 21:55 UTC

AgeCalculator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

95.12%

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	12
c	2
b	0
f	0
lcom	1
cbo	1
dl	0
loc	81
ccs	39
cts	41
cp	0.9512
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	setToday()	7	1
A	age()	21	4
A	setBirthday()	15	3
A	getAge()	4	1
A	setAgeMinusOne()	4	1
A	setAgeByYear()	4	1

<?php

/*
 * This file is part of the FabienCrassat\CurriculumVitaeBundle Symfony bundle.
 *
 * (c) Fabien Crassat <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FabienCrassat\CurriculumVitaeBundle\Utility;

use Symfony\Component\Serializer\Exception\InvalidArgumentException;

class AgeCalculator
{
    private $birthdayDate;
    private $birthday;
    private $age = 0;
    private $birth;
    private $today;

    /**
     * @param string $birthday
     */
    public function __construct($birthday)
    {
        $this->birthday = $birthday;
        $this->birth = new \stdClass();
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->setBirthday();
        $this->today = new \stdClass();
        $this->setToday();
    }

    public function age()
    {
        // The calculator of the age
        $this->setAgeByYear();

        if ($this->today->month <= $this->birth->month) {
            if ($this->birth->month == $this->today->month) {
                if ($this->birth->day > $this->today->day) {
                    $this->setAgeMinusOne();
                    return $this->getAge();
                }

                return $this->getAge();
            }

            $this->setAgeMinusOne();
            return $this->getAge();
        };

        return $this->getAge();
    }

    private function setBirthday()
    {
        $this->birthdayDate = date_parse_from_format("Y-m-d", $this->birthday);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($this->birthdayDate['error_count'] > 0) {
            throw new InvalidArgumentException("The date (". $this->birthday .") is bad formatted, expected Y-m-d.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        // Retreive the date and transform it to integer
        $this->birth->day   = (int) $this->birthdayDate["day"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->birth->month = (int) $this->birthdayDate["month"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $this->birth->year  = (int) $this->birthdayDate["year"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        if(!checkdate($this->birth->month, $this->birth->day, $this->birth->year)) {
            throw new InvalidArgumentException("The date (". $this->birthday .") is unknown.");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        };
    }

    private function setToday()
    {
        // Retreive today and transform it to integer
        $this->today->day = (int) date('j');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->today->month = (int) date('n');
        $this->today->year = (int) date('Y');
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    private function getAge()
    {
        return $this->age;
    }

    private function setAgeMinusOne()
    {
        $this->age = $this->getAge() - 1;
    }

    private function setAgeByYear()
    {
        $this->age = (int) ($this->today->year - $this->birth->year);
    }
}



1		<?php
2
3		/*
4		* This file is part of the FabienCrassat\CurriculumVitaeBundle Symfony bundle.
5		*
6		* (c) Fabien Crassat <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FabienCrassat\CurriculumVitaeBundle\Utility;
13
14		use Symfony\Component\Serializer\Exception\InvalidArgumentException;
15
16		class AgeCalculator
17		{
18		private $birthdayDate;
19		private $birthday;
20		private $age = 0;
21		private $birth;
22		private $today;
23
24		/**
25		* @param string $birthday
26		*/
27	17	public function __construct($birthday)
28		{
29	17	$this->birthday = $birthday;
30	17	$this->birth = new \stdClass();
		0 ignored issues – show Coding Style introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31	17	$this->setBirthday();
32	15	$this->today = new \stdClass();
33	15	$this->setToday();
34	15	}
35
36	15	public function age()
37		{
38		// The calculator of the age
39	15	$this->setAgeByYear();
40
41	15	if ($this->today->month <= $this->birth->month) {
42	3	if ($this->birth->month == $this->today->month) {
43	3	if ($this->birth->day > $this->today->day) {
44	2	$this->setAgeMinusOne();
45	2	return $this->getAge();
46		}
47
48	1	return $this->getAge();
49		}
50
51		$this->setAgeMinusOne();
52		return $this->getAge();
53		};
54
55	12	return $this->getAge();
56		}
57
58	17	private function setBirthday()
59		{
60	17	$this->birthdayDate = date_parse_from_format("Y-m-d", $this->birthday);
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `Y-m-d` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
61	17	if ($this->birthdayDate['error_count'] > 0) {
62	1	throw new InvalidArgumentException("The date (". $this->birthday .") is bad formatted, expected Y-m-d.");
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `The date (` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `) is bad formatted, expected Y-m-d.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
63		}
64		// Retreive the date and transform it to integer
65	16	$this->birth->day = (int) $this->birthdayDate["day"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `day` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
66	16	$this->birth->month = (int) $this->birthdayDate["month"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `month` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67	16	$this->birth->year = (int) $this->birthdayDate["year"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `year` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
68
69	16	if(!checkdate($this->birth->month, $this->birth->day, $this->birth->year)) {
70	1	throw new InvalidArgumentException("The date (". $this->birthday .") is unknown.");
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `The date (` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report The string literal `) is unknown.` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
71		};
72	15	}
73
74	15	private function setToday()
75		{
76		// Retreive today and transform it to integer
77	15	$this->today->day = (int) date('j');
		0 ignored issues – show Coding Style introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
78	15	$this->today->month = (int) date('n');
79	15	$this->today->year = (int) date('Y');
		0 ignored issues – show Coding Style introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80	15	}
81
82	15	private function getAge()
83		{
84	15	return $this->age;
85		}
86
87	2	private function setAgeMinusOne()
88		{
89	2	$this->age = $this->getAge() - 1;
90	2	}
91
92	15	private function setAgeByYear()
93		{
94	15	$this->age = (int) ($this->today->year - $this->birth->year);
95	15	}
96		}
		0 ignored issues – show Coding Style introduced 2016-12-10 21:46 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
97

fabiencrassat / CurriculumVitaeBundle

Pull Request — master (#11)

AgeCalculator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like