fabiang / assetic-module

src/CacheBuster/LastModifiedStrategy.php

<?php

declare(strict_types=1);

namespace Fabiang\AsseticBundle\CacheBuster;

use Assetic\Contracts\Asset\AssetInterface;
use Assetic\Contracts\Factory\Worker\WorkerInterface;
use Assetic\Factory\AssetFactory;

use function pathinfo;
use function strlen;
use function substr_replace;

use const PATHINFO_EXTENSION;

class LastModifiedStrategy implements WorkerInterface
{
    public function process(AssetInterface $asset, AssetFactory $factory): ?AssetInterface
    {
        $path = $asset->getTargetPath();
        if (null === $path) {
            return null;
        }

        $ext = pathinfo($path, PATHINFO_EXTENSION);

        $lastModified = $factory->getLastModified($asset);
        if (null !== $lastModified) {
            $path = substr_replace(
                $path,
                "$lastModified.$ext",
                -1 * strlen($ext)

It seems like $ext can also be of type array; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

            );
            $asset->setTargetPath($path);

It seems like $path can also be of type array; however, parameter $targetPath of Assetic\Contracts\Asset\AssetInterface::setTargetPath() does only seem to accept string, maybe add an additional type check?

        }
        return null;
    }
}