Issues in SortSpecLexer.php (master) - Issues in master - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3103)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Core/QueryType/BuiltIn/SortSpec/SortSpecLexer.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Publish\Core\QueryType\BuiltIn\SortSpec;

final class SortSpecLexer implements SortSpecLexerInterface
{
    private const K_ASC = 'asc';
    private const K_DESC = 'desc';

    private const ID_PATTERN = '[a-zA-Z_][a-zA-Z0-9_]*';
    private const FLOAT_PATTERN = '-?[0-9]+\.[0-9]+';
    private const INT_PATTERN = '-?[0-9]+';

    /** @var string */
    private $input;

    /** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token[] */
    private $tokens = [];

    /** @var int|null */
    private $position;

    /** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token|null */
    private $current;

    /** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token|null */
    private $next;

    public function getAll(): iterable
    {
        return $this->tokens;
    }

    public function consume(): Token
    {
        $this->current = $this->next;
        $this->next = $this->tokens[++$this->position] ?? null;

        return $this->current;
    }

    public function isEOF(): bool
    {
        return $this->next === null || $this->next->isA(Token::TYPE_EOF);
    }

    public function peek(): ?Token
    {
        return $this->next;
    }

    public function getInput(): string
    {
        return $this->input;
    }

    public function tokenize(string $input): void
    {
        $this->reset();

        $this->input = $input;
        $this->tokens = [];
        foreach ($this->split($input) as $match) {
            [$value, $position] = $match;
            $value = trim($value);

            if ($value === '') {
                // Skip whitespaces
                continue;
            }

            $this->tokens[] = new Token(
                $this->getTokenType($value),
                $value,
                $position
            );
        }

        $this->tokens[] = new Token(Token::TYPE_EOF);
        $this->next = $this->tokens[0] ?? null;
    }

    private function reset(): void
    {
        $this->position = 0;
        $this->next = null;
        $this->current = null;
    }

    private function split(string $input): array
    {
        $regexp = sprintf(
            '/^(asc)|(desc)|(\\.)|(,)|(%s)|\s+$/iu',
            implode(')|(', [
                self::FLOAT_PATTERN,
                self::INT_PATTERN,
                self::ID_PATTERN,
            ]),
        );


        $flags = PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_OFFSET_CAPTURE;

        return preg_split($regexp, $input, -1, $flags);
    }

    private function getTokenType(string $value): string
    {
        switch ($value) {
            case self::K_ASC:
                return Token::TYPE_ASC;
            case self::K_DESC:
                return Token::TYPE_DESC;
            case '.':
                return Token::TYPE_DOT;
            case ',':
                return Token::TYPE_COMMA;
        }

        if ($this->isInt($value)) {
            return Token::TYPE_INT;
        }

        if ($this->isFloat($value)) {
            return Token::TYPE_FLOAT;
        }

        if ($this->isID($value)) {
            return Token::TYPE_ID;
        }

        return Token::TYPE_NONE;
    }

    private function isInt(string $value): bool
    {
        return preg_match('/^' . self::INT_PATTERN . '$/', $value) === 1;
    }

    private function isFloat(string $value): bool
    {
        return preg_match('/^' . self::FLOAT_PATTERN . '$/', $value) === 1;
    }

    private function isID(string $value): bool
    {
        return preg_match('/^' . self::ID_PATTERN . '$/', $value) === 1;
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace eZ\Publish\Core\QueryType\BuiltIn\SortSpec;
10
11			final class SortSpecLexer implements SortSpecLexerInterface
12			{
13			private const K_ASC = 'asc';
14			private const K_DESC = 'desc';
15
16			private const ID_PATTERN = '[a-zA-Z_][a-zA-Z0-9_]*';
17			private const FLOAT_PATTERN = '-?[0-9]+\.[0-9]+';
18			private const INT_PATTERN = '-?[0-9]+';
19
20			/** @var string */
21			private $input;
22
23			/** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token[] */
24			private $tokens = [];
25
26			/** @var int\|null */
27			private $position;
28
29			/** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token\|null */
30			private $current;
31
32			/** @var \eZ\Publish\Core\QueryType\BuiltIn\SortSpec\Token\|null */
33			private $next;
34
35			public function getAll(): iterable
36			{
37			return $this->tokens;
38			}
39
40			public function consume(): Token
41			{
42			$this->current = $this->next;
43			$this->next = $this->tokens[++$this->position] ?? null;
44
45			return $this->current;
46			}
47
48			public function isEOF(): bool
49			{
50			return $this->next === null \|\| $this->next->isA(Token::TYPE_EOF);
51			}
52
53			public function peek(): ?Token
54			{
55			return $this->next;
56			}
57
58			public function getInput(): string
59			{
60			return $this->input;
61			}
62
63			public function tokenize(string $input): void
64			{
65			$this->reset();
66
67			$this->input = $input;
68			$this->tokens = [];
69			foreach ($this->split($input) as $match) {
70			[$value, $position] = $match;
71			$value = trim($value);
72
73			if ($value === '') {
74			// Skip whitespaces
75			continue;
76			}
77
78			$this->tokens[] = new Token(
79			$this->getTokenType($value),
80			$value,
81			$position
82			);
83			}
84
85			$this->tokens[] = new Token(Token::TYPE_EOF);
86			$this->next = $this->tokens[0] ?? null;
87			}
88
89			private function reset(): void
90			{
91			$this->position = 0;
92			$this->next = null;
93			$this->current = null;
94			}
95
96			private function split(string $input): array
97			{
98			$regexp = sprintf(
99			'/^(asc)\|(desc)\|(\\.)\|(,)\|(%s)\|\s+$/iu',
100			implode(')\|(', [
101			self::FLOAT_PATTERN,
102			self::INT_PATTERN,
103			self::ID_PATTERN,
104			]),
105			);
			0 ignored issues – show Bug introduced 2020-02-26 11:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')' Loading history...
106
107			$flags = PREG_SPLIT_NO_EMPTY \| PREG_SPLIT_DELIM_CAPTURE \| PREG_SPLIT_OFFSET_CAPTURE;
108
109			return preg_split($regexp, $input, -1, $flags);
110			}
111
112			private function getTokenType(string $value): string
113			{
114			switch ($value) {
115			case self::K_ASC:
116			return Token::TYPE_ASC;
117			case self::K_DESC:
118			return Token::TYPE_DESC;
119			case '.':
120			return Token::TYPE_DOT;
121			case ',':
122			return Token::TYPE_COMMA;
123			}
124
125			if ($this->isInt($value)) {
126			return Token::TYPE_INT;
127			}
128
129			if ($this->isFloat($value)) {
130			return Token::TYPE_FLOAT;
131			}
132
133			if ($this->isID($value)) {
134			return Token::TYPE_ID;
135			}
136
137			return Token::TYPE_NONE;
138			}
139
140			private function isInt(string $value): bool
141			{
142			return preg_match('/^' . self::INT_PATTERN . '$/', $value) === 1;
143			}
144
145			private function isFloat(string $value): bool
146			{
147			return preg_match('/^' . self::FLOAT_PATTERN . '$/', $value) === 1;
148			}
149
150			private function isID(string $value): bool
151			{
152			return preg_match('/^' . self::ID_PATTERN . '$/', $value) === 1;
153			}
154			}
155

ezsystems / ezpublish-kernel

Issues (3103)

Security Analysis not enabled

Core/QueryType/BuiltIn/SortSpec/SortSpecLexer.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like