LogicalAndTest::getPayloads() - Code Metrics - Inspection of "EZP-30806: Fixed processing REST logical op. input..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 6.13 ( d8f059...2d8437 )

unknown

created 2019-12-05 14:17 UTC

LogicalAndTest::getPayloads() B

↳ Parent: LogicalAndTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	69
rs	8.6763
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\REST\Server\Tests\Input\Parser\Criterion;

use eZ\Publish\API\Repository\Values\Content;
use eZ\Publish\Core\REST\Common\Exceptions\Parser as ParserException;
use eZ\Publish\Core\REST\Common\Input\ParsingDispatcher;
use eZ\Publish\Core\REST\Server\Input\Parser;

class LogicalAndTest extends LogicalOperatorTestCase
{
    /**
     * Data provider for LogicalOr::parse test.
     *
     * @see testParse
     *
     * Notice regarding multiple criteria of same type:
     *
     * The XML decoder of eZ is not creating numeric arrays, instead using the tag as the array key.
     * This causes the ContentTypeIdentifierCriterion Tag to appear as one-element
     * (type numeric array) and two criteria configuration inside. The logical AND parser will take
     * care of this and return a flat LogicalAnd criterion with 3 criteria inside for the following
     * payload:
     *
     * ```
     * <AND>
     *   <ContentTypeIdentifierCriterion>author</ContentTypeIdentifierCriterion>
     *   <ContentTypeIdentifierCriterion>book</ContentTypeIdentifierCriterion>
     *   <Field>
     *     <name>title</name>
     *     <operator>EQ</operator>
     *     <value>Contributing to projects</value>
     *   </Field>
     * </AND>
     * ```
     */
    public function getPayloads()
    {
        return [
            'Simple AND Criterion' => [
                [
                    'AND' => [
                        'ContentTypeIdentifierCriterion' => [
                            0 => 'author',
                            1 => 'book',
                        ],
                        'Field' => [
                            'name' => 'title',
                            'operator' => 'EQ',
                            'value' => 'Contributing to projects',
                        ],
                    ],
                ],
                3,
            ],
            'Combined AND with nested OR Criterion' => [
                [
                    'AND' => [
                        [
                            'OR' => [
                                'ContentTypeIdentifierCriterion' => [
                                    'article',
                                    'folder',
                                ],
                            ],
                        ],
                        [
                            'OR' => [
                                'ContentTypeIdentifierCriterion' => [
                                    'forum',
                                    'board',
                                ],
                            ],
                        ],
                    ],
                ],
                2,
            ],
            'Combined AND with nested OR Criterion using old format' => [
                [
                    'AND' => [
                        [
                            'OR' => [
                                [
                                    'ContentTypeIdentifierCriterion' => [
                                        'article',
                                        'folder',
                                    ],
                                ],
                            ],
                        ],
                        [
                            'OR' => [
                                'ContentTypeIdentifierCriterion' => [
                                    'forum',
                                    'board',
                                ],
                            ],
                        ],
                    ],
                ],
                2,
            ],
        ];
    }

    public function testThrowsExceptionOnInvalidAndStatement()
    {
        $this->expectException(ParserException::class);
        $this->internalGetParser()->parse(['AND' => 'Should be an array'], new ParsingDispatcher());
    }

    /**
     * @return \eZ\Publish\Core\REST\Server\Input\Parser\Criterion\LogicalAnd
     */
    protected function internalGetParser()
    {
        return new Parser\Criterion\LogicalAnd();
    }

    protected function getCriterionClass()
    {
        return Content\Query\Criterion\LogicalAnd::class;
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			namespace eZ\Publish\Core\REST\Server\Tests\Input\Parser\Criterion;
8
9			use eZ\Publish\API\Repository\Values\Content;
10			use eZ\Publish\Core\REST\Common\Exceptions\Parser as ParserException;
11			use eZ\Publish\Core\REST\Common\Input\ParsingDispatcher;
12			use eZ\Publish\Core\REST\Server\Input\Parser;
13
14			class LogicalAndTest extends LogicalOperatorTestCase
15			{
16			/**
17			* Data provider for LogicalOr::parse test.
18			*
19			* @see testParse
20			*
21			* Notice regarding multiple criteria of same type:
22			*
23			* The XML decoder of eZ is not creating numeric arrays, instead using the tag as the array key.
24			* This causes the ContentTypeIdentifierCriterion Tag to appear as one-element
25			* (type numeric array) and two criteria configuration inside. The logical AND parser will take
26			* care of this and return a flat LogicalAnd criterion with 3 criteria inside for the following
27			* payload:
28			*
29			* ```
30			* <AND>
31			* <ContentTypeIdentifierCriterion>author</ContentTypeIdentifierCriterion>
32			* <ContentTypeIdentifierCriterion>book</ContentTypeIdentifierCriterion>
33			* <Field>
34			* <name>title</name>
35			* <operator>EQ</operator>
36			* <value>Contributing to projects</value>
37			* </Field>
38			* </AND>
39			* ```
40			*/
41			public function getPayloads()
42			{
43			return [
44			'Simple AND Criterion' => [
45			[
46			'AND' => [
47			'ContentTypeIdentifierCriterion' => [
48			0 => 'author',
49			1 => 'book',
50			],
51			'Field' => [
52			'name' => 'title',
53			'operator' => 'EQ',
54			'value' => 'Contributing to projects',
55			],
56			],
57			],
58			3,
59			],
60			'Combined AND with nested OR Criterion' => [
61			[
62			'AND' => [
63			[
64			'OR' => [
65			'ContentTypeIdentifierCriterion' => [
66			'article',
67			'folder',
68			],
69			],
70			],
71			[
72			'OR' => [
73			'ContentTypeIdentifierCriterion' => [
74			'forum',
75			'board',
76			],
77			],
78			],
79			],
80			],
81			2,
82			],
83			'Combined AND with nested OR Criterion using old format' => [
84			[
85			'AND' => [
86			[
87			'OR' => [
88			[
89			'ContentTypeIdentifierCriterion' => [
90			'article',
91			'folder',
92			],
93			],
94			],
95			],
96			[
97			'OR' => [
98			'ContentTypeIdentifierCriterion' => [
99			'forum',
100			'board',
101			],
102			],
103			],
104			],
105			],
106			2,
107			],
108			];
109			}
110
111			public function testThrowsExceptionOnInvalidAndStatement()
112			{
113			$this->expectException(ParserException::class);
114			$this->internalGetParser()->parse(['AND' => 'Should be an array'], new ParsingDispatcher());
115			}
116
117			/**
118			* @return \eZ\Publish\Core\REST\Server\Input\Parser\Criterion\LogicalAnd
119			*/
120			protected function internalGetParser()
121			{
122			return new Parser\Criterion\LogicalAnd();
123			}
124
125			protected function getCriterionClass()
126			{
127			return Content\Query\Criterion\LogicalAnd::class;
128			}
129			}
130

ezsystems / ezpublish-kernel

Push — 6.13 ( d8f059...2d8437 )

LogicalAndTest::getPayloads() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like